Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
e4a27cf4
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
e4a27cf4
编写于
6月 19, 2019
作者:
M
Manish Vasani
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Adjust unsuppressed error check and doc comments.
上级
a1859bf8
变更
3
显示空白变更内容
内联
并排
Showing
3 changed file
with
17 addition
and
9 deletion
+17
-9
src/Compilers/Core/Portable/CommandLine/CommonCompiler.cs
src/Compilers/Core/Portable/CommandLine/CommonCompiler.cs
+7
-6
src/Compilers/Core/Portable/Compilation/Compilation.cs
src/Compilers/Core/Portable/Compilation/Compilation.cs
+2
-3
src/Compilers/Core/Portable/Diagnostic/Diagnostic.cs
src/Compilers/Core/Portable/Diagnostic/Diagnostic.cs
+8
-0
未找到文件。
src/Compilers/Core/Portable/CommandLine/CommonCompiler.cs
浏览文件 @
e4a27cf4
...
...
@@ -560,18 +560,19 @@ internal bool ReportDiagnostics(IEnumerable<DiagnosticInfo> diagnostics, TextWri
=>
ReportDiagnostics
(
diagnostics
.
Select
(
info
=>
Diagnostic
.
Create
(
info
)),
consoleOutput
,
errorLoggerOpt
);
/// <summary>
/// Returns true if there are any diagnostics in the bag which have default severity error and are
/// not marked "suppressed". Note: does NOT do filtering, so it may return false if a
/// Returns true if there are any error diagnostics in the bag which cannot be suppressed and
/// are guaranteed to break the build.
/// Only diagnostics which have default severity error and are tagged as NotConfigurable fall in this bucket.
/// This includes all compiler error diagnostics and specific analyzer error diagnostics that are marked as not configurable by the analyzer author.
/// Note: does NOT do filtering, so it may return false if a
/// non-error diagnostic were later elevated to an error through filtering (e.g., through
/// warn-as-error). This is meant to be a check if there are any "real" errors, in the bag
/// since diagnostics with default "error" severity can never be suppressed or reduced
/// below error severity.
/// warn-as-error).
/// </summary>
internal
static
bool
HasUnsuppressedErrors
(
DiagnosticBag
diagnostics
)
{
foreach
(
var
diag
in
diagnostics
.
AsEnumerable
())
{
if
(
diag
.
DefaultSeverity
==
DiagnosticSeverity
.
Error
&&
!
diag
.
IsSuppressed
)
if
(
diag
.
IsUnsuppressedError
()
)
{
return
true
;
}
...
...
src/Compilers/Core/Portable/Compilation/Compilation.cs
浏览文件 @
e4a27cf4
...
...
@@ -1347,7 +1347,7 @@ internal void CompleteCompilationEventQueue_NoLock()
/// </summary>
/// <param name="accumulator">Bag to which filtered diagnostics will be added.</param>
/// <param name="incoming">Diagnostics to be filtered.</param>
/// <returns>True if there
were no errors
.</returns>
/// <returns>True if there
are no unsuppressed errors (i.e., no errors which fail compilation)
.</returns>
internal
bool
FilterAndAppendAndFreeDiagnostics
(
DiagnosticBag
accumulator
,
ref
DiagnosticBag
incoming
)
{
bool
result
=
FilterAndAppendDiagnostics
(
accumulator
,
incoming
.
AsEnumerableWithoutResolution
(),
exclude
:
null
);
...
...
@@ -1378,8 +1378,7 @@ internal bool FilterAndAppendDiagnostics(DiagnosticBag accumulator, IEnumerable<
{
continue
;
}
else
if
(
filtered
.
DefaultSeverity
==
DiagnosticSeverity
.
Error
&&
!
filtered
.
IsSuppressed
)
else
if
(
filtered
.
IsUnsuppressedError
())
{
hasError
=
true
;
}
...
...
src/Compilers/Core/Portable/Diagnostic/Diagnostic.cs
浏览文件 @
e4a27cf4
...
...
@@ -559,6 +559,14 @@ internal virtual bool IsNotConfigurable()
{
return
AnalyzerManager
.
HasNotConfigurableTag
(
this
.
CustomTags
);
}
/// <summary>
/// Returns true if this is an error diagnostic which cannot be suppressed and is guaranteed to break the build.
/// Only diagnostics which have default severity error and are tagged as NotConfigurable fall in this bucket.
/// This includes all compiler error diagnostics and specific analyzer error diagnostics that are marked as not configurable by the analyzer author.
/// </summary>
internal
bool
IsUnsuppressedError
()
=>
DefaultSeverity
==
DiagnosticSeverity
.
Error
&&
IsNotConfigurable
();
}
/// <summary>
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录