提交 cfa2d9e3 编写于 作者: C Cyrus Najmabadi

Remove unused method from sighelp

上级 1d4a8a99
...@@ -10,8 +10,7 @@ namespace Microsoft.CodeAnalysis.Editor.Implementation.IntelliSense ...@@ -10,8 +10,7 @@ namespace Microsoft.CodeAnalysis.Editor.Implementation.IntelliSense
{ {
internal interface IDocumentProvider internal interface IDocumentProvider
{ {
Task<Document> GetDocumentAsync(ITextSnapshot snapshot, CancellationToken cancellationToken); Document GetDocument(ITextSnapshot snapshot, CancellationToken cancellationToken);
Document GetOpenDocumentInCurrentContextWithChanges(ITextSnapshot snapshot);
} }
internal class DocumentProvider : ForegroundThreadAffinitizedObject, IDocumentProvider internal class DocumentProvider : ForegroundThreadAffinitizedObject, IDocumentProvider
...@@ -21,16 +20,10 @@ public DocumentProvider(IThreadingContext threadingContext) ...@@ -21,16 +20,10 @@ public DocumentProvider(IThreadingContext threadingContext)
{ {
} }
public Task<Document> GetDocumentAsync(ITextSnapshot snapshot, CancellationToken cancellationToken) public Document GetDocument(ITextSnapshot snapshot, CancellationToken cancellationToken)
{ {
AssertIsBackground(); AssertIsBackground();
return Task.FromResult(snapshot.AsText().GetDocumentWithFrozenPartialSemantics(cancellationToken)); return snapshot.AsText().GetDocumentWithFrozenPartialSemantics(cancellationToken);
}
public Document GetOpenDocumentInCurrentContextWithChanges(ITextSnapshot snapshot)
{
var text = snapshot.AsText();
return text.GetOpenDocumentInCurrentContextWithChanges();
} }
} }
} }
...@@ -55,7 +55,7 @@ internal partial class Session ...@@ -55,7 +55,7 @@ internal partial class Session
AssertIsBackground(); AssertIsBackground();
cancellationToken.ThrowIfCancellationRequested(); cancellationToken.ThrowIfCancellationRequested();
var document = await Controller.DocumentProvider.GetDocumentAsync(caretPosition.Snapshot, cancellationToken).ConfigureAwait(false); var document = Controller.DocumentProvider.GetDocument(caretPosition.Snapshot, cancellationToken);
if (document == null) if (document == null)
{ {
return currentModel; return currentModel;
......
...@@ -25,7 +25,7 @@ Namespace Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense ...@@ -25,7 +25,7 @@ Namespace Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense
<WpfFact> <WpfFact>
Public Sub InvokeSignatureHelpWithoutDocumentShouldNotStartNewSession() Public Sub InvokeSignatureHelpWithoutDocumentShouldNotStartNewSession()
Dim emptyProvider = New Mock(Of IDocumentProvider) Dim emptyProvider = New Mock(Of IDocumentProvider)
emptyProvider.Setup(Function(p) p.GetDocumentAsync(It.IsAny(Of ITextSnapshot), It.IsAny(Of CancellationToken))).Returns(Task.FromResult(DirectCast(Nothing, Document))) emptyProvider.Setup(Function(p) p.GetDocument(It.IsAny(Of ITextSnapshot), It.IsAny(Of CancellationToken))).Returns(DirectCast(Nothing, Document))
Dim controller As Controller = CreateController(documentProvider:=emptyProvider) Dim controller As Controller = CreateController(documentProvider:=emptyProvider)
controller.WaitForController() controller.WaitForController()
...@@ -217,7 +217,7 @@ Namespace Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense ...@@ -217,7 +217,7 @@ Namespace Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense
New TypeCharCommandArgs(CreateMock(Of ITextView), CreateMock(Of ITextBuffer), "a"c), New TypeCharCommandArgs(CreateMock(Of ITextView), CreateMock(Of ITextBuffer), "a"c),
Sub() GetMocks(controller).Buffer.Insert(0, "a"), TestCommandExecutionContext.Create()) Sub() GetMocks(controller).Buffer.Insert(0, "a"), TestCommandExecutionContext.Create())
GetMocks(controller).DocumentProvider.Verify(Function(p) p.GetDocumentAsync(It.IsAny(Of ITextSnapshot), It.IsAny(Of CancellationToken)), Times.Never) GetMocks(controller).DocumentProvider.Verify(Function(p) p.GetDocument(It.IsAny(Of ITextSnapshot), It.IsAny(Of CancellationToken)), Times.Never)
End Sub End Sub
Private Shared ReadOnly s_controllerMocksMap As New ConditionalWeakTable(Of Controller, ControllerMocks) Private Shared ReadOnly s_controllerMocksMap As New ConditionalWeakTable(Of Controller, ControllerMocks)
...@@ -251,8 +251,7 @@ Namespace Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense ...@@ -251,8 +251,7 @@ Namespace Microsoft.CodeAnalysis.Editor.UnitTests.IntelliSense
Dim asyncListener = New Mock(Of IAsynchronousOperationListener) Dim asyncListener = New Mock(Of IAsynchronousOperationListener)
If documentProvider Is Nothing Then If documentProvider Is Nothing Then
documentProvider = New Mock(Of IDocumentProvider) documentProvider = New Mock(Of IDocumentProvider)
documentProvider.Setup(Function(p) p.GetDocumentAsync(It.IsAny(Of ITextSnapshot), It.IsAny(Of CancellationToken))).Returns(Task.FromResult(document)) documentProvider.Setup(Function(p) p.GetDocument(It.IsAny(Of ITextSnapshot), It.IsAny(Of CancellationToken))).Returns(document)
documentProvider.Setup(Function(p) p.GetOpenDocumentInCurrentContextWithChanges(It.IsAny(Of ITextSnapshot))).Returns(document)
End If End If
If provider Is Nothing Then If provider Is Nothing Then
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册