From c8097b89aca2dc9eb769c9d33d42df62b761b4ac Mon Sep 17 00:00:00 2001 From: Jared Parsons Date: Wed, 25 Jul 2018 08:38:07 -0700 Subject: [PATCH] Disable icacls use on Helix The icacls command is failing on Helix hence disabling these tests there for now Related to #28836 --- src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs | 8 ++++++++ .../VisualBasic/Test/CommandLine/CommandLineTests.vb | 7 +++++++ 2 files changed, 15 insertions(+) diff --git a/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs b/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs index e9575899887..b10a779bb3f 100644 --- a/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs +++ b/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs @@ -4975,6 +4975,14 @@ public void Bug15538() { return; } + + // The icacls command fails on our Helix machines and it appears to be related to the use of the $ in + // the username. + // https://github.com/dotnet/roslyn/issues/28836 + if (StringComparer.OrdinalIgnoreCase.Equals(Environment.UserDomainName, "WORKGROUP")) + { + return; + } } var folder = Temp.CreateDirectory(); diff --git a/src/Compilers/VisualBasic/Test/CommandLine/CommandLineTests.vb b/src/Compilers/VisualBasic/Test/CommandLine/CommandLineTests.vb index ecd39e7d65c..1a4136e45af 100644 --- a/src/Compilers/VisualBasic/Test/CommandLine/CommandLineTests.vb +++ b/src/Compilers/VisualBasic/Test/CommandLine/CommandLineTests.vb @@ -6362,6 +6362,13 @@ End Module Public Sub Bug15538() + ' The icacls command fails on our Helix machines And it appears to be related to the use of the $ in + ' the username. + ' https://github.com/dotnet/roslyn/issues/28836 + If StringComparer.OrdinalIgnoreCase.Equals(Environment.UserDomainName, "WORKGROUP") Then + Return + End If + Dim folder = Temp.CreateDirectory() Dim source As String = folder.CreateFile("src.vb").WriteAllText("").Path Dim ref As String = folder.CreateFile("ref.dll").WriteAllText("").Path -- GitLab