From c31868d22bff4f66e8e95d0beddf07c0151d13cd Mon Sep 17 00:00:00 2001 From: Cyrus Najmabadi Date: Wed, 18 Dec 2019 13:43:49 -0800 Subject: [PATCH] One more place --- .../HighlightingService.cs | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/EditorFeatures/Core/Implementation/KeywordHighlighting/HighlightingService.cs b/src/EditorFeatures/Core/Implementation/KeywordHighlighting/HighlightingService.cs index 64704a8256c..cf4b801c785 100644 --- a/src/EditorFeatures/Core/Implementation/KeywordHighlighting/HighlightingService.cs +++ b/src/EditorFeatures/Core/Implementation/KeywordHighlighting/HighlightingService.cs @@ -27,23 +27,23 @@ internal class HighlightingService : IHighlightingService public void AddHighlights( SyntaxNode root, int position, List highlights, CancellationToken cancellationToken) { - using var _ = s_listPool.GetPooledObject(); - var tempHighlights = _.Object; - - foreach (var highlighter in _highlighters.Where(h => h.Metadata.Language == root.Language)) + using (s_listPool.GetPooledObject(out var tempHighlights)) { - cancellationToken.ThrowIfCancellationRequested(); - highlighter.Value.AddHighlights(root, position, tempHighlights, cancellationToken); - } + foreach (var highlighter in _highlighters.Where(h => h.Metadata.Language == root.Language)) + { + cancellationToken.ThrowIfCancellationRequested(); + highlighter.Value.AddHighlights(root, position, tempHighlights, cancellationToken); + } - tempHighlights.Sort(); - var lastSpan = default(TextSpan); - foreach (var span in tempHighlights) - { - if (span != lastSpan && !span.IsEmpty) + tempHighlights.Sort(); + var lastSpan = default(TextSpan); + foreach (var span in tempHighlights) { - highlights.Add(span); - lastSpan = span; + if (span != lastSpan && !span.IsEmpty) + { + highlights.Add(span); + lastSpan = span; + } } } } -- GitLab