Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
bfadc397
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
bfadc397
编写于
11月 04, 2016
作者:
M
Matt Warren
提交者:
GitHub
11月 04, 2016
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #14918 from mattwar/Bug11726
simplify syntax tree task caching
上级
4168691d
7b0f151f
变更
1
显示空白变更内容
内联
并排
Showing
1 changed file
with
15 addition
and
49 deletion
+15
-49
src/Workspaces/Core/Portable/Workspace/Solution/Document.cs
src/Workspaces/Core/Portable/Workspace/Solution/Document.cs
+15
-49
未找到文件。
src/Workspaces/Core/Portable/Workspace/Solution/Document.cs
浏览文件 @
bfadc397
...
...
@@ -139,60 +139,35 @@ public bool SupportsSemanticModel
}
}
private
Task
<
SyntaxTree
>
GetExistingSyntaxTreeTask
()
/// <summary>
/// Gets the <see cref="SyntaxTree" /> for this document asynchronously.
/// </summary>
public
Task
<
SyntaxTree
>
GetSyntaxTreeAsync
(
CancellationToken
cancellationToken
=
default
(
CancellationToken
))
{
if
(
_syntaxTreeResultTask
!=
null
)
// If the language doesn't support getting syntax trees for a document, then bail out immediately.
if
(!
this
.
SupportsSyntaxTree
)
{
return
_syntaxTreeResultTask
;
return
SpecializedTasks
.
Default
<
SyntaxTree
>()
;
}
// First see if we already have a semantic model computed. If so, we can just return
// that syntax tree.
SemanticModel
semanticModel
;
if
(
TryGetSemanticModel
(
out
semanticModel
))
// if we have a cached result task use it
if
(
_syntaxTreeResultTask
!=
null
)
{
// PERF: This is a hot code path, so cache the result to reduce allocations
var
result
=
Task
.
FromResult
(
semanticModel
.
SyntaxTree
);
Interlocked
.
CompareExchange
(
ref
_syntaxTreeResultTask
,
result
,
null
);
return
_syntaxTreeResultTask
;
}
//
second, see whether we already computed the tree, if we already did, return the cache
//
check to see if we already have the tree before actually going async
SyntaxTree
tree
;
if
(
TryGetSyntaxTree
(
out
tree
))
{
if
(
_syntaxTreeResultTask
==
null
)
{
var
result
=
Task
.
FromResult
(
tree
);
Interlocked
.
CompareExchange
(
ref
_syntaxTreeResultTask
,
result
,
null
);
}
// stash a completed result task for this value for the next request (to reduce extraneous allocations of tasks)
// don't use the actual async task because it depends on a specific cancellation token
// its okay to cache the task and hold onto the SyntaxTree, because the DocumentState already keeps the SyntaxTree alive.
Interlocked
.
CompareExchange
(
ref
_syntaxTreeResultTask
,
Task
.
FromResult
(
tree
),
null
);
return
_syntaxTreeResultTask
;
}
return
null
;
}
/// <summary>
/// Gets the <see cref="SyntaxTree" /> for this document asynchronously.
/// </summary>
public
Task
<
SyntaxTree
>
GetSyntaxTreeAsync
(
CancellationToken
cancellationToken
=
default
(
CancellationToken
))
{
// If the language doesn't support getting syntax trees for a document, then bail out
// immediately.
if
(!
this
.
SupportsSyntaxTree
)
{
return
SpecializedTasks
.
Default
<
SyntaxTree
>();
}
var
syntaxTreeTask
=
GetExistingSyntaxTreeTask
();
if
(
syntaxTreeTask
!=
null
)
{
return
syntaxTreeTask
;
}
// we can't cache this result, since internally it uses AsyncLazy which
// care about cancellation token
// do it async for real.
return
DocumentState
.
GetSyntaxTreeAsync
(
cancellationToken
);
}
...
...
@@ -203,15 +178,6 @@ internal SyntaxTree GetSyntaxTreeSynchronously(CancellationToken cancellationTok
return
null
;
}
// if we already have a stask for getting this syntax tree, and the task
// has completed, then we can just return that value.
var
syntaxTreeTask
=
GetExistingSyntaxTreeTask
();
if
(
syntaxTreeTask
?.
Status
==
TaskStatus
.
RanToCompletion
)
{
return
syntaxTreeTask
.
Result
;
}
// Otherwise defer to our state to get this value.
return
DocumentState
.
GetSyntaxTree
(
cancellationToken
);
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录