diff --git a/src/Compilers/Core/Portable/Desktop/AssemblyPortabilityPolicy.cs b/src/Compilers/Core/Portable/Desktop/AssemblyPortabilityPolicy.cs index cfb7c689db94ef8bed91a5eebbd93d7504564685..47bb4f2fb9987fc9cf23d11272e737f0d529ff5b 100644 --- a/src/Compilers/Core/Portable/Desktop/AssemblyPortabilityPolicy.cs +++ b/src/Compilers/Core/Portable/Desktop/AssemblyPortabilityPolicy.cs @@ -54,12 +54,6 @@ private static bool ReadToChild(XmlReader reader, int depth, string elementName, DtdProcessing = DtdProcessing.Prohibit, }; - [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.FxCop.Rules.Security.Xml.SecurityXmlRules", "CA3053:UseXmlSecureResolver", - MessageId = "System.Xml.XmlReader.Create", - Justification = @"For the call to XmlReader.Create() below, CA3053 recommends setting the -XmlReaderSettings.XmlResolver property to either null or an instance of XmlSecureResolver. -However, the said XmlResolver property no longer exists in .NET portable framework (i.e. core framework) which means there is no way to set it. -So we suppress this error until the reporting for CA3053 has been updated to account for .NET portable framework.")] internal static AssemblyPortabilityPolicy LoadFromXml(Stream input) { // Note: Unlike Fusion XML reader the XmlReader doesn't allow whitespace in front of diff --git a/src/Compilers/Core/Portable/DocumentationComments/DocumentationCommentIncludeCache.cs b/src/Compilers/Core/Portable/DocumentationComments/DocumentationCommentIncludeCache.cs index 809ccdfc66105501ff549b886ec9a0ca46b6b4bf..e5a5d75070531a3fd1114b079abda783fe653e28 100644 --- a/src/Compilers/Core/Portable/DocumentationComments/DocumentationCommentIncludeCache.cs +++ b/src/Compilers/Core/Portable/DocumentationComments/DocumentationCommentIncludeCache.cs @@ -44,12 +44,6 @@ public XDocument GetOrMakeDocument(string resolvedPath) /// /// /// - [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.FxCop.Rules.Security.Xml.SecurityXmlRules", "CA3053:UseXmlSecureResolver", - MessageId = "System.Xml.XmlReader.Create", - Justification = @"For the call to XmlReader.Create() below, CA3053 recommends setting the -XmlReaderSettings.XmlResolver property to either null or an instance of XmlSecureResolver. -However, the said XmlResolver property no longer exists in .NET portable framework (i.e. core framework) which means there is no way to set it. -So we suppress this error until the reporting for CA3053 has been updated to account for .NET portable framework.")] private static KeyValuePair MakeValue(XmlReferenceResolver resolver, string resolvedPath) { CacheMissCount++; diff --git a/src/Compilers/Core/Portable/DocumentationComments/XmlDocumentationCommentTextReader.cs b/src/Compilers/Core/Portable/DocumentationComments/XmlDocumentationCommentTextReader.cs index cb80b3ffb086c28a33694e7d2db564d7587e357a..b31f7399ff0a5e821c892151dbcd6bacd5cab285 100644 --- a/src/Compilers/Core/Portable/DocumentationComments/XmlDocumentationCommentTextReader.cs +++ b/src/Compilers/Core/Portable/DocumentationComments/XmlDocumentationCommentTextReader.cs @@ -32,12 +32,6 @@ public static XmlException ParseAndGetException(string text) private static readonly XmlReaderSettings s_xmlSettings = new XmlReaderSettings { DtdProcessing = DtdProcessing.Prohibit }; // internal for testing - [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.FxCop.Rules.Security.Xml.SecurityXmlRules", "CA3053:UseXmlSecureResolver", - MessageId = "System.Xml.XmlReader.Create", - Justification = @"For the call to XmlReader.Create() below, CA3053 recommends setting the -XmlReaderSettings.XmlResolver property to either null or an instance of XmlSecureResolver. -However, the said XmlResolver property no longer exists in .NET portable framework (i.e. core framework) which means there is no way to set it. -So we suppress this error until the reporting for CA3053 has been updated to account for .NET portable framework.")] internal XmlException ParseInternal(string text) { _textReader.SetText(text); diff --git a/src/Compilers/Core/Portable/RuleSet/RuleSetProcessor.cs b/src/Compilers/Core/Portable/RuleSet/RuleSetProcessor.cs index 4a75d0e530d18609cc7a202fc130aae4c65992fc..d57420712c6eb295298cd9deba8c95a69f392399 100644 --- a/src/Compilers/Core/Portable/RuleSet/RuleSetProcessor.cs +++ b/src/Compilers/Core/Portable/RuleSet/RuleSetProcessor.cs @@ -54,12 +54,6 @@ internal class RuleSetProcessor /// Creates and loads the rule set from a file /// /// The file path to load the rule set - [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.FxCop.Rules.Security.Xml.SecurityXmlRules", "CA3053:UseXmlSecureResolver", - MessageId = "System.Xml.XmlReader.Create", - Justification = @"For the call to XmlReader.Create() below, CA3053 recommends setting the -XmlReaderSettings.XmlResolver property to either null or an instance of XmlSecureResolver. -However, the said XmlResolver property no longer exists in .NET portable framework (i.e. core framework) which means there is no way to set it. -So we suppress this error until the reporting for CA3053 has been updated to account for .NET portable framework.")] public static RuleSet LoadFromFile(string filePath) { // First read the file without doing any validation diff --git a/src/Workspaces/Core/Portable/Shared/Utilities/XmlFragmentParser.cs b/src/Workspaces/Core/Portable/Shared/Utilities/XmlFragmentParser.cs index 9e63dc47bb3f2ebc1770eb635ad08843687a28de..ed55e9da9f75035f8dd485399781ba3335fd20ea 100644 --- a/src/Workspaces/Core/Portable/Shared/Utilities/XmlFragmentParser.cs +++ b/src/Workspaces/Core/Portable/Shared/Utilities/XmlFragmentParser.cs @@ -52,12 +52,6 @@ public static void ParseFragment(string xmlFragment, Action(string text, Action callback, TArg arg) { _textReader.SetText(text); diff --git a/src/Workspaces/Core/Portable/Utilities/Documentation/XmlDocumentationProvider.cs b/src/Workspaces/Core/Portable/Utilities/Documentation/XmlDocumentationProvider.cs index f6f98383afea9d02d901c4d90bd029862a9f4a99..f7af70057f1de1a48ae237c529474b6ec84a628f 100644 --- a/src/Workspaces/Core/Portable/Utilities/Documentation/XmlDocumentationProvider.cs +++ b/src/Workspaces/Core/Portable/Utilities/Documentation/XmlDocumentationProvider.cs @@ -56,12 +56,6 @@ public static XmlDocumentationProvider CreateFromFile(string xmlDocCommentFilePa return new FileBasedXmlDocumentationProvider(xmlDocCommentFilePath); } - [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.FxCop.Rules.Security.Xml.SecurityXmlRules", "CA3053:UseXmlSecureResolver", - MessageId = "System.Xml.XmlReader.Create", - Justification = @"For the call to XmlReader.Create() below, CA3053 recommends setting the -XmlReaderSettings.XmlResolver property to either null or an instance of XmlSecureResolver. -However, the said XmlResolver property no longer exists in .NET portable framework (i.e. core framework) which means there is no way to set it. -So we suppress this error until the reporting for CA3053 has been updated to account for .NET portable framework.")] private XDocument GetXDocument(CancellationToken cancellationToken) { using var stream = GetSourceStream(cancellationToken);