From b78fd280841910c60d7b55008520005630284bdc Mon Sep 17 00:00:00 2001
From: Tomas Matousek <tomat@microsoft.com>
Date: Tue, 11 Sep 2018 10:26:53 -0700
Subject: [PATCH] PR feedback

---
 build/Targets/Imports.targets | 2 +-
 build/Targets/Packages.props  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/build/Targets/Imports.targets b/build/Targets/Imports.targets
index 39e5754bdda..a3864d3826f 100644
--- a/build/Targets/Imports.targets
+++ b/build/Targets/Imports.targets
@@ -15,7 +15,7 @@
 
     <!-- Only generate our runtimeconfig.json files for net core apps. It's unnecessary in desktop projects
          but gets included in lots of output items like VSIX. -->
-    <GenerateRuntimeConfigurationFiles Condition="'$(TargetFramework)' != 'netcoreapp1.1' AND '$(TargetFramework)' != 'netcoreapp2.0' AND '$(TargetFramework)' != 'netcoreapp2.1'">false</GenerateRuntimeConfigurationFiles>
+    <GenerateRuntimeConfigurationFiles Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">false</GenerateRuntimeConfigurationFiles>
 
     <!-- Place VS insertion (CoreXT) packages to a separate directory -->
     <PackageOutputPath Condition="'$(IsVisualStudioInsertionPackage)' == 'true'">$(ArtifactsConfigurationDir)DevDivPackages\Roslyn\</PackageOutputPath>
diff --git a/build/Targets/Packages.props b/build/Targets/Packages.props
index 7a4a635a5bc..9de770ceee6 100644
--- a/build/Targets/Packages.props
+++ b/build/Targets/Packages.props
@@ -183,7 +183,7 @@
 
     <SystemTextEncodingCodePagesVersion>4.3.0</SystemTextEncodingCodePagesVersion>
     <SystemThreadingTasksDataflowVersion>4.5.24</SystemThreadingTasksDataflowVersion>
-    <!-- We need SVT assembly version at least 4.0.3.0 on net47 to make F5 work against Dev15 - see https://github.com/dotnet/roslyn/issues/29705 -->
+    <!-- We need System.ValueTuple assembly version at least 4.0.3.0 on net47 to make F5 work against Dev15 - see https://github.com/dotnet/roslyn/issues/29705 -->
     <SystemValueTupleVersion>4.5.0</SystemValueTupleVersion>
     <SystemThreadingTasksExtensionsVersion>4.3.0</SystemThreadingTasksExtensionsVersion>
     <SQLitePCLRawbundle_greenVersion>1.1.2</SQLitePCLRawbundle_greenVersion>
-- 
GitLab