From b5d5238ac790d2cb0f4be7bd79391aa5b9e66b04 Mon Sep 17 00:00:00 2001 From: Sam Harwell Date: Mon, 17 Aug 2020 08:18:28 -0700 Subject: [PATCH] Update comments for some remaining exclusions --- .../RemoveUnusedParametersTests.cs | 3 +-- ...actRemoveUnnecessaryPragmaSuppressionsDiagnosticAnalyzer.cs | 2 +- .../CSharp/Extensions/ContextQuery/SyntaxTreeExtensions.cs | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/Analyzers/CSharp/Tests/RemoveUnusedParametersAndValues/RemoveUnusedParametersTests.cs b/src/Analyzers/CSharp/Tests/RemoveUnusedParametersAndValues/RemoveUnusedParametersTests.cs index 2063b07662b..d96a2336458 100644 --- a/src/Analyzers/CSharp/Tests/RemoveUnusedParametersAndValues/RemoveUnusedParametersTests.cs +++ b/src/Analyzers/CSharp/Tests/RemoveUnusedParametersAndValues/RemoveUnusedParametersTests.cs @@ -1367,8 +1367,7 @@ public C(Task [|task|]) }", options); } -#if !CODE_STYLE // Below test is not applicable for CodeStyle layer as attempting to fetch - // an editorconfig string representation for this invalid option fails. +#if !CODE_STYLE // Below test is not applicable for CodeStyle layer as attempting to fetch an editorconfig string representation for this invalid option fails. [WorkItem(37326, "https://github.com/dotnet/roslyn/issues/37326")] [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsRemoveUnusedParameters)] public async Task RegressionTest_ShouldReportUnusedParameter_02() diff --git a/src/Analyzers/Core/Analyzers/RemoveUnnecessarySuppressions/AbstractRemoveUnnecessaryPragmaSuppressionsDiagnosticAnalyzer.cs b/src/Analyzers/Core/Analyzers/RemoveUnnecessarySuppressions/AbstractRemoveUnnecessaryPragmaSuppressionsDiagnosticAnalyzer.cs index 7b2c640f1a3..0be51fe7143 100644 --- a/src/Analyzers/Core/Analyzers/RemoveUnnecessarySuppressions/AbstractRemoveUnnecessaryPragmaSuppressionsDiagnosticAnalyzer.cs +++ b/src/Analyzers/Core/Analyzers/RemoveUnnecessarySuppressions/AbstractRemoveUnnecessaryPragmaSuppressionsDiagnosticAnalyzer.cs @@ -101,7 +101,7 @@ protected sealed override void InitializeWorker(AnalysisContext context) // However, this is a special analyzer that is directly invoked by the analysis host (IDE), so we do this check here. ReportDiagnostic severity; if ( -#if !CODE_STYLE +#if !CODE_STYLE // Uses Roslyn 3.8 API compilationWithAnalyzers.Compilation.Options.SyntaxTreeOptionsProvider != null && compilationWithAnalyzers.Compilation.Options.SyntaxTreeOptionsProvider.TryGetDiagnosticValue(tree, IDEDiagnosticIds.RemoveUnnecessarySuppressionDiagnosticId, out severity) || #endif diff --git a/src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/Extensions/ContextQuery/SyntaxTreeExtensions.cs b/src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/Extensions/ContextQuery/SyntaxTreeExtensions.cs index cbbe23ce9f4..4818d5c3ef2 100644 --- a/src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/Extensions/ContextQuery/SyntaxTreeExtensions.cs +++ b/src/Workspaces/SharedUtilitiesAndExtensions/Workspace/CSharp/Extensions/ContextQuery/SyntaxTreeExtensions.cs @@ -1121,7 +1121,7 @@ public static bool IsDefaultExpressionContext(this SyntaxTree syntaxTree, int po return true; } -#if !CODE_STYLE +#if !CODE_STYLE // FunctionPointerParameterListSyntax added in 3.8 if (token.IsKind(SyntaxKind.CommaToken) && token.Parent.IsKind(SyntaxKindEx.FunctionPointerParameterList, out FunctionPointerParameterListSyntax funcPtrParamList)) { -- GitLab