Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
b1fde3b8
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
b1fde3b8
编写于
3月 09, 2020
作者:
C
Cyrus Najmabadi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Update docs
上级
46c1489c
变更
1
显示空白变更内容
内联
并排
Showing
1 changed file
with
8 addition
and
5 deletion
+8
-5
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Utilities/TypeStyle/CSharpUseImplicitTypeHelper.cs
...CSharp/Utilities/TypeStyle/CSharpUseImplicitTypeHelper.cs
+8
-5
未找到文件。
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Utilities/TypeStyle/CSharpUseImplicitTypeHelper.cs
浏览文件 @
b1fde3b8
...
...
@@ -217,16 +217,14 @@ protected override bool IsStylePreferred(in State state)
private
bool
IsMatchingArgumentToSimpleMethod
(
DeclarationExpressionSyntax
declarationExpression
,
SemanticModel
semanticModel
,
CancellationToken
cancellationToken
)
{
// If there was only one member in the group, and it was non-generic itself, then this
// change is commonly safe to make without having to actually change to `var` and
// speculatively determine if the change is ok or not.
if
(!(
declarationExpression
.
Parent
is
ArgumentSyntax
argument
)
||
!(
argument
.
Parent
is
ArgumentListSyntax
argumentList
)
||
!(
argumentList
.
Parent
is
InvocationExpressionSyntax
invocationExpression
))
return
false
;
// If there was only one member in the group, and it was non-generic itself,
// then this change is safe to make without doing any complex analysis.
// Multiple methods mean that switching to 'var' might remove information
// that affects overload resolution. And if the method is generic, then
// switching to 'var' may mean that inference might not work properly.
var
memberGroup
=
semanticModel
.
GetMemberGroup
(
invocationExpression
.
Expression
,
cancellationToken
);
if
(
memberGroup
.
Length
!=
1
)
return
false
;
...
...
@@ -238,6 +236,11 @@ private bool IsMatchingArgumentToSimpleMethod(DeclarationExpressionSyntax declar
if
(!
method
.
GetTypeParameters
().
IsEmpty
)
return
false
;
// Looks pretty good so far. However, this change is not allowed if the user is
// specifying something like `out (int x, int y) t` and the method signature has
// different names for those tuple elements. Check and make sure the types are the
// same before proceeding.
var
invocationOp
=
semanticModel
.
GetOperation
(
invocationExpression
)
as
IInvocationOperation
;
if
(
invocationOp
==
null
)
return
false
;
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录