From a27f86e3bf5f909be6cd32f30f6db294cd6e12b3 Mon Sep 17 00:00:00 2001 From: Jason Malinowski Date: Fri, 24 Jan 2020 13:56:58 -0800 Subject: [PATCH] Remove duplicate project existence check CheckContainsProject asserts the project exists, no need to duplicate it. --- .../Core/Portable/Workspace/Solution/SolutionState.cs | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs b/src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs index 00bbabd0a44..5f541133a3d 100644 --- a/src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs +++ b/src/Workspaces/Core/Portable/Workspace/Solution/SolutionState.cs @@ -1217,12 +1217,7 @@ public SolutionState AddDocuments(ImmutableArray documentInfos) foreach (var documentInfosInProject in documentInfosByProjectId) { CheckContainsProject(documentInfosInProject.Key); - var oldProject = this.GetProjectState(documentInfosInProject.Key); - - if (oldProject == null) - { - throw new InvalidOperationException(string.Format(WorkspacesResources._0_is_not_part_of_the_workspace, documentInfosInProject.Key)); - } + var oldProject = this.GetProjectState(documentInfosInProject.Key)!; var newDocumentStatesForProjectBuilder = ArrayBuilder.GetInstance(); -- GitLab