Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
a1fe543e
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
a1fe543e
编写于
1月 21, 2020
作者:
S
Sam Harwell
提交者:
GitHub
1月 21, 2020
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #41072 from sharwell/filter-identifier-name
Avoid trying to simplify descendant identifier names
上级
75662fd8
423dd1b2
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
18 addition
and
2 deletion
+18
-2
src/Features/CSharp/Portable/Diagnostics/Analyzers/TypeSyntaxSimplifierWalker.cs
...table/Diagnostics/Analyzers/TypeSyntaxSimplifierWalker.cs
+10
-1
src/Features/VisualBasic/Portable/Diagnostics/Analyzers/TypeSyntaxSimplifierWalker.vb
...table/Diagnostics/Analyzers/TypeSyntaxSimplifierWalker.vb
+8
-1
未找到文件。
src/Features/CSharp/Portable/Diagnostics/Analyzers/TypeSyntaxSimplifierWalker.cs
浏览文件 @
a1fe543e
...
...
@@ -2,8 +2,10 @@
#
nullable
enable
using
System
;
using
System.Collections.Generic
;
using
System.Threading
;
using
Microsoft.CodeAnalysis.CSharp.Extensions
;
using
Microsoft.CodeAnalysis.CSharp.Syntax
;
using
Microsoft.CodeAnalysis.Options
;
...
...
@@ -65,7 +67,14 @@ public override void VisitGenericName(GenericNameSyntax node)
public
override
void
VisitIdentifierName
(
IdentifierNameSyntax
node
)
{
if
(
node
.
IsKind
(
SyntaxKind
.
IdentifierName
)
&&
TrySimplify
(
node
))
// Always try to simplify identifiers with an 'Attribute' suffix.
//
// In other cases, don't bother looking at the right side of A.B or A::B. We will process those in
// one of our other top level Visit methods (like VisitQualifiedName).
var
canTrySimplify
=
node
.
Identifier
.
ValueText
!.
EndsWith
(
"Attribute"
,
StringComparison
.
Ordinal
)
||
!
node
.
IsRightSideOfDotOrArrowOrColonColon
();
if
(
canTrySimplify
&&
TrySimplify
(
node
))
{
// found a match. report it and stop processing.
return
;
...
...
src/Features/VisualBasic/Portable/Diagnostics/Analyzers/TypeSyntaxSimplifierWalker.vb
浏览文件 @
a1fe543e
...
...
@@ -41,7 +41,14 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.CodeFixes.SimplifyTypeNames
End
Sub
Public
Overrides
Sub
VisitIdentifierName
(
node
As
IdentifierNameSyntax
)
If
node
.
IsKind
(
SyntaxKind
.
IdentifierName
)
AndAlso
TrySimplify
(
node
)
Then
' Always try to simplify identifiers with an 'Attribute' suffix.
'
' In other cases, don't bother looking at the right side of A.B or A!B. We will process those in
' one of our other top level Visit methods (Like VisitQualifiedName).
Dim
canTrySimplify
=
CaseInsensitiveComparison
.
EndsWith
(
node
.
Identifier
.
ValueText
,
"Attribute"
)
_
OrElse
Not
node
.
IsRightSideOfDotOrBang
()
If
canTrySimplify
AndAlso
TrySimplify
(
node
)
Then
Return
End
If
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录