The synthesized variable used for storing the value of Select Case should be...

The synthesized variable used for storing the value of Select Case should be long-lived. (changeset 1348097)

Src/Compilers/Core/Portable/SynthesizedLocalKind.cs

@@ -107,11 +107,10 @@ internal enum SynthesizedLocalKind
         // VB TODO:
         ForDirection = 14,
 
-        // VB TODO:
-        // degenerate select key (can we EnC when stopped on case?)
-
-        // VB TODO: XmlInExpressionLambda locals are always lifted and must have distinct names.
-        XmlInExpressionLambda = 15,
+        /// <summary>
+        /// Local variable used to store the value of Select Case during the execution of Case statements.
+        /// </summary>
+        SelectCaseValue = 15,
 
         // VB TODO
         OnErrorActiveHandler = 16,
@@ -169,6 +168,9 @@ internal enum SynthesizedLocalKind
         /// </summary>
         CachedAnonymousMethodDelegate = 31,
 
+        // VB TODO: XmlInExpressionLambda locals are always lifted and must have distinct names.
+        XmlInExpressionLambda = 32,
+
         /// <summary>
         /// All values have to be less than or equal to <see cref="MaxValidValue"/> (<see cref="EditAndContinueMethodDebugInformation"/>)
         /// </summary>

Src/Compilers/VisualBasic/Portable/Lowering/LocalRewriter/LocalRewriter_SelectCase.vb

@@ -193,6 +193,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
                 statementBuilder.Add(New BoundSequencePoint(selectExprStmtSyntax, Nothing))
             End If
 
+
             If generateUnstructuredExceptionHandlingResumeCode Then
                 RegisterUnstructuredExceptionHandlingResumeTarget(selectExprStmtSyntax, canThrow:=True, statements:=statementBuilder)
                 ' If the Select throws, a Resume Next should branch to the End Select.
@@ -217,7 +218,8 @@ Namespace Microsoft.CodeAnalysis.VisualBasic
                 Dim selectExprType = rewrittenSelectExpression.Type
 
                 ' Store the select expression result in a temp
-                Dim tempLocal = New SynthesizedLocal(Me.currentMethodOrLambda, selectExprType, SynthesizedLocalKind.LoweringTemp)
+                Dim selectStatementSyntax = DirectCast(selectExprStmtSyntax.Parent, SelectBlockSyntax).SelectStatement
+                Dim tempLocal = New SynthesizedLocal(Me.currentMethodOrLambda, selectExprType, SynthesizedLocalKind.SelectCaseValue, selectStatementSyntax)
                 tempLocals = ImmutableArray.Create(Of LocalSymbol)(tempLocal)
 
                 Dim boundTemp = New BoundLocal(rewrittenSelectExpression.Syntax, tempLocal, selectExprType)

Src/Compilers/VisualBasic/Test/Emit/PDB/PDBTests.vb

@@ -1940,9 +1940,9 @@ End Module
     <methods>
         <method containingType="Module1" name="Main" parameterNames="">
             <customDebugInfo version="4" count="1">
-                <encLocalSlotMap version="4" kind="EditAndContinueLocalSlotMap" size="12">
+                <encLocalSlotMap version="4" kind="EditAndContinueLocalSlotMap" size="16">
                     <slot kind="0" offset="4"/>
-                    <slot kind="temp"/>
+                    <slot kind="15" offset="32"/>
                     <slot kind="temp"/>
                 </encLocalSlotMap>
             </customDebugInfo>
@@ -2069,7 +2069,7 @@ End Module
             <customDebugInfo version="4" count="1">
                 <encLocalSlotMap version="4" kind="EditAndContinueLocalSlotMap" size="12">
                     <slot kind="0" offset="4"/>
-                    <slot kind="temp"/>
+                    <slot kind="15" offset="32"/>
                 </encLocalSlotMap>
             </customDebugInfo>
             <sequencepoints total="13">
@@ -2133,9 +2133,9 @@ End Module
     <methods>
         <method containingType="Module1" name="Main" parameterNames="">
             <customDebugInfo version="4" count="1">
-                <encLocalSlotMap version="4" kind="EditAndContinueLocalSlotMap" size="12">
+                <encLocalSlotMap version="4" kind="EditAndContinueLocalSlotMap" size="16">
                     <slot kind="0" offset="4"/>
-                    <slot kind="temp"/>
+                    <slot kind="15" offset="32"/>
                     <slot kind="temp"/>
                 </encLocalSlotMap>
             </customDebugInfo>
@@ -2199,9 +2199,9 @@ End Module
     <methods>
         <method containingType="Module1" name="Main" parameterNames="">
             <customDebugInfo version="4" count="1">
-                <encLocalSlotMap version="4" kind="EditAndContinueLocalSlotMap" size="12">
+                <encLocalSlotMap version="4" kind="EditAndContinueLocalSlotMap" size="16">
                     <slot kind="0" offset="4"/>
-                    <slot kind="temp"/>
+                    <slot kind="15" offset="32"/>
                     <slot kind="temp"/>
                 </encLocalSlotMap>
             </customDebugInfo>
@@ -2392,7 +2392,7 @@ End Module
             <customDebugInfo version="4" count="1">
                 <encLocalSlotMap version="4" kind="EditAndContinueLocalSlotMap" size="16">
                     <slot kind="0" offset="4"/>
-                    <slot kind="temp"/>
+                    <slot kind="15" offset="34"/>
                     <slot kind="temp"/>
                     <slot kind="temp"/>
                 </encLocalSlotMap>
@@ -7522,6 +7522,61 @@ End Class
             </scope>
         </method>
     </methods>
+</symbols>)
+        End Sub
+
+        <Fact>
+        Sub SynthesizedVariableForSelectCastValue()
+            Dim source =
+<compilation>
+    <file>
+Imports System
+Class C
+    Sub F(args As String())
+        Select Case args(0)
+            Case "a"
+                Console.WriteLine(1)
+            Case "b"
+                Console.WriteLine(2)
+            Case "c"
+                Console.WriteLine(3)
+        End Select
+    End Sub
+End Class
+    </file>
+</compilation>
+
+            Dim c = CreateCompilationWithMscorlibAndVBRuntime(source, options:=TestOptions.DebugDll)
+            c.VerifyDiagnostics()
+            c.VerifyPdb("C.F",
+<symbols>
+    <methods>
+        <method containingType="C" name="F" parameterNames="args">
+            <customDebugInfo version="4" count="1">
+                <encLocalSlotMap version="4" kind="EditAndContinueLocalSlotMap" size="12">
+                    <slot kind="15" offset="0"/>
+                </encLocalSlotMap>
+            </customDebugInfo>
+            <sequencepoints total="10">
+                <entry il_offset="0x0" start_row="3" start_column="5" end_row="3" end_column="28" file_ref="0"/>
+                <entry il_offset="0x1" start_row="4" start_column="9" end_row="4" end_column="28" file_ref="0"/>
+                <entry il_offset="0x32" start_row="5" start_column="13" end_row="5" end_column="21" file_ref="0"/>
+                <entry il_offset="0x33" start_row="6" start_column="17" end_row="6" end_column="37" file_ref="0"/>
+                <entry il_offset="0x3c" start_row="7" start_column="13" end_row="7" end_column="21" file_ref="0"/>
+                <entry il_offset="0x3d" start_row="8" start_column="17" end_row="8" end_column="37" file_ref="0"/>
+                <entry il_offset="0x46" start_row="9" start_column="13" end_row="9" end_column="21" file_ref="0"/>
+                <entry il_offset="0x47" start_row="10" start_column="17" end_row="10" end_column="37" file_ref="0"/>
+                <entry il_offset="0x50" start_row="11" start_column="9" end_row="11" end_column="19" file_ref="0"/>
+                <entry il_offset="0x51" start_row="12" start_column="5" end_row="12" end_column="12" file_ref="0"/>
+            </sequencepoints>
+            <locals/>
+            <scope startOffset="0x0" endOffset="0x52">
+                <namespace name="System" importlevel="file"/>
+                <currentnamespace name=""/>
+            </scope>
+        </method>
+    </methods>
+
 </symbols>)
         End Sub
 

Src/Compilers/VisualBasic/Test/Semantic/BasicCompilerSemanticTest.vbproj

@@ -203,7 +203,7 @@
     <Compile Include="Semantics\QueryExpressions_LookupSymbols.vb" />
     <Compile Include="Semantics\QueryExpressions_SemanticModel.vb" />
     <Compile Include="Semantics\RedimStatementTests.vb" />
-    <Compile Include="Semantics\SelectCaseTest.vb" />
+    <Compile Include="Semantics\SelectCaseTests.vb" />
     <Compile Include="Semantics\SyncLockTests.vb" />
     <Compile Include="Semantics\SyntaxTreeRootTests.vb" />
     <Compile Include="Semantics\TooLongNameTests.vb" />

Src/Compilers/VisualBasic/Test/Semantic/Semantics/SelectCaseTest.vb → Src/Compilers/VisualBasic/Test/Semantic/Semantics/SelectCaseTests.vb

 ' Copyright (c) Microsoft Open Technologies, Inc.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
 
-Imports Microsoft.CodeAnalysis.Text
-Imports Microsoft.CodeAnalysis.VisualBasic.Symbols
 Imports Microsoft.CodeAnalysis.VisualBasic.Syntax
 Imports Roslyn.Test.Utilities
 
 Namespace Microsoft.CodeAnalysis.VisualBasic.UnitTests.Semantics
-    Public Class SelectCaseTest
+    Public Class SelectCaseTests
         Inherits BasicTestBase
         <Fact()>
         Public Sub SelectCaseExpression_NothingLiteral()