From a185a50d747d91c6f8692a5c7ff87e568aa2d368 Mon Sep 17 00:00:00 2001
From: Cyrus Najmabadi <cyrus.najmabadi@gmail.com>
Date: Thu, 18 Jul 2019 16:44:24 -0700
Subject: [PATCH] Remove unnecessary constructor

---
 src/Workspaces/Core/Portable/SymbolKey/SymbolKey.cs   | 11 ++---------
 .../Core/Portable/SymbolKey/SymbolKeyExtensions.cs    |  2 +-
 2 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/src/Workspaces/Core/Portable/SymbolKey/SymbolKey.cs b/src/Workspaces/Core/Portable/SymbolKey/SymbolKey.cs
index c0406a0c24c..322295f8086 100644
--- a/src/Workspaces/Core/Portable/SymbolKey/SymbolKey.cs
+++ b/src/Workspaces/Core/Portable/SymbolKey/SymbolKey.cs
@@ -100,20 +100,13 @@ internal partial struct SymbolKey
         /// from any other source is not supported.
         /// </summary>
         public SymbolKey(string data)
-        {
-            _symbolKeyData = data ?? throw new ArgumentNullException();
-        }
+            => _symbolKeyData = data ?? throw new ArgumentNullException();
 
         /// <summary>
         /// Constructs a new <see cref="SymbolKey"/> representing the provided <paramref name="symbol"/>.
         /// </summary>
-        public SymbolKey(ISymbol symbol, CancellationToken cancellationToken = default)
-            : this(CreateString(symbol, cancellationToken))
-        {
-        }
-
         internal static SymbolKey Create(ISymbol symbol, CancellationToken cancellationToken = default)
-            => new SymbolKey(symbol, cancellationToken);
+            => new SymbolKey(CreateString(symbol, cancellationToken));
 
         /// <summary>
         /// Returns an <see cref="IEqualityComparer{T}"/> that determines if two <see cref="SymbolKey"/>s
diff --git a/src/Workspaces/Core/Portable/SymbolKey/SymbolKeyExtensions.cs b/src/Workspaces/Core/Portable/SymbolKey/SymbolKeyExtensions.cs
index f05f02607b2..8068162b41e 100644
--- a/src/Workspaces/Core/Portable/SymbolKey/SymbolKeyExtensions.cs
+++ b/src/Workspaces/Core/Portable/SymbolKey/SymbolKeyExtensions.cs
@@ -7,6 +7,6 @@ namespace Microsoft.CodeAnalysis
     internal static class SymbolKeyExtensions
     {
         public static SymbolKey GetSymbolKey(this ISymbol symbol, CancellationToken cancellationToken = default)
-            => new SymbolKey(symbol, cancellationToken);
+            => SymbolKey.Create(symbol, cancellationToken);
     }
 }
-- 
GitLab