From 9f400cebf8500468e35fc43c01f0c84b7bc827a4 Mon Sep 17 00:00:00 2001 From: Ty Overby Date: Mon, 9 Nov 2015 14:44:53 -0800 Subject: [PATCH] added WorkItems for explaining why the tests are conditional --- src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs | 1 + .../Emit/Attributes/InternalsVisibleToAndStrongNameTests.cs | 2 ++ .../Test/Emit/CodeGen/CodeGenShortCircuitOperatorTests.cs | 1 + .../Core/CodeAnalysisTest/Text/EncodedStringTextTests.cs | 5 ++++- .../VisualBasic/Test/CommandLine/CommandLineTests.vb | 1 + .../CSharp/Test/ResultProvider/DynamicViewTests.cs | 1 + .../CSharp/Test/ResultProvider/ResultsViewTests.cs | 4 +++- .../VisualBasic/Test/ResultProvider/DynamicViewTests.vb | 1 + .../CoreTest/WorkspaceTests/MSBuildWorkspaceTests.cs | 1 + 9 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs b/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs index 15f7a34b37d..d57bf0f5596 100644 --- a/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs +++ b/src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs @@ -4129,6 +4129,7 @@ public void BinaryFileErrorTest() [WorkItem(530221, "DevDiv")] + [WorkItem(5660, "https://github.com/dotnet/roslyn/issues/5660")] [ConditionalFact(typeof(WindowsOnly), typeof(IsEnglishLocal))] public void Bug15538() { diff --git a/src/Compilers/CSharp/Test/Emit/Attributes/InternalsVisibleToAndStrongNameTests.cs b/src/Compilers/CSharp/Test/Emit/Attributes/InternalsVisibleToAndStrongNameTests.cs index 6260b7e5afc..9b4855825cc 100644 --- a/src/Compilers/CSharp/Test/Emit/Attributes/InternalsVisibleToAndStrongNameTests.cs +++ b/src/Compilers/CSharp/Test/Emit/Attributes/InternalsVisibleToAndStrongNameTests.cs @@ -316,6 +316,7 @@ public void PubKeyFileBogusOptions() Assert.True(other.Assembly.Identity.PublicKey.IsEmpty); } + [WorkItem(5662, "https://github.com/dotnet/roslyn/issues/5662")] [ConditionalFact(typeof(IsEnglishLocal))] public void PubKeyContainerBogusOptions() { @@ -909,6 +910,7 @@ public void SignModuleKeyContainerAttr() ConfirmModuleAttributePresentAndAddingToAssemblyResultsInSignedOutput(outStrm, AttributeDescription.AssemblyKeyNameAttribute); } + [WorkItem(5665, "https://github.com/dotnet/roslyn/issues/5665")] [ConditionalFact(typeof(IsEnglishLocal))] public void SignModuleKeyContainerBogus() { diff --git a/src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenShortCircuitOperatorTests.cs b/src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenShortCircuitOperatorTests.cs index b43c385073e..0accce94f45 100644 --- a/src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenShortCircuitOperatorTests.cs +++ b/src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenShortCircuitOperatorTests.cs @@ -5865,6 +5865,7 @@ .maxstack 2 } [WorkItem(825, "https://github.com/dotnet/roslyn/issues/825")] + [WorkItem(5662, "https://github.com/dotnet/roslyn/issues/5662")] [ConditionalFact(typeof(IsEnglishLocal))] public void ConditionalBoolExpr01b() { diff --git a/src/Compilers/Core/CodeAnalysisTest/Text/EncodedStringTextTests.cs b/src/Compilers/Core/CodeAnalysisTest/Text/EncodedStringTextTests.cs index 015c0576fe5..3a34f6a9096 100644 --- a/src/Compilers/Core/CodeAnalysisTest/Text/EncodedStringTextTests.cs +++ b/src/Compilers/Core/CodeAnalysisTest/Text/EncodedStringTextTests.cs @@ -134,6 +134,7 @@ public void CheckSum_SHA256() } [ConditionalFact(typeof(IsEnglishLocal))] + [WorkItem(5663, "https://github.com/dotnet/roslyn/issues/5663")] public void Decode_NonUtf8() { // Unicode text with extended characters that map to interesting code points in CodePage 1252. @@ -322,7 +323,9 @@ public void FileStreamEncodedTextEmpty() } } - [ConditionalFact(typeof(IsEnglishLocal)), WorkItem(2081, "https://github.com/dotnet/roslyn/issues/2081")] + [ConditionalFact(typeof(IsEnglishLocal))] + [WorkItem(2081, "https://github.com/dotnet/roslyn/issues/2081")] + [WorkItem(5663, "https://github.com/dotnet/roslyn/issues/5663")] public void HorizontalEllipsis() { // Character 0x85 in CodePage 1252 is a horizontal ellipsis. diff --git a/src/Compilers/VisualBasic/Test/CommandLine/CommandLineTests.vb b/src/Compilers/VisualBasic/Test/CommandLine/CommandLineTests.vb index 2ff29d00320..591a8a4c648 100644 --- a/src/Compilers/VisualBasic/Test/CommandLine/CommandLineTests.vb +++ b/src/Compilers/VisualBasic/Test/CommandLine/CommandLineTests.vb @@ -5298,6 +5298,7 @@ End Module End Sub + Public Sub Bug15538() Dim folder = Temp.CreateDirectory() diff --git a/src/ExpressionEvaluator/CSharp/Test/ResultProvider/DynamicViewTests.cs b/src/ExpressionEvaluator/CSharp/Test/ResultProvider/DynamicViewTests.cs index a442d6f279e..d6fbaec5b7f 100644 --- a/src/ExpressionEvaluator/CSharp/Test/ResultProvider/DynamicViewTests.cs +++ b/src/ExpressionEvaluator/CSharp/Test/ResultProvider/DynamicViewTests.cs @@ -121,6 +121,7 @@ public void DynamicTypeMember() } [ConditionalFact(typeof(IsEnglishLocal))] + [WorkItem(5666, "https://github.com/dotnet/roslyn/issues/5666")] public void NoMembers() { var expression = "o"; diff --git a/src/ExpressionEvaluator/CSharp/Test/ResultProvider/ResultsViewTests.cs b/src/ExpressionEvaluator/CSharp/Test/ResultProvider/ResultsViewTests.cs index 4637e94954f..b765db43b9c 100644 --- a/src/ExpressionEvaluator/CSharp/Test/ResultProvider/ResultsViewTests.cs +++ b/src/ExpressionEvaluator/CSharp/Test/ResultProvider/ResultsViewTests.cs @@ -1408,7 +1408,9 @@ public IEnumerator GetEnumerator() } } - [Fact, WorkItem(1145125, "DevDiv")] + [ConditionalFact(typeof(IsEnglishLocal))] + [WorkItem(1145125, "DevDiv")] + [WorkItem(5666, "https://github.com/dotnet/roslyn/issues/5666")] public void GetEnumerableException() { var source = diff --git a/src/ExpressionEvaluator/VisualBasic/Test/ResultProvider/DynamicViewTests.vb b/src/ExpressionEvaluator/VisualBasic/Test/ResultProvider/DynamicViewTests.vb index f11736e454a..fbcc5abe417 100644 --- a/src/ExpressionEvaluator/VisualBasic/Test/ResultProvider/DynamicViewTests.vb +++ b/src/ExpressionEvaluator/VisualBasic/Test/ResultProvider/DynamicViewTests.vb @@ -115,6 +115,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.ExpressionEvaluator End Sub + Public Sub NoMembers() Dim expression = "o" Dim o As Object = New ExpandoObject() diff --git a/src/Workspaces/CoreTest/WorkspaceTests/MSBuildWorkspaceTests.cs b/src/Workspaces/CoreTest/WorkspaceTests/MSBuildWorkspaceTests.cs index 89ed11e30cb..9da5e53c627 100644 --- a/src/Workspaces/CoreTest/WorkspaceTests/MSBuildWorkspaceTests.cs +++ b/src/Workspaces/CoreTest/WorkspaceTests/MSBuildWorkspaceTests.cs @@ -2373,6 +2373,7 @@ public void TestProjectReferenceWithNoGuid() } [ConditionalFact(typeof(IsEnglishLocal)), Trait(Traits.Feature, Traits.Features.Workspace)] + [WorkItem(5668, "https://github.com/dotnet/roslyn/issues/5668")] public void TestOpenProject_MetadataReferenceHasDocComments() { CreateFiles(GetSimpleCSharpSolutionFiles()); -- GitLab