diff --git a/src/Features/LanguageServer/Protocol/Handler/CodeActions/CodeActionsHandler.cs b/src/Features/LanguageServer/Protocol/Handler/CodeActions/CodeActionsHandler.cs index e63f415083842f78b44205a0c0870f753bd7d7d3..04cfcd8740f56cecbe686083b3b55144cec61f49 100644 --- a/src/Features/LanguageServer/Protocol/Handler/CodeActions/CodeActionsHandler.cs +++ b/src/Features/LanguageServer/Protocol/Handler/CodeActions/CodeActionsHandler.cs @@ -10,8 +10,8 @@ using Microsoft.CodeAnalysis.CodeRefactorings; using Microsoft.CodeAnalysis.PooledObjects; using Microsoft.CodeAnalysis.LanguageServer.CustomProtocol; -using LSP = Microsoft.VisualStudio.LanguageServer.Protocol; using Newtonsoft.Json.Linq; +using LSP = Microsoft.VisualStudio.LanguageServer.Protocol; namespace Microsoft.CodeAnalysis.LanguageServer.Handler { @@ -49,10 +49,7 @@ public CodeActionsHandler(ICodeFixService codeFixService, ICodeRefactoringServic var clientSupportsWorkspaceEdits = true; if (clientCapabilities?.Experimental is JObject clientCapabilitiesExtensions) { - if (clientCapabilitiesExtensions.TryGetValue("supportsWorkspaceEdits", out var val)) - { - clientSupportsWorkspaceEdits = val.ToObject(); - } + clientSupportsWorkspaceEdits = clientCapabilitiesExtensions.SelectToken("supportsWorkspaceEdits")?.Value() ?? clientSupportsWorkspaceEdits; } if (clientSupportsWorkspaceEdits && operations.Length == 1 && operations.First() is ApplyChangesOperation applyChangesOperation) diff --git a/src/Features/LanguageServer/ProtocolUnitTests/CodeActions/CodeActionsTests.cs b/src/Features/LanguageServer/ProtocolUnitTests/CodeActions/CodeActionsTests.cs index a93959311bcd889847713ff38ba05e6a3aad5b72..bdd120221748ae3b59c6ca3e60014c5f5c43891b 100644 --- a/src/Features/LanguageServer/ProtocolUnitTests/CodeActions/CodeActionsTests.cs +++ b/src/Features/LanguageServer/ProtocolUnitTests/CodeActions/CodeActionsTests.cs @@ -27,13 +27,7 @@ void M() }"; var (solution, locations) = CreateTestSolution(markup); var expected = CreateCommand(CSharpFeaturesResources.Use_implicit_type, locations["caret"].First()); - var clientCapabilities = new LSP.ClientCapabilities() - { - Experimental = new JObject - { - { "supportsWorkspaceEdits", false } - } - }; + var clientCapabilities = CreateClientCapabilitiesWithExperimentalValue("supportsWorkspaceEdits", JToken.FromObject(false)); var results = await RunCodeActionsAsync(solution, locations["caret"].First(), clientCapabilities); AssertCodeActionCommandsEqual(expected, results.Single()); @@ -69,6 +63,15 @@ static void AssertRunCodeActionParamsEqual(RunCodeActionParams expected, RunCode } } + private static LSP.ClientCapabilities CreateClientCapabilitiesWithExperimentalValue(string experimentalProperty, JToken value) + => new LSP.ClientCapabilities() + { + Experimental = new JObject + { + { experimentalProperty, value } + } + }; + private static LSP.CodeActionParams CreateCodeActionParams(LSP.Location caret) => new LSP.CodeActionParams() { diff --git a/src/Tools/ExternalAccess/LiveShare/Classification/RoslynClassificationService.Exports.cs b/src/Tools/ExternalAccess/LiveShare/Classification/RoslynClassificationService.Exports.cs index 27d09ca218763a6703a523449ecb20878792f8b3..17c78f930915505d82c5e49ebc551ba97ba52420 100644 --- a/src/Tools/ExternalAccess/LiveShare/Classification/RoslynClassificationService.Exports.cs +++ b/src/Tools/ExternalAccess/LiveShare/Classification/RoslynClassificationService.Exports.cs @@ -30,42 +30,42 @@ public ILanguageService CreateLanguageService(HostLanguageServices languageServi [ExportLanguageServiceFactory(typeof(ISyntaxClassificationService), StringConstants.CSharpLspLanguageName), Shared] internal class CSharpLspEditorClassificationFactoryService : ILanguageServiceFactory { - private readonly RoslynLSPClientServiceFactory _roslynLSPClientServiceFactory; + private readonly RoslynLspClientServiceFactory _roslynLspClientServiceFactory; private readonly ClassificationTypeMap _classificationTypeMap; private readonly IThreadingContext _threadingContext; [ImportingConstructor] - public CSharpLspEditorClassificationFactoryService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory, ClassificationTypeMap classificationTypeMap, IThreadingContext threadingContext) + public CSharpLspEditorClassificationFactoryService(RoslynLspClientServiceFactory roslynLspClientServiceFactory, ClassificationTypeMap classificationTypeMap, IThreadingContext threadingContext) { - _roslynLSPClientServiceFactory = roslynLSPClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLSPClientServiceFactory)); + _roslynLspClientServiceFactory = roslynLspClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLspClientServiceFactory)); _classificationTypeMap = classificationTypeMap ?? throw new ArgumentNullException(nameof(classificationTypeMap)); _threadingContext = threadingContext; } public ILanguageService CreateLanguageService(HostLanguageServices languageServices) { - return new RoslynClassificationService(_roslynLSPClientServiceFactory, languageServices.GetOriginalLanguageService(), _classificationTypeMap, _threadingContext); + return new RoslynClassificationService(_roslynLspClientServiceFactory, languageServices.GetOriginalLanguageService(), _classificationTypeMap, _threadingContext); } } [ExportLanguageServiceFactory(typeof(ISyntaxClassificationService), StringConstants.VBLspLanguageName), Shared] internal class VBLspEditorClassificationFactoryService : ILanguageServiceFactory { - private readonly RoslynLSPClientServiceFactory _roslynLSPClientServiceFactory; + private readonly RoslynLspClientServiceFactory _roslynLspClientServiceFactory; private readonly ClassificationTypeMap _classificationTypeMap; private readonly IThreadingContext _threadingContext; [ImportingConstructor] - public VBLspEditorClassificationFactoryService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory, ClassificationTypeMap classificationTypeMap, IThreadingContext threadingContext) + public VBLspEditorClassificationFactoryService(RoslynLspClientServiceFactory roslynLspClientServiceFactory, ClassificationTypeMap classificationTypeMap, IThreadingContext threadingContext) { - _roslynLSPClientServiceFactory = roslynLSPClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLSPClientServiceFactory)); + _roslynLspClientServiceFactory = roslynLspClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLspClientServiceFactory)); _classificationTypeMap = classificationTypeMap ?? throw new ArgumentNullException(nameof(classificationTypeMap)); _threadingContext = threadingContext; } public ILanguageService CreateLanguageService(HostLanguageServices languageServices) { - return new RoslynClassificationService(_roslynLSPClientServiceFactory, languageServices.GetOriginalLanguageService(), _classificationTypeMap, _threadingContext); + return new RoslynClassificationService(_roslynLspClientServiceFactory, languageServices.GetOriginalLanguageService(), _classificationTypeMap, _threadingContext); } } } diff --git a/src/Tools/ExternalAccess/LiveShare/Classification/RoslynClassificationService.cs b/src/Tools/ExternalAccess/LiveShare/Classification/RoslynClassificationService.cs index 93307beca0a08a0166c601d01efb1fb71e9b4409..5f64aa1819d4e00ff184b4783805d25b45c13024 100644 --- a/src/Tools/ExternalAccess/LiveShare/Classification/RoslynClassificationService.cs +++ b/src/Tools/ExternalAccess/LiveShare/Classification/RoslynClassificationService.cs @@ -17,15 +17,15 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.LiveShare.Classification { internal class RoslynClassificationService : ISyntaxClassificationService { - private readonly RoslynLSPClientServiceFactory _roslynLSPClientServiceFactory; + private readonly RoslynLspClientServiceFactory _roslynLSPClientServiceFactory; private readonly ISyntaxClassificationService _originalService; private readonly ClassificationTypeMap _classificationTypeMap; private readonly IThreadingContext _threadingContext; - public RoslynClassificationService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory, ISyntaxClassificationService originalService, + public RoslynClassificationService(RoslynLspClientServiceFactory roslynLspClientServiceFactory, ISyntaxClassificationService originalService, ClassificationTypeMap classificationTypeMap, IThreadingContext threadingContext) { - _roslynLSPClientServiceFactory = roslynLSPClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLSPClientServiceFactory)); + _roslynLSPClientServiceFactory = roslynLspClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLspClientServiceFactory)); _originalService = originalService ?? throw new ArgumentNullException(nameof(originalService)); _classificationTypeMap = classificationTypeMap ?? throw new ArgumentNullException(nameof(classificationTypeMap)); _threadingContext = threadingContext; diff --git a/src/Tools/ExternalAccess/LiveShare/CodeActions/RoslynCodeActionProvider.Exports.cs b/src/Tools/ExternalAccess/LiveShare/CodeActions/RoslynCodeActionProvider.Exports.cs index c003e63ebc129dbd260d2c27f27652e702df59f9..db98e973b8b7b79876425a0a8a1a991d10dcf6ca 100644 --- a/src/Tools/ExternalAccess/LiveShare/CodeActions/RoslynCodeActionProvider.Exports.cs +++ b/src/Tools/ExternalAccess/LiveShare/CodeActions/RoslynCodeActionProvider.Exports.cs @@ -11,8 +11,8 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.LiveShare.CodeActions internal class CSharpLspCodeActionProvider : RoslynCodeActionProvider { [ImportingConstructor] - public CSharpLspCodeActionProvider(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory, IDiagnosticAnalyzerService diagnosticAnalyzerService) - : base(roslynLSPClientServiceFactory, diagnosticAnalyzerService) + public CSharpLspCodeActionProvider(RoslynLspClientServiceFactory roslynLspClientServiceFactory, IDiagnosticAnalyzerService diagnosticAnalyzerService) + : base(roslynLspClientServiceFactory, diagnosticAnalyzerService) { } } @@ -22,8 +22,8 @@ public CSharpLspCodeActionProvider(RoslynLSPClientServiceFactory roslynLSPClient internal class VBLspCodeActionProvider : RoslynCodeActionProvider { [ImportingConstructor] - public VBLspCodeActionProvider(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory, IDiagnosticAnalyzerService diagnosticAnalyzerService) - : base(roslynLSPClientServiceFactory, diagnosticAnalyzerService) + public VBLspCodeActionProvider(RoslynLspClientServiceFactory roslynLspClientServiceFactory, IDiagnosticAnalyzerService diagnosticAnalyzerService) + : base(roslynLspClientServiceFactory, diagnosticAnalyzerService) { } } diff --git a/src/Tools/ExternalAccess/LiveShare/CodeActions/RoslynCodeActionProvider.cs b/src/Tools/ExternalAccess/LiveShare/CodeActions/RoslynCodeActionProvider.cs index 2b9e1daa08a629641258f984ca8a2cd612cd0073..563103fc986b6cde2a32032185c12fa89089975b 100644 --- a/src/Tools/ExternalAccess/LiveShare/CodeActions/RoslynCodeActionProvider.cs +++ b/src/Tools/ExternalAccess/LiveShare/CodeActions/RoslynCodeActionProvider.cs @@ -14,12 +14,12 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.LiveShare.CodeActions { internal class RoslynCodeActionProvider : CodeRefactoringProvider { - private readonly RoslynLSPClientServiceFactory _roslynLSPClientServiceFactory; + private readonly RoslynLspClientServiceFactory _roslynLSPClientServiceFactory; private readonly IDiagnosticAnalyzerService _diagnosticAnalyzerService; - public RoslynCodeActionProvider(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory, IDiagnosticAnalyzerService diagnosticAnalyzerService) + public RoslynCodeActionProvider(RoslynLspClientServiceFactory roslynLspClientServiceFactory, IDiagnosticAnalyzerService diagnosticAnalyzerService) { - _roslynLSPClientServiceFactory = roslynLSPClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLSPClientServiceFactory)); + _roslynLSPClientServiceFactory = roslynLspClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLspClientServiceFactory)); _diagnosticAnalyzerService = diagnosticAnalyzerService ?? throw new ArgumentNullException(nameof(diagnosticAnalyzerService)); } diff --git a/src/Tools/ExternalAccess/LiveShare/Completion/RoslynCompletionProvider.Exports.cs b/src/Tools/ExternalAccess/LiveShare/Completion/RoslynCompletionProvider.Exports.cs index 940f3cc2c533f03f5d3b513c3d532fa7bc6d8dee..257b15839dc355a21e4a90594263a12741f679a5 100644 --- a/src/Tools/ExternalAccess/LiveShare/Completion/RoslynCompletionProvider.Exports.cs +++ b/src/Tools/ExternalAccess/LiveShare/Completion/RoslynCompletionProvider.Exports.cs @@ -9,8 +9,8 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.LiveShare.Completion internal class CSharpLspCompletionProvider : RoslynCompletionProvider { [ImportingConstructor] - public CSharpLspCompletionProvider(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) - : base(roslynLSPClientServiceFactory) + public CSharpLspCompletionProvider(RoslynLspClientServiceFactory roslynLspClientServiceFactory) + : base(roslynLspClientServiceFactory) { } } @@ -19,8 +19,8 @@ public CSharpLspCompletionProvider(RoslynLSPClientServiceFactory roslynLSPClient internal class VBLspCompletionProvider : RoslynCompletionProvider { [ImportingConstructor] - public VBLspCompletionProvider(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) - : base(roslynLSPClientServiceFactory) + public VBLspCompletionProvider(RoslynLspClientServiceFactory roslynLspClientServiceFactory) + : base(roslynLspClientServiceFactory) { } } diff --git a/src/Tools/ExternalAccess/LiveShare/Completion/RoslynCompletionProvider.cs b/src/Tools/ExternalAccess/LiveShare/Completion/RoslynCompletionProvider.cs index f867b35c636fb69376ac6c52ea897dc909954448..4bcacbd1477cf15d6eb95d7cbda5fa5ea7da414e 100644 --- a/src/Tools/ExternalAccess/LiveShare/Completion/RoslynCompletionProvider.cs +++ b/src/Tools/ExternalAccess/LiveShare/Completion/RoslynCompletionProvider.cs @@ -16,11 +16,11 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.LiveShare.Completion { internal class RoslynCompletionProvider : CommonCompletionProvider { - private readonly RoslynLSPClientServiceFactory _roslynLSPClientServiceFactory; + private readonly RoslynLspClientServiceFactory _roslynLSPClientServiceFactory; - public RoslynCompletionProvider(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) + public RoslynCompletionProvider(RoslynLspClientServiceFactory roslynLspClientServiceFactory) { - _roslynLSPClientServiceFactory = roslynLSPClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLSPClientServiceFactory)); + _roslynLSPClientServiceFactory = roslynLspClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLspClientServiceFactory)); } public override async Task ProvideCompletionsAsync(CompletionContext context) diff --git a/src/Tools/ExternalAccess/LiveShare/Diagnostics/RoslynRemoteDiagnosticsService.Exports.cs b/src/Tools/ExternalAccess/LiveShare/Diagnostics/RoslynRemoteDiagnosticsService.Exports.cs index 2b4bc70702785934458d01f2bf0db0c1d8d96791..95b64446abd3914deb3bfb6b4889281d2ff65d7d 100644 --- a/src/Tools/ExternalAccess/LiveShare/Diagnostics/RoslynRemoteDiagnosticsService.Exports.cs +++ b/src/Tools/ExternalAccess/LiveShare/Diagnostics/RoslynRemoteDiagnosticsService.Exports.cs @@ -9,8 +9,8 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.LiveShare.Diagnostics internal class CSharpLspRemoteDiagnosticsService : RoslynRemoteDiagnosticsService { [ImportingConstructor] - public CSharpLspRemoteDiagnosticsService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) - : base(roslynLSPClientServiceFactory) + public CSharpLspRemoteDiagnosticsService(RoslynLspClientServiceFactory roslynLspClientServiceFactory) + : base(roslynLspClientServiceFactory) { } } @@ -19,8 +19,8 @@ public CSharpLspRemoteDiagnosticsService(RoslynLSPClientServiceFactory roslynLSP internal class VBLspRemoteDiagnosticsService : RoslynRemoteDiagnosticsService { [ImportingConstructor] - public VBLspRemoteDiagnosticsService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) - : base(roslynLSPClientServiceFactory) + public VBLspRemoteDiagnosticsService(RoslynLspClientServiceFactory roslynLspClientServiceFactory) + : base(roslynLspClientServiceFactory) { } } diff --git a/src/Tools/ExternalAccess/LiveShare/Diagnostics/RoslynRemoteDiagnosticsService.cs b/src/Tools/ExternalAccess/LiveShare/Diagnostics/RoslynRemoteDiagnosticsService.cs index 02229a095afe1671ff77130b39e7b8a680362c93..98da469c09e9ded08086ad0a664d50d85fa7da7d 100644 --- a/src/Tools/ExternalAccess/LiveShare/Diagnostics/RoslynRemoteDiagnosticsService.cs +++ b/src/Tools/ExternalAccess/LiveShare/Diagnostics/RoslynRemoteDiagnosticsService.cs @@ -13,11 +13,11 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.LiveShare.Diagnostics { internal class RoslynRemoteDiagnosticsService : IRemoteDiagnosticsService { - private readonly RoslynLSPClientServiceFactory _roslynLSPClientServiceFactory; + private readonly RoslynLspClientServiceFactory _roslynLSPClientServiceFactory; - public RoslynRemoteDiagnosticsService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) + public RoslynRemoteDiagnosticsService(RoslynLspClientServiceFactory roslynLspClientServiceFactory) { - _roslynLSPClientServiceFactory = roslynLSPClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLSPClientServiceFactory)); + _roslynLSPClientServiceFactory = roslynLspClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLspClientServiceFactory)); } public async Task> GetDiagnosticsAsync(Document document, CancellationToken cancellationToken) diff --git a/src/Tools/ExternalAccess/LiveShare/GotoDefinition/RoslynGotoDefinitionService.Exports.cs b/src/Tools/ExternalAccess/LiveShare/GotoDefinition/RoslynGotoDefinitionService.Exports.cs index faddc8d76dcfb32f87dc70ad1da65cb188198789..871486c75793f2e16a9b3771ac729501f363ca4a 100644 --- a/src/Tools/ExternalAccess/LiveShare/GotoDefinition/RoslynGotoDefinitionService.Exports.cs +++ b/src/Tools/ExternalAccess/LiveShare/GotoDefinition/RoslynGotoDefinitionService.Exports.cs @@ -13,17 +13,17 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.LiveShare.GotoDefinition internal class CSharpLspGotoDefinitionService : RoslynGotoDefinitionService { [ImportingConstructor] - public CSharpLspGotoDefinitionService(IStreamingFindUsagesPresenter streamingPresenter, RoslynLSPClientServiceFactory roslynLSPClientServiceFactory, + public CSharpLspGotoDefinitionService(IStreamingFindUsagesPresenter streamingPresenter, RoslynLSPClientServiceFactory roslynLspClientServiceFactory, RemoteLanguageServiceWorkspace remoteWorkspace, IThreadingContext threadingContext) - : base(streamingPresenter, roslynLSPClientServiceFactory, remoteWorkspace, threadingContext) { } + : base(streamingPresenter, roslynLspClientServiceFactory, remoteWorkspace, threadingContext) { } } [ExportLanguageService(typeof(IGoToDefinitionService), StringConstants.VBLspLanguageName), Shared] internal class VBLspGotoDefinitionService : RoslynGotoDefinitionService { [ImportingConstructor] - public VBLspGotoDefinitionService(IStreamingFindUsagesPresenter streamingPresenter, RoslynLSPClientServiceFactory roslynLSPClientServiceFactory, + public VBLspGotoDefinitionService(IStreamingFindUsagesPresenter streamingPresenter, RoslynLSPClientServiceFactory roslynLspClientServiceFactory, RemoteLanguageServiceWorkspace remoteWorkspace, IThreadingContext threadingContext) - : base(streamingPresenter, roslynLSPClientServiceFactory, remoteWorkspace, threadingContext) { } + : base(streamingPresenter, roslynLspClientServiceFactory, remoteWorkspace, threadingContext) { } } }*/ diff --git a/src/Tools/ExternalAccess/LiveShare/GotoDefinition/RoslynGotoDefinitionService.cs b/src/Tools/ExternalAccess/LiveShare/GotoDefinition/RoslynGotoDefinitionService.cs index bb123588aa3f00991f0cfd3615dea3a0e052726f..586278f8bcdb27af68066eb2202a04fff692bac0 100644 --- a/src/Tools/ExternalAccess/LiveShare/GotoDefinition/RoslynGotoDefinitionService.cs +++ b/src/Tools/ExternalAccess/LiveShare/GotoDefinition/RoslynGotoDefinitionService.cs @@ -29,12 +29,12 @@ internal class RoslynGotoDefinitionService : IGoToDefinitionService public RoslynGotoDefinitionService( IStreamingFindUsagesPresenter streamingPresenter, - RoslynLSPClientServiceFactory roslynLSPClientServiceFactory, + RoslynLSPClientServiceFactory roslynLspClientServiceFactory, RemoteLanguageServiceWorkspace remoteWorkspace, IThreadingContext threadingContext) { _streamingPresenter = streamingPresenter ?? throw new ArgumentNullException(nameof(streamingPresenter)); - _roslynLSPClientServiceFactory = roslynLSPClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLSPClientServiceFactory)); + _roslynLSPClientServiceFactory = roslynLspClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLspClientServiceFactory)); _remoteWorkspace = remoteWorkspace ?? throw new ArgumentNullException(nameof(remoteWorkspace)); } diff --git a/src/Tools/ExternalAccess/LiveShare/Highlights/RoslynDocumentHighlightsService.Exports.cs b/src/Tools/ExternalAccess/LiveShare/Highlights/RoslynDocumentHighlightsService.Exports.cs index 50c4d873730ace1b12526e9b68c237365f279114..c1dbfe7e0c4c17b8228753ef21f64dce44b90123 100644 --- a/src/Tools/ExternalAccess/LiveShare/Highlights/RoslynDocumentHighlightsService.Exports.cs +++ b/src/Tools/ExternalAccess/LiveShare/Highlights/RoslynDocumentHighlightsService.Exports.cs @@ -10,8 +10,8 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.LiveShare.Highlights internal class CSharpLspDocumentHighlightsService : RoslynDocumentHighlightsService { [ImportingConstructor] - public CSharpLspDocumentHighlightsService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) - : base(roslynLSPClientServiceFactory) + public CSharpLspDocumentHighlightsService(RoslynLspClientServiceFactory roslynLspClientServiceFactory) + : base(roslynLspClientServiceFactory) { } } @@ -20,8 +20,8 @@ public CSharpLspDocumentHighlightsService(RoslynLSPClientServiceFactory roslynLS internal class VBLspDocumentHighlightsService : RoslynDocumentHighlightsService { [ImportingConstructor] - public VBLspDocumentHighlightsService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) - : base(roslynLSPClientServiceFactory) + public VBLspDocumentHighlightsService(RoslynLspClientServiceFactory roslynLspClientServiceFactory) + : base(roslynLspClientServiceFactory) { } } diff --git a/src/Tools/ExternalAccess/LiveShare/Highlights/RoslynDocumentHighlightsService.cs b/src/Tools/ExternalAccess/LiveShare/Highlights/RoslynDocumentHighlightsService.cs index 5945f411ce6e5a6340abf6e9fe9f227c4f40b726..b754da565908c6c10e13a2704fa2002290e60df1 100644 --- a/src/Tools/ExternalAccess/LiveShare/Highlights/RoslynDocumentHighlightsService.cs +++ b/src/Tools/ExternalAccess/LiveShare/Highlights/RoslynDocumentHighlightsService.cs @@ -13,11 +13,11 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.LiveShare.Highlights { internal class RoslynDocumentHighlightsService : IDocumentHighlightsService { - private readonly RoslynLSPClientServiceFactory _roslynLSPClientServiceFactory; + private readonly RoslynLspClientServiceFactory _roslynLSPClientServiceFactory; - public RoslynDocumentHighlightsService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) + public RoslynDocumentHighlightsService(RoslynLspClientServiceFactory roslynLspClientServiceFactory) { - _roslynLSPClientServiceFactory = roslynLSPClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLSPClientServiceFactory)); + _roslynLSPClientServiceFactory = roslynLspClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLspClientServiceFactory)); } public async Task> GetDocumentHighlightsAsync(Document document, int position, IImmutableSet documentsToSearch, CancellationToken cancellationToken) diff --git a/src/Tools/ExternalAccess/LiveShare/Microsoft.CodeAnalysis.ExternalAccess.LiveShare.csproj b/src/Tools/ExternalAccess/LiveShare/Microsoft.CodeAnalysis.ExternalAccess.LiveShare.csproj index ab8f37b4cd97288044557e7e8291f2b893c992de..98ffa1010da83733faa30ee90e93de14ee83013b 100644 --- a/src/Tools/ExternalAccess/LiveShare/Microsoft.CodeAnalysis.ExternalAccess.LiveShare.csproj +++ b/src/Tools/ExternalAccess/LiveShare/Microsoft.CodeAnalysis.ExternalAccess.LiveShare.csproj @@ -17,6 +17,7 @@ + diff --git a/src/Tools/ExternalAccess/LiveShare/Navigation/RoslynNavigationBarItemService.Exports.cs b/src/Tools/ExternalAccess/LiveShare/Navigation/RoslynNavigationBarItemService.Exports.cs index e5e6c5abda6558f50cb3253405460680bf9f9108..3895e87ad05288a83166962648938a2459e7e30e 100644 --- a/src/Tools/ExternalAccess/LiveShare/Navigation/RoslynNavigationBarItemService.Exports.cs +++ b/src/Tools/ExternalAccess/LiveShare/Navigation/RoslynNavigationBarItemService.Exports.cs @@ -10,8 +10,8 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.LiveShare.Navigation internal class CSharpLspNavigationBarItemService : RoslynNavigationBarItemService { [ImportingConstructor] - protected CSharpLspNavigationBarItemService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) - : base(roslynLSPClientServiceFactory) + protected CSharpLspNavigationBarItemService(RoslynLspClientServiceFactory roslynLspClientServiceFactory) + : base(roslynLspClientServiceFactory) { } } @@ -20,8 +20,8 @@ protected CSharpLspNavigationBarItemService(RoslynLSPClientServiceFactory roslyn internal class VBLspNavigationBarItemService : RoslynNavigationBarItemService { [ImportingConstructor] - protected VBLspNavigationBarItemService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) - : base(roslynLSPClientServiceFactory) + protected VBLspNavigationBarItemService(RoslynLspClientServiceFactory roslynLspClientServiceFactory) + : base(roslynLspClientServiceFactory) { } } @@ -30,8 +30,8 @@ protected VBLspNavigationBarItemService(RoslynLSPClientServiceFactory roslynLSPC internal class TypeScriptLspNavigationBarItemService : RoslynNavigationBarItemService { [ImportingConstructor] - protected TypeScriptLspNavigationBarItemService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) - : base(roslynLSPClientServiceFactory) + protected TypeScriptLspNavigationBarItemService(RoslynLspClientServiceFactory roslynLspClientServiceFactory) + : base(roslynLspClientServiceFactory) { } } diff --git a/src/Tools/ExternalAccess/LiveShare/Navigation/RoslynNavigationBarItemService.cs b/src/Tools/ExternalAccess/LiveShare/Navigation/RoslynNavigationBarItemService.cs index 90c74dacc6bdaf02174dc9514674094a8957afd0..4f236dc64bd011f739d86a251d470ae52c59c6bd 100644 --- a/src/Tools/ExternalAccess/LiveShare/Navigation/RoslynNavigationBarItemService.cs +++ b/src/Tools/ExternalAccess/LiveShare/Navigation/RoslynNavigationBarItemService.cs @@ -20,11 +20,11 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.LiveShare.Navigation { internal class RoslynNavigationBarItemService : AbstractNavigationBarItemService { - private readonly RoslynLSPClientServiceFactory _roslynLSPClientServiceFactory; + private readonly RoslynLspClientServiceFactory _roslynLSPClientServiceFactory; - internal RoslynNavigationBarItemService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) + internal RoslynNavigationBarItemService(RoslynLspClientServiceFactory roslynLspClientServiceFactory) { - _roslynLSPClientServiceFactory = roslynLSPClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLSPClientServiceFactory)); + _roslynLSPClientServiceFactory = roslynLspClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLspClientServiceFactory)); } public override async Task> GetItemsAsync(Document document, CancellationToken cancellationToken) diff --git a/src/Tools/ExternalAccess/LiveShare/Projects/RoslynRemoteProjectInfoProvider.cs b/src/Tools/ExternalAccess/LiveShare/Projects/RoslynRemoteProjectInfoProvider.cs index 5ef71d3ab43d6881898959ba0bbcc0efdbb03599..2578d362d6bf81737910e89a734835f69aee633a 100644 --- a/src/Tools/ExternalAccess/LiveShare/Projects/RoslynRemoteProjectInfoProvider.cs +++ b/src/Tools/ExternalAccess/LiveShare/Projects/RoslynRemoteProjectInfoProvider.cs @@ -17,13 +17,13 @@ internal class RoslynRemoteProjectInfoProvider : IRemoteProjectInfoProvider { private const string SystemUriSchemeExternal = "vslsexternal"; - private readonly RoslynLSPClientServiceFactory _roslynLSPClientServiceFactory; + private readonly RoslynLspClientServiceFactory _roslynLSPClientServiceFactory; //private readonly IVsRemoteWorkspaceManager _remoteWorkspaceManager; [ImportingConstructor] - public RoslynRemoteProjectInfoProvider(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory)//, IVsRemoteWorkspaceManager remoteWorkspaceManager) + public RoslynRemoteProjectInfoProvider(RoslynLspClientServiceFactory roslynLspClientServiceFactory)//, IVsRemoteWorkspaceManager remoteWorkspaceManager) { - _roslynLSPClientServiceFactory = roslynLSPClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLSPClientServiceFactory)); + _roslynLSPClientServiceFactory = roslynLspClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLspClientServiceFactory)); //_remoteWorkspaceManager = remoteWorkspaceManager ?? throw new ArgumentNullException(nameof(remoteWorkspaceManager)); } diff --git a/src/Tools/ExternalAccess/LiveShare/References/RoslynFindUsagesService.Exports..cs b/src/Tools/ExternalAccess/LiveShare/References/RoslynFindUsagesService.Exports..cs index 5f6caad302fd22724988d8ef18fbfdd6c09740d5..e6cf040941bf97544502ecd92d588eb3a1c64696 100644 --- a/src/Tools/ExternalAccess/LiveShare/References/RoslynFindUsagesService.Exports..cs +++ b/src/Tools/ExternalAccess/LiveShare/References/RoslynFindUsagesService.Exports..cs @@ -10,8 +10,8 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.LiveShare.References internal class CSharpLspFindUsagesService : RoslynFindUsagesService { [ImportingConstructor] - public CSharpLspFindUsagesService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory, RemoteLanguageServiceWorkspace remoteLanguageServiceWorkspace) - : base(roslynLSPClientServiceFactory, remoteLanguageServiceWorkspace) + public CSharpLspFindUsagesService(RoslynLSPClientServiceFactory roslynLspClientServiceFactory, RemoteLanguageServiceWorkspace remoteLanguageServiceWorkspace) + : base(roslynLspClientServiceFactory, remoteLanguageServiceWorkspace) { } } @@ -20,8 +20,8 @@ public CSharpLspFindUsagesService(RoslynLSPClientServiceFactory roslynLSPClientS internal class VBLspFindUsagesService : RoslynFindUsagesService { [ImportingConstructor] - public VBLspFindUsagesService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory, RemoteLanguageServiceWorkspace remoteLanguageServiceWorkspace) - : base(roslynLSPClientServiceFactory, remoteLanguageServiceWorkspace) + public VBLspFindUsagesService(RoslynLSPClientServiceFactory roslynLspClientServiceFactory, RemoteLanguageServiceWorkspace remoteLanguageServiceWorkspace) + : base(roslynLspClientServiceFactory, remoteLanguageServiceWorkspace) { } } diff --git a/src/Tools/ExternalAccess/LiveShare/References/RoslynFindUsagesService.cs b/src/Tools/ExternalAccess/LiveShare/References/RoslynFindUsagesService.cs index efea0fa7203e996e51ef228b50f81a0205ac7bf1..33045bd098642fa0fc6691044509264bdcddbdc6 100644 --- a/src/Tools/ExternalAccess/LiveShare/References/RoslynFindUsagesService.cs +++ b/src/Tools/ExternalAccess/LiveShare/References/RoslynFindUsagesService.cs @@ -18,9 +18,9 @@ internal class RoslynFindUsagesService : IFindUsagesService private readonly RoslynLSPClientServiceFactory _roslynLSPClientServiceFactory; private readonly RemoteLanguageServiceWorkspace _remoteLanguageServiceWorkspace; - public RoslynFindUsagesService(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory, RemoteLanguageServiceWorkspace remoteLanguageServiceWorkspace) + public RoslynFindUsagesService(RoslynLSPClientServiceFactory roslynLspClientServiceFactory, RemoteLanguageServiceWorkspace remoteLanguageServiceWorkspace) { - _roslynLSPClientServiceFactory = roslynLSPClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLSPClientServiceFactory)); + _roslynLSPClientServiceFactory = roslynLspClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLspClientServiceFactory)); _remoteLanguageServiceWorkspace = remoteLanguageServiceWorkspace ?? throw new ArgumentNullException(nameof(remoteLanguageServiceWorkspace)); } diff --git a/src/Tools/ExternalAccess/LiveShare/RoslynLSPClientService.cs b/src/Tools/ExternalAccess/LiveShare/RoslynLSPClientService.cs index 6b3b0e0c31ce94c863abee668bde8013e0336812..ccdafac277bc46c842c859f22e007bb407f1b73b 100644 --- a/src/Tools/ExternalAccess/LiveShare/RoslynLSPClientService.cs +++ b/src/Tools/ExternalAccess/LiveShare/RoslynLSPClientService.cs @@ -17,7 +17,7 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.LiveShare Role = ServiceRole.LocalService, Features = "LspServices", CreationPriority = (int)ServiceRole.LocalService + 2000)] - internal class RoslynLSPClientServiceFactory : ICollaborationServiceFactory + internal class RoslynLspClientServiceFactory : ICollaborationServiceFactory { private const string RoslynProviderName = "Roslyn"; private const string AnyProviderName = "any"; diff --git a/src/Tools/ExternalAccess/LiveShare/SignatureHelp/RoslynSignatureHelpProvider.Exports.cs b/src/Tools/ExternalAccess/LiveShare/SignatureHelp/RoslynSignatureHelpProvider.Exports.cs index 860046e4c0baea0218f28aaca6ceb6f9b364e76d..09f3101670a4885c8bb8c78747cd2e6c198b5c2b 100644 --- a/src/Tools/ExternalAccess/LiveShare/SignatureHelp/RoslynSignatureHelpProvider.Exports.cs +++ b/src/Tools/ExternalAccess/LiveShare/SignatureHelp/RoslynSignatureHelpProvider.Exports.cs @@ -11,8 +11,8 @@ namespace Microsoft.VisualStudio.LanguageServices.LiveShare.Client internal class CSharpLspSignatureHelpProvider : RoslynSignatureHelpProvider { [ImportingConstructor] - public CSharpLspSignatureHelpProvider(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) - : base(roslynLSPClientServiceFactory) + public CSharpLspSignatureHelpProvider(RoslynLspClientServiceFactory roslynLspClientServiceFactory) + : base(roslynLspClientServiceFactory) { } } @@ -22,8 +22,8 @@ public CSharpLspSignatureHelpProvider(RoslynLSPClientServiceFactory roslynLSPCli internal class VBLspSignatureHelpProvider : RoslynSignatureHelpProvider { [ImportingConstructor] - public VBLspSignatureHelpProvider(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) - : base(roslynLSPClientServiceFactory) + public VBLspSignatureHelpProvider(RoslynLspClientServiceFactory roslynLspClientServiceFactory) + : base(roslynLspClientServiceFactory) { } } diff --git a/src/Tools/ExternalAccess/LiveShare/SignatureHelp/RoslynSignatureHelpProvider.cs b/src/Tools/ExternalAccess/LiveShare/SignatureHelp/RoslynSignatureHelpProvider.cs index 0fbd434fef7187fcc166618f53f590208211b462..e01c461f4398bbfdc4e4216080e3c208df743578 100644 --- a/src/Tools/ExternalAccess/LiveShare/SignatureHelp/RoslynSignatureHelpProvider.cs +++ b/src/Tools/ExternalAccess/LiveShare/SignatureHelp/RoslynSignatureHelpProvider.cs @@ -16,11 +16,11 @@ namespace Microsoft.VisualStudio.LanguageServices.LiveShare.Client { class RoslynSignatureHelpProvider : ISignatureHelpProvider { - private readonly RoslynLSPClientServiceFactory _roslynLSPClientServiceFactory; + private readonly RoslynLspClientServiceFactory _roslynLSPClientServiceFactory; - public RoslynSignatureHelpProvider(RoslynLSPClientServiceFactory roslynLSPClientServiceFactory) + public RoslynSignatureHelpProvider(RoslynLspClientServiceFactory roslynLspClientServiceFactory) { - _roslynLSPClientServiceFactory = roslynLSPClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLSPClientServiceFactory)); + _roslynLSPClientServiceFactory = roslynLspClientServiceFactory ?? throw new ArgumentNullException(nameof(roslynLspClientServiceFactory)); } public bool IsTriggerCharacter(char ch) { diff --git a/src/Tools/ExternalAccess/LiveShare/StringConstants.cs b/src/Tools/ExternalAccess/LiveShare/StringConstants.cs index 3cb21a90866faf867d38b6f474da4a0b7e694661..e79d2507dda95d7b00376cd91722892da973d529 100644 --- a/src/Tools/ExternalAccess/LiveShare/StringConstants.cs +++ b/src/Tools/ExternalAccess/LiveShare/StringConstants.cs @@ -9,7 +9,7 @@ internal class StringConstants // The service name for an LSP server implemented using Roslyn designed to be used with the Roslyn client public const string RoslynContractName = "Roslyn"; // The service name for an LSP server implemented using Roslyn designed to be used with the LSP SDK client - public const string RoslynLSPSDKContractName = "RoslynLSPSDK"; + public const string RoslynLspSdkContractName = "RoslynLSPSDK"; public const string CSharpLspLanguageName = "C#_LSP"; public const string CSharpLspContentTypeName = "C#_LSP"; diff --git a/src/VisualStudio/LiveShare/Impl/Microsoft.VisualStudio.LanguageServices.LiveShare.csproj b/src/VisualStudio/LiveShare/Impl/Microsoft.VisualStudio.LanguageServices.LiveShare.csproj index 6fee38ae852ebf234c8d9fa1669f2d4047ab7cd7..6e77b3c325ac0921cb7b23c765ef362e65a46fc4 100644 --- a/src/VisualStudio/LiveShare/Impl/Microsoft.VisualStudio.LanguageServices.LiveShare.csproj +++ b/src/VisualStudio/LiveShare/Impl/Microsoft.VisualStudio.LanguageServices.LiveShare.csproj @@ -17,6 +17,7 @@ +