From 91824c0cdf775268184e6baa118faedaa815d8ed Mon Sep 17 00:00:00 2001 From: Jason Malinowski Date: Fri, 24 May 2019 10:49:44 -0700 Subject: [PATCH] Ensure we set _solutionLoaded when the solution is loaded I totally forgot to do this, but in practice it was hard to observe because of https://github.com/dotnet/roslyn/issues/35372. That bug meant that a later project creation would end up re-running the subscription to the IVsSolution, which also checked the UIContext and that implicitly set _solutionLoaded. Once that bug was fixed this problem was now observable. --- .../ProjectSystem/Legacy/SolutionEventsBatchScopeCreator.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/VisualStudio/Core/Def/Implementation/ProjectSystem/Legacy/SolutionEventsBatchScopeCreator.cs b/src/VisualStudio/Core/Def/Implementation/ProjectSystem/Legacy/SolutionEventsBatchScopeCreator.cs index ae7ab34ebb3..f1cfe9c286a 100644 --- a/src/VisualStudio/Core/Def/Implementation/ProjectSystem/Legacy/SolutionEventsBatchScopeCreator.cs +++ b/src/VisualStudio/Core/Def/Implementation/ProjectSystem/Legacy/SolutionEventsBatchScopeCreator.cs @@ -193,6 +193,7 @@ int IVsSolutionEvents.OnBeforeCloseSolution(object pUnkReserved) int IVsSolutionLoadEvents.OnAfterBackgroundSolutionLoadComplete() { + _scopeCreator._solutionLoaded = true; _scopeCreator.StopTrackingAllProjects(); return VSConstants.S_OK; -- GitLab