Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
8abbb194
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
8abbb194
编写于
4月 05, 2019
作者:
R
Rikki Gibson
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix checks for auto-getter where malformed IsReadOnlyAttribute is present
上级
8a28f12b
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
17 addition
and
13 deletion
+17
-13
src/Compilers/CSharp/Portable/Symbols/Source/SourcePropertyAccessorSymbol.cs
...p/Portable/Symbols/Source/SourcePropertyAccessorSymbol.cs
+7
-3
src/Compilers/CSharp/Test/Semantic/Semantics/ReadOnlyStructsTests.cs
...rs/CSharp/Test/Semantic/Semantics/ReadOnlyStructsTests.cs
+10
-10
未找到文件。
src/Compilers/CSharp/Portable/Symbols/Source/SourcePropertyAccessorSymbol.cs
浏览文件 @
8abbb194
...
...
@@ -431,10 +431,14 @@ internal override bool IsDeclaredReadOnly
return
true
;
}
// We can't emit the synthesized attribute for netmodules, so in this case we consider auto-getters **not** implicitly readonly.
if
(
DeclaringCompilation
.
Options
.
OutputKind
==
OutputKind
.
NetModule
&&
DeclaringCompilation
.
GetWellKnownType
(
WellKnownType
.
System_Runtime_CompilerServices_IsReadOnlyAttribute
).
IsErrorType
())
// If we have IsReadOnly..ctor, we can use the attribute. Otherwise, we need to NOT be a netmodule and the type must not already exist in order to synthesize it.
var
isReadOnlyAttributeUsable
=
DeclaringCompilation
.
GetWellKnownTypeMember
(
WellKnownMember
.
System_Runtime_CompilerServices_IsReadOnlyAttribute__ctor
)
!=
null
||
(
DeclaringCompilation
.
Options
.
OutputKind
!=
OutputKind
.
NetModule
&&
DeclaringCompilation
.
GetWellKnownType
(
WellKnownType
.
System_Runtime_CompilerServices_IsReadOnlyAttribute
)
is
MissingMetadataTypeSymbol
);
if
(!
isReadOnlyAttributeUsable
)
{
// if the readonly attribute isn't usable, don't implicitly make auto-getters readonly.
return
false
;
}
...
...
src/Compilers/CSharp/Test/Semantic/Semantics/ReadOnlyStructsTests.cs
浏览文件 @
8abbb194
...
...
@@ -1484,17 +1484,17 @@ public struct S
public int P1 { get; private set; }
}
"
;
var
module
Comp
=
CreateCompilation
(
csharp
,
options
:
TestOptions
.
DebugModule
,
targetFramework
:
TargetFramework
.
Mscorlib45
);
moduleComp
.
VerifyDiagnostics
(
// (12,21): error CS0656: Missing compiler required member 'System.Runtime.CompilerServices.IsReadOnlyAttribute..ctor'
// public int P1 { get; private set; }
Diagnostic
(
ErrorCode
.
ERR_MissingPredefinedMember
,
"get"
).
WithArguments
(
"System.Runtime.CompilerServices.IsReadOnlyAttribute"
,
".ctor"
).
WithLocation
(
12
,
21
)
);
var
module
Metadata
=
CreateCompilation
(
csharp
,
options
:
TestOptions
.
DebugModule
,
targetFramework
:
TargetFramework
.
Mscorlib45
).
EmitToImageReference
(
);
var
moduleComp
=
CreateCompilation
(
""
,
new
[]
{
moduleMetadata
});
var
moduleGetterAttributes
=
moduleComp
.
GetMember
<
PropertySymbol
>(
"S.P1"
).
GetMethod
.
GetAttributes
();
Assert
.
Equal
(
1
,
moduleGetterAttributes
.
Length
);
Assert
.
Equal
(
"CompilerGeneratedAttribute"
,
moduleGetterAttributes
[
0
].
AttributeClass
.
Name
);
var
dll
Comp
=
CreateCompilation
(
csharp
,
options
:
TestOptions
.
DebugDll
,
targetFramework
:
TargetFramework
.
Mscorlib45
);
dllComp
.
VerifyDiagnostics
(
// (12,21): error CS0656: Missing compiler required member 'System.Runtime.CompilerServices.IsReadOnlyAttribute..ctor'
// public int P1 { get; private set; }
Diagnostic
(
ErrorCode
.
ERR_MissingPredefinedMember
,
"get"
).
WithArguments
(
"System.Runtime.CompilerServices.IsReadOnlyAttribute"
,
".ctor"
).
WithLocation
(
12
,
21
)
);
var
dll
Metadata
=
CreateCompilation
(
csharp
,
options
:
TestOptions
.
DebugDll
,
targetFramework
:
TargetFramework
.
Mscorlib45
).
EmitToImageReference
(
);
var
dllComp
=
CreateCompilation
(
""
,
new
[]
{
dllMetadata
});
var
dllGetterAttributes
=
dllComp
.
GetMember
<
PropertySymbol
>(
"S.P1"
).
GetMethod
.
GetAttributes
();
Assert
.
Equal
(
1
,
dllGetterAttributes
.
Length
);
Assert
.
Equal
(
"CompilerGeneratedAttribute"
,
dllGetterAttributes
[
0
].
AttributeClass
.
Name
);
}
[
Fact
]
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录