From 7b3e9956d21cb86883a460fccc06ec7237af69a3 Mon Sep 17 00:00:00 2001 From: Cyrus Najmabadi Date: Fri, 20 Dec 2019 15:47:58 -0800 Subject: [PATCH] Simplify type names shoudl nto simplify to 'var' --- .../SimplifyTypeNames/SimplifyTypeNamesCodeFixProvider.cs | 3 ++- .../AbstractSimplifyTypeNamesCodeFixProvider.cs | 8 -------- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/Features/CSharp/Portable/SimplifyTypeNames/SimplifyTypeNamesCodeFixProvider.cs b/src/Features/CSharp/Portable/SimplifyTypeNames/SimplifyTypeNamesCodeFixProvider.cs index 8267cf47334..af5475ef1ea 100644 --- a/src/Features/CSharp/Portable/SimplifyTypeNames/SimplifyTypeNamesCodeFixProvider.cs +++ b/src/Features/CSharp/Portable/SimplifyTypeNames/SimplifyTypeNamesCodeFixProvider.cs @@ -43,7 +43,8 @@ protected override string GetTitle(string diagnosticId, string nodeText) protected override SyntaxNode AddSimplificationAnnotationTo(SyntaxNode expressionSyntax) { - var annotatedexpressionSyntax = expressionSyntax.WithAdditionalAnnotations(Simplifier.Annotation, Formatter.Annotation); + var annotatedexpressionSyntax = expressionSyntax.WithAdditionalAnnotations( + Simplifier.Annotation, Formatter.Annotation, DoNotAllowVarAnnotation.Annotation); if (annotatedexpressionSyntax.Kind() == SyntaxKind.IsExpression || annotatedexpressionSyntax.Kind() == SyntaxKind.AsExpression) { diff --git a/src/Features/Core/Portable/SimplifyTypeNames/AbstractSimplifyTypeNamesCodeFixProvider.cs b/src/Features/Core/Portable/SimplifyTypeNames/AbstractSimplifyTypeNamesCodeFixProvider.cs index 28eedd8eb82..d0feb77eba3 100644 --- a/src/Features/Core/Portable/SimplifyTypeNames/AbstractSimplifyTypeNamesCodeFixProvider.cs +++ b/src/Features/Core/Portable/SimplifyTypeNames/AbstractSimplifyTypeNamesCodeFixProvider.cs @@ -109,14 +109,6 @@ public sealed override async Task RegisterCodeFixesAsync(CodeFixContext context) } } - private async Task SimplifyTypeNameAsync(Document document, SyntaxNode node, CancellationToken cancellationToken) - { - var root = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false); - - return document.WithSyntaxRoot( - root.ReplaceNode(node, AddSimplificationAnnotationTo(node))); - } - private bool CanSimplifyTypeNameExpression(SemanticModel model, SyntaxNode node, OptionSet optionSet, TextSpan span, out string diagnosticId, CancellationToken cancellationToken) { diagnosticId = null; -- GitLab