From 77fae0f11020d77eacf7156fb7bba4ef73f42548 Mon Sep 17 00:00:00 2001
From: Sam Harwell <Sam.Harwell@microsoft.com>
Date: Tue, 30 Apr 2019 18:14:52 -0500
Subject: [PATCH] Fix violations of RS1025 (Configure generated code analysis)

---
 eng/config/rulesets/NonShipping.ruleset                     | 3 +++
 .../DiagnosticAnalyzer/CompilerDiagnosticAnalyzer.cs        | 2 ++
 .../RenameTracking/RenameTrackingDiagnosticAnalyzer.cs      | 6 +++++-
 .../Diagnostics/Analyzers/DocumentDiagnosticAnalyzer.cs     | 2 ++
 .../Diagnostics/Analyzers/ProjectDiagnosticAnalyzer.cs      | 2 ++
 .../Analyzers/UnboundIdentifiersDiagnosticAnalyzerBase.cs   | 1 +
 .../AbstractEmbeddedLanguageDiagnosticAnalyzer.cs           | 2 ++
 .../AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs   | 1 +
 .../AbstractValidateFormatStringDiagnosticAnalyzer.cs       | 1 +
 9 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/eng/config/rulesets/NonShipping.ruleset b/eng/config/rulesets/NonShipping.ruleset
index fbf3292e54b..1a19fefe4b8 100644
--- a/eng/config/rulesets/NonShipping.ruleset
+++ b/eng/config/rulesets/NonShipping.ruleset
@@ -32,6 +32,9 @@
     <!-- DiagnosticId must be unique across analyzers - suppress for non-shipping/test projects -->
     <Rule Id="RS1019" Action="None" />
 
+    <!-- Configure generated code analysis - suppress for non-shipping/test projects -->
+    <Rule Id="RS1025" Action="None" />
+
     <!-- Do not use generic CodeAction.Create to create CodeAction - not useful for tests -->
     <Rule Id="RS0005" Action="None" />
   </Rules>
diff --git a/src/Compilers/Core/Portable/DiagnosticAnalyzer/CompilerDiagnosticAnalyzer.cs b/src/Compilers/Core/Portable/DiagnosticAnalyzer/CompilerDiagnosticAnalyzer.cs
index 292f303a89d..3a200afcce2 100644
--- a/src/Compilers/Core/Portable/DiagnosticAnalyzer/CompilerDiagnosticAnalyzer.cs
+++ b/src/Compilers/Core/Portable/DiagnosticAnalyzer/CompilerDiagnosticAnalyzer.cs
@@ -35,6 +35,8 @@ public sealed override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
 
         public sealed override void Initialize(AnalysisContext context)
         {
+            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
+
             context.RegisterCompilationStartAction(c =>
             {
                 var analyzer = new CompilationAnalyzer(c.Compilation);
diff --git a/src/EditorFeatures/Core/Implementation/RenameTracking/RenameTrackingDiagnosticAnalyzer.cs b/src/EditorFeatures/Core/Implementation/RenameTracking/RenameTrackingDiagnosticAnalyzer.cs
index ff2d72475c8..c4a675d7c29 100644
--- a/src/EditorFeatures/Core/Implementation/RenameTracking/RenameTrackingDiagnosticAnalyzer.cs
+++ b/src/EditorFeatures/Core/Implementation/RenameTracking/RenameTrackingDiagnosticAnalyzer.cs
@@ -27,7 +27,11 @@ public bool OpenFileOnly(Workspace workspace)
             => true;
 
         public override void Initialize(AnalysisContext context)
-            => context.RegisterSyntaxTreeAction(AnalyzeSyntaxTree);
+        {
+            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
+
+            context.RegisterSyntaxTreeAction(AnalyzeSyntaxTree);
+        }
 
         private void AnalyzeSyntaxTree(SyntaxTreeAnalysisContext context)
         {
diff --git a/src/Features/Core/Portable/Diagnostics/Analyzers/DocumentDiagnosticAnalyzer.cs b/src/Features/Core/Portable/Diagnostics/Analyzers/DocumentDiagnosticAnalyzer.cs
index 74f53620b1c..f87a166e462 100644
--- a/src/Features/Core/Portable/Diagnostics/Analyzers/DocumentDiagnosticAnalyzer.cs
+++ b/src/Features/Core/Portable/Diagnostics/Analyzers/DocumentDiagnosticAnalyzer.cs
@@ -20,7 +20,9 @@ internal abstract class DocumentDiagnosticAnalyzer : DiagnosticAnalyzer
         /// <summary>
         /// it is not allowed one to implement both DocumentDiagnosticAnalzyer and DiagnosticAnalyzer
         /// </summary>
+#pragma warning disable RS1025 // Configure generated code analysis
         public sealed override void Initialize(AnalysisContext context)
+#pragma warning restore RS1025 // Configure generated code analysis
         {
         }
 
diff --git a/src/Features/Core/Portable/Diagnostics/Analyzers/ProjectDiagnosticAnalyzer.cs b/src/Features/Core/Portable/Diagnostics/Analyzers/ProjectDiagnosticAnalyzer.cs
index a70ba68e640..bcf4f74afb4 100644
--- a/src/Features/Core/Portable/Diagnostics/Analyzers/ProjectDiagnosticAnalyzer.cs
+++ b/src/Features/Core/Portable/Diagnostics/Analyzers/ProjectDiagnosticAnalyzer.cs
@@ -18,7 +18,9 @@ internal abstract class ProjectDiagnosticAnalyzer : DiagnosticAnalyzer
         /// <summary>
         /// it is not allowed one to implement both ProjectDiagnosticAnalzyer and DiagnosticAnalyzer
         /// </summary>
+#pragma warning disable RS1025 // Configure generated code analysis
         public sealed override void Initialize(AnalysisContext context)
+#pragma warning restore RS1025 // Configure generated code analysis
         {
         }
 
diff --git a/src/Features/Core/Portable/Diagnostics/Analyzers/UnboundIdentifiersDiagnosticAnalyzerBase.cs b/src/Features/Core/Portable/Diagnostics/Analyzers/UnboundIdentifiersDiagnosticAnalyzerBase.cs
index ccaf517881a..786be27f5b1 100644
--- a/src/Features/Core/Portable/Diagnostics/Analyzers/UnboundIdentifiersDiagnosticAnalyzerBase.cs
+++ b/src/Features/Core/Portable/Diagnostics/Analyzers/UnboundIdentifiersDiagnosticAnalyzerBase.cs
@@ -26,6 +26,7 @@ internal abstract class UnboundIdentifiersDiagnosticAnalyzerBase<TLanguageKindEn
         public override void Initialize(AnalysisContext context)
         {
             context.EnableConcurrentExecution();
+            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
 
             context.RegisterSyntaxNodeAction(AnalyzeNode, this.SyntaxKindsOfInterest.ToArray());
         }
diff --git a/src/Features/Core/Portable/EmbeddedLanguages/AbstractEmbeddedLanguageDiagnosticAnalyzer.cs b/src/Features/Core/Portable/EmbeddedLanguages/AbstractEmbeddedLanguageDiagnosticAnalyzer.cs
index 47f820797ca..7e42f2ee5f5 100644
--- a/src/Features/Core/Portable/EmbeddedLanguages/AbstractEmbeddedLanguageDiagnosticAnalyzer.cs
+++ b/src/Features/Core/Portable/EmbeddedLanguages/AbstractEmbeddedLanguageDiagnosticAnalyzer.cs
@@ -53,6 +53,8 @@ public bool OpenFileOnly(Workspace workspace)
 
         public override void Initialize(AnalysisContext context)
         {
+            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
+
             foreach (var analyzer in _analyzers)
             {
                 analyzer.Initialize(context);
diff --git a/src/Features/Core/Portable/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs b/src/Features/Core/Portable/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs
index 2f18dda40db..cee3c36a995 100644
--- a/src/Features/Core/Portable/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs
+++ b/src/Features/Core/Portable/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs
@@ -73,6 +73,7 @@ public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
         public override void Initialize(AnalysisContext context)
         {
             context.EnableConcurrentExecution();
+            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
 
             context.RegisterSemanticModelAction(this.AnalyzeSemanticModel);
         }
diff --git a/src/Features/Core/Portable/ValidateFormatString/AbstractValidateFormatStringDiagnosticAnalyzer.cs b/src/Features/Core/Portable/ValidateFormatString/AbstractValidateFormatStringDiagnosticAnalyzer.cs
index ba26fbed6b0..309d66ff267 100644
--- a/src/Features/Core/Portable/ValidateFormatString/AbstractValidateFormatStringDiagnosticAnalyzer.cs
+++ b/src/Features/Core/Portable/ValidateFormatString/AbstractValidateFormatStringDiagnosticAnalyzer.cs
@@ -65,6 +65,7 @@ public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics
         public override void Initialize(AnalysisContext context)
         {
             context.EnableConcurrentExecution();
+            context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
 
             context.RegisterCompilationStartAction(startContext =>
             {
-- 
GitLab