Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
72a1cfe0
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
72a1cfe0
编写于
3月 07, 2015
作者:
S
Stephen Toub
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Disable Array.Empty params array optimization in expression lambdas
上级
dd9c889d
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
18 addition
and
1 deletion
+18
-1
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_Call.cs
...arp/Portable/Lowering/LocalRewriter/LocalRewriter_Call.cs
+5
-1
src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenExprLambdaTests.cs
...pilers/CSharp/Test/Emit/CodeGen/CodeGenExprLambdaTests.cs
+13
-0
未找到文件。
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_Call.cs
浏览文件 @
72a1cfe0
...
...
@@ -615,7 +615,11 @@ private static ImmutableArray<RefKind> GetRefKindsOrNull(ArrayBuilder<RefKind> r
var
paramArrayType
=
parameters
[
paramsParam
].
Type
;
var
arrayArgs
=
paramArray
.
ToImmutableAndFree
();
if
(
arrayArgs
.
Length
==
0
)
// if this is a zero-length array, rather than using "new T[0]", optimize with "Array.Empty<T>()" if it's available
// If this is a zero-length array, rather than using "new T[0]", optimize with "Array.Empty<T>()"
// if it's available. However, we also disable the optimization if we're in an expression lambda, the
// point of which is just to represent the semantics of an operation, and we don't know that all consumers
// of expression lambdas will appropriately understand Array.Empty<T>().
if
(
arrayArgs
.
Length
==
0
&&
!
_inExpressionLambda
)
{
ArrayTypeSymbol
ats
=
paramArrayType
as
ArrayTypeSymbol
;
if
(
ats
!=
null
)
// could be null if there's a semantic error, e.g. the params parameter type isn't an array
...
...
src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenExprLambdaTests.cs
浏览文件 @
72a1cfe0
...
...
@@ -2273,6 +2273,19 @@ static void Main()
CompileAndVerify
(
text
,
new
[]
{
ExpressionAssemblyRef
},
expectedOutput
:
TrimExpectedOutput
(
expectedOutput
));
// Also verify with the assemblies on which the tests are running, as there's a higher
// liklihood that they have Array.Empty, and we want to verify that Array.Empty is not used
// in expression lambdas. This can be changed to use the mscorlib 4.6 metadata once it's
// available in the Roslyn tests.
CompileAndVerify
(
CreateCompilation
(
text
,
references
:
new
[]
{
MetadataReference
.
CreateFromAssembly
(
typeof
(
object
).
Assembly
),
MetadataReference
.
CreateFromAssembly
(
typeof
(
System
.
Linq
.
Enumerable
).
Assembly
)
},
options
:
TestOptions
.
ReleaseExe
),
expectedOutput
:
TrimExpectedOutput
(
expectedOutput
));
}
[
WorkItem
(
544270
,
"DevDiv"
)]
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录