From 6c6510f97f486b9c529f674fbbf22202819338e0 Mon Sep 17 00:00:00 2001
From: Cyrus Najmabadi <cyrus.najmabadi@gmail.com>
Date: Tue, 14 Jan 2020 11:49:52 -0800
Subject: [PATCH] Introduce local and remove unnecessary conditional return

---
 .../Extensions/ExpressionSyntaxExtensions.cs  | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/src/Workspaces/CSharp/Portable/Extensions/ExpressionSyntaxExtensions.cs b/src/Workspaces/CSharp/Portable/Extensions/ExpressionSyntaxExtensions.cs
index 8949b6786fd..91ed20aa0eb 100644
--- a/src/Workspaces/CSharp/Portable/Extensions/ExpressionSyntaxExtensions.cs
+++ b/src/Workspaces/CSharp/Portable/Extensions/ExpressionSyntaxExtensions.cs
@@ -1064,20 +1064,17 @@ private static bool PreferPredefinedTypeKeywordInMemberAccess(ExpressionSyntax e
 
         private static bool IsAliasReplaceableExpression(ExpressionSyntax expression)
         {
-            while (expression.IsKind(SyntaxKind.SimpleMemberAccessExpression, out MemberAccessExpressionSyntax currentMember))
+            var current = expression;
+            while (current.IsKind(SyntaxKind.SimpleMemberAccessExpression, out MemberAccessExpressionSyntax currentMember))
             {
-                expression = currentMember.Expression;
+                current = currentMember.Expression;
+                continue;
             }
 
-            if (expression.Kind() == SyntaxKind.IdentifierName ||
-                expression.Kind() == SyntaxKind.QualifiedName ||
-                expression.Kind() == SyntaxKind.AliasQualifiedName ||
-                expression.Kind() == SyntaxKind.GenericName)
-            {
-                return true;
-            }
-
-            return false;
+            return current.IsKind(SyntaxKind.AliasQualifiedName,
+                                  SyntaxKind.IdentifierName,
+                                  SyntaxKind.GenericName,
+                                  SyntaxKind.QualifiedName);
         }
 
         [PerformanceSensitive(
-- 
GitLab