From 637398fcfafd1e1414b40751eeb967babeac41bb Mon Sep 17 00:00:00 2001 From: Charles Stoner Date: Thu, 17 Mar 2016 17:35:59 -0700 Subject: [PATCH] Unskip EE tests --- .../Test/ExpressionCompiler/ExpressionCompilerTests.cs | 1 + .../ResultProvider/DebuggerBrowsableAttributeTests.cs | 8 +++++--- .../Test/ResultProvider/DebuggerDisplayAttributeTests.cs | 5 ++--- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/ExpressionEvaluator/CSharp/Test/ExpressionCompiler/ExpressionCompilerTests.cs b/src/ExpressionEvaluator/CSharp/Test/ExpressionCompiler/ExpressionCompilerTests.cs index 24d11bf1a2b..9d2c77b0043 100644 --- a/src/ExpressionEvaluator/CSharp/Test/ExpressionCompiler/ExpressionCompilerTests.cs +++ b/src/ExpressionEvaluator/CSharp/Test/ExpressionCompiler/ExpressionCompilerTests.cs @@ -2283,6 +2283,7 @@ static void Main() /// Flow analysis should catch definite assignment errors /// for variables declared within the expression. /// + [WorkItem(549, "https://github.com/dotnet/roslyn/issues/549")] [Fact(Skip = "https://github.com/dotnet/roslyn/issues/549")] public void FlowAnalysis() { diff --git a/src/ExpressionEvaluator/CSharp/Test/ResultProvider/DebuggerBrowsableAttributeTests.cs b/src/ExpressionEvaluator/CSharp/Test/ResultProvider/DebuggerBrowsableAttributeTests.cs index 54f770968a0..7a20f384084 100644 --- a/src/ExpressionEvaluator/CSharp/Test/ResultProvider/DebuggerBrowsableAttributeTests.cs +++ b/src/ExpressionEvaluator/CSharp/Test/ResultProvider/DebuggerBrowsableAttributeTests.cs @@ -248,11 +248,11 @@ class C } /// - /// Value should not be expandable if all members are marked + /// Instance of type where all members are marked /// [DebuggerBrowsable(DebuggerBrowsableState.RootHidden)]. /// [WorkItem(934800, "http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/934800")] - [Fact(Skip = "934800")] + [Fact] public void RootHidden_Empty() { var source = @@ -282,7 +282,9 @@ class C evalFlags: DkmEvaluationResultFlags.None); var evalResult = FormatResult("o", value); Verify(evalResult, - EvalResult("o", "{C}", "C", "o")); + EvalResult("o", "{C}", "C", "o", DkmEvaluationResultFlags.Expandable)); // Ideally, not expandable. + var children = GetChildren(evalResult); + Verify(children); // No children. } [Fact] diff --git a/src/ExpressionEvaluator/CSharp/Test/ResultProvider/DebuggerDisplayAttributeTests.cs b/src/ExpressionEvaluator/CSharp/Test/ResultProvider/DebuggerDisplayAttributeTests.cs index 0fde6b38bef..4b12a581601 100644 --- a/src/ExpressionEvaluator/CSharp/Test/ResultProvider/DebuggerDisplayAttributeTests.cs +++ b/src/ExpressionEvaluator/CSharp/Test/ResultProvider/DebuggerDisplayAttributeTests.cs @@ -334,8 +334,7 @@ class Wrapper EvalResult("NoDisplayPointer", PointerToString(IntPtr.Zero), "NoDisplay*", "wrapper.display.NoDisplayPointer")); } - [WorkItem(321, "https://github.com/dotnet/roslyn/issues/321")] - [Fact(Skip = "https://github.com/dotnet/roslyn/issues/321")] + [Fact] public void PointerDereferenceExpansion_NonNull() { var source = @" @@ -396,7 +395,7 @@ public C(IntPtr d, IntPtr nd) Verify(DepthFirstSearch(FormatResult("c", testValue), maxDepth: 3), EvalResult("c", "{C}", "C", "c", DkmEvaluationResultFlags.Expandable), EvalResult("DisplayPointer", displayPtrString, "Display*", "c.DisplayPointer", DkmEvaluationResultFlags.Expandable), - EvalResult("Name", "Value", "Type", "*c.DisplayPointer", DkmEvaluationResultFlags.Expandable), + EvalResult("*c.DisplayPointer", "Value", "Type", "*c.DisplayPointer", DkmEvaluationResultFlags.Expandable), EvalResult("DisplayPointer", displayPtrString, "Display*", "(*c.DisplayPointer).DisplayPointer", DkmEvaluationResultFlags.Expandable), EvalResult("NoDisplayPointer", noDisplayPtrString, "NoDisplay*", "(*c.DisplayPointer).NoDisplayPointer", DkmEvaluationResultFlags.Expandable), EvalResult("NoDisplayPointer", noDisplayPtrString, "NoDisplay*", "c.NoDisplayPointer", DkmEvaluationResultFlags.Expandable), -- GitLab