From 5e5c1ded907af641c29d1899ead33ac93d1e969b Mon Sep 17 00:00:00 2001 From: Tom Meschter Date: Mon, 9 Jul 2018 15:22:29 -0700 Subject: [PATCH] Turn on loc check for dev15.8.x Turn on the `windows_loc_status` check for the dev15.8.x and dev15.8.x-vs-deps branches for CI builds. For PR builds it will continue to show only when requested. It is expected that it will fail in these branches until we have our final loc passes. --- netci.groovy | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/netci.groovy b/netci.groovy index f40042081eb..cd5e6419040 100644 --- a/netci.groovy +++ b/netci.groovy @@ -238,9 +238,10 @@ commitPullList.each { isPr -> // Loc status check commitPullList.each { isPr -> - // Only add the check to PR builds for now. At some point we'll change this check - // to instead look for particular branch names. - if (isPr) { + // Add the check for PR builds, and dev15.8.x/dev15.8.x-vs-deps builds. + if (isPr + || branchName == "dev15.8.x" + || branchName == "dev15.8.x-vs-deps") { def jobName = Utilities.getFullJobName(projectName, "windows_loc_status", isPr) def myJob = job(jobName) { description('Check for untranslated resources') @@ -249,8 +250,8 @@ commitPullList.each { isPr -> } } - // For now we'll only run this when explicitly asked. - def triggerPhraseOnly = true + // Run it automatically on CI builds but only when requested on PR builds. + def triggerPhraseOnly = isPr def triggerPhraseExtra = "loc" Utilities.setMachineAffinity(myJob, 'Windows_NT', windowsUnitTestMachine) addRoslynJob(myJob, jobName, branchName, isPr, triggerPhraseExtra, triggerPhraseOnly) -- GitLab