Part 1 of moving Visual Studio to Open

Background:

As discussed in the dev team all hands all code under the GitHub dotnet foundation is using a single process for contribution, API review, infrastructure and coding style. The idea is to present a unified view to our customer and give them a single story for contributing to any project under the dotnet foundation.

https://github.com/dotnet/corefx/wiki/Contributing#c-coding-style

The coding style transition is automated using a Roslyn based rewrite tool:

https://github.com/dotnet/codeformatter

This will be applied in stages across our developer tree. Right now the focus is on the Open directory as this is what is being presented on github. Code owners will be contacted before the transition happens.

Note: this is a soft style requirement. There are no build errors that come from this change. (changeset 1406961)

src/Test/PdbUtilities/Shared/SymUnmanagedReaderExtensions.cs

@@ -49,7 +49,7 @@ internal static class SymUnmanagedReaderExtensions
         internal const int E_FAIL = unchecked((int)0x80004005);
         internal const int E_NOTIMPL = unchecked((int)0x80004001);
 
-        private static readonly IntPtr IgnoreIErrorInfo = new IntPtr(-1);
+        private static readonly IntPtr s_ignoreIErrorInfo = new IntPtr(-1);
 
         // The name of the attribute containing the byte array of custom debug info.
         // MSCUSTOMDEBUGINFO in Dev10.
@@ -484,7 +484,7 @@ internal static void ThrowExceptionForHR(int hr)
             // E_NOTIMPL indicates a lack of ISymUnmanagedReader support (in a particular implementation).
             if (hr < 0 && hr != E_FAIL && hr != E_NOTIMPL)
             {
-                Marshal.ThrowExceptionForHR(hr, IgnoreIErrorInfo);
+                Marshal.ThrowExceptionForHR(hr, s_ignoreIErrorInfo);
             }
         }