From 5357afd9d165f01f5dd60821e790cf4134602374 Mon Sep 17 00:00:00 2001 From: Adam Speight Date: Wed, 28 Sep 2016 18:13:52 +0100 Subject: [PATCH] Small optimisation in CompilerOptionParseUtilities.cs (#13975) Just return the array from the `.Split` function as array implements `IList` --- .../InternalUtilities/CompilerOptionParseUtilities.cs | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/Compilers/Core/Portable/InternalUtilities/CompilerOptionParseUtilities.cs b/src/Compilers/Core/Portable/InternalUtilities/CompilerOptionParseUtilities.cs index acd763094b6..41b3065f64a 100644 --- a/src/Compilers/Core/Portable/InternalUtilities/CompilerOptionParseUtilities.cs +++ b/src/Compilers/Core/Portable/InternalUtilities/CompilerOptionParseUtilities.cs @@ -19,14 +19,7 @@ public static IList ParseFeatureFromMSBuild(string features) return SpecializedCollections.EmptyList(); } - var all = features.Split(new[] { ';', ',', ' ' }, StringSplitOptions.RemoveEmptyEntries); - var list = new List(capacity: all.Length); - foreach (var feature in all) - { - list.Add(feature); - } - - return list; + return features.Split(new[] { ';', ',', ' ' }, StringSplitOptions.RemoveEmptyEntries); } public static ImmutableDictionary ParseFeatures(List values) -- GitLab