diff --git a/src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs b/src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs index ea672e2a53f9fe22066356f057bca844e6f734e9..d97a6125b81cb9f2a971912993df2c645a645a18 100644 --- a/src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs +++ b/src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer.Executor.cs @@ -90,7 +90,7 @@ public IEnumerable ConvertToLocalDiagnostics(Document targetDocu /// Return all diagnostics that belong to given project for the given StateSets (analyzers) either from cache or by calculating them /// public async Task GetProjectAnalysisDataAsync( - CompilationWithAnalyzers analyzerDriverOpt, Project project, IEnumerable stateSets, bool ignoreOption, CancellationToken cancellationToken) + CompilationWithAnalyzers analyzerDriverOpt, Project project, IEnumerable stateSets, bool ignoreFullAnalysisOptions, CancellationToken cancellationToken) { using (Logger.LogBlock(FunctionId.Diagnostics_ProjectDiagnostic, GetProjectLogMessage, project, stateSets, cancellationToken)) { @@ -107,7 +107,7 @@ public IEnumerable ConvertToLocalDiagnostics(Document targetDocu } // perf optimization. check whether we want to analyze this project or not. - if (!await FullAnalysisEnabledAsync(project, ignoreOption, cancellationToken).ConfigureAwait(false)) + if (!await FullAnalysisEnabledAsync(project, ignoreFullAnalysisOptions, cancellationToken).ConfigureAwait(false)) { return new ProjectAnalysisData(project.Id, VersionStamp.Default, existingData.Result, ImmutableDictionary.Empty); } @@ -402,12 +402,12 @@ private async Task UpdateAnalyzerTelemetryDataAsync(CompilationWithAnalyzers ana } } - private static async Task FullAnalysisEnabledAsync(Project project, bool ignoreOption, CancellationToken cancellationToken) + private static async Task FullAnalysisEnabledAsync(Project project, bool ignoreFullAnalysisOptions, CancellationToken cancellationToken) { var workspace = project.Solution.Workspace; var language = project.Language; - if (ignoreOption) + if (ignoreFullAnalysisOptions) { return await project.HasSuccessfullyLoadedAsync(cancellationToken).ConfigureAwait(false); } diff --git a/src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_GetDiagnostics.cs b/src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_GetDiagnostics.cs index 605c1f852daf23135e2244a8d967761cd74bff43..9332b05adb8353526fcf60bc38e9df801f79cb6b 100644 --- a/src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_GetDiagnostics.cs +++ b/src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_GetDiagnostics.cs @@ -399,8 +399,8 @@ protected override async Task AppendDiagnosticsAsync(Project project, IEnumerabl // unlike the suppressed (disabled) analyzer, we will include hidden diagnostic only analyzers here. var analyzerDriverOpt = await Owner._compilationManager.CreateAnalyzerDriverAsync(project, stateSets, IncludeSuppressedDiagnostics, cancellationToken).ConfigureAwait(false); - var ignoreOption = true; - var result = await Owner._executor.GetProjectAnalysisDataAsync(analyzerDriverOpt, project, stateSets, ignoreOption, cancellationToken).ConfigureAwait(false); + var ignoreFullAnalysisOptions = true; + var result = await Owner._executor.GetProjectAnalysisDataAsync(analyzerDriverOpt, project, stateSets, ignoreFullAnalysisOptions, cancellationToken).ConfigureAwait(false); foreach (var stateSet in stateSets) { @@ -446,7 +446,7 @@ private bool ShouldIncludeStateSet(Project project, StateSet stateSet) // Here, we don't care what kind of analyzer (StateSet) is given. // We just create and use AnalyzerDriver with the given analyzer (StateSet). - var ignoreOption = true; + var ignoreFullAnalysisOptions = true; var analyzerDriverOpt = await Owner._compilationManager.CreateAnalyzerDriverAsync(project, stateSets, IncludeSuppressedDiagnostics, cancellationToken).ConfigureAwait(false); if (documentId != null) @@ -464,7 +464,7 @@ private bool ShouldIncludeStateSet(Project project, StateSet stateSet) } case AnalysisKind.NonLocal: { - var nonLocalDocumentResult = await Owner._executor.GetProjectAnalysisDataAsync(analyzerDriverOpt, project, stateSets, ignoreOption, cancellationToken).ConfigureAwait(false); + var nonLocalDocumentResult = await Owner._executor.GetProjectAnalysisDataAsync(analyzerDriverOpt, project, stateSets, ignoreFullAnalysisOptions, cancellationToken).ConfigureAwait(false); var analysisResult = nonLocalDocumentResult.GetResult(stateSet.Analyzer); return GetResult(analysisResult, AnalysisKind.NonLocal, documentId); } @@ -474,7 +474,7 @@ private bool ShouldIncludeStateSet(Project project, StateSet stateSet) } Contract.ThrowIfFalse(kind == AnalysisKind.NonLocal); - var projectResult = await Owner._executor.GetProjectAnalysisDataAsync(analyzerDriverOpt, project, stateSets, ignoreOption, cancellationToken).ConfigureAwait(false); + var projectResult = await Owner._executor.GetProjectAnalysisDataAsync(analyzerDriverOpt, project, stateSets, ignoreFullAnalysisOptions, cancellationToken).ConfigureAwait(false); return projectResult.GetResult(stateSet.Analyzer).Others; } } diff --git a/src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_IncrementalAnalyzer.cs b/src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_IncrementalAnalyzer.cs index 776f6b2abe99c10f4faa3e7fd4f90f6e59e5e7a7..bbfbd1029273d816af4219b2ea0bd373ea05674d 100644 --- a/src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_IncrementalAnalyzer.cs +++ b/src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_IncrementalAnalyzer.cs @@ -83,8 +83,8 @@ public override async Task AnalyzeProjectAsync(Project project, bool semanticsCh var includeSuppressedDiagnostics = true; var analyzerDriverOpt = await _compilationManager.CreateAnalyzerDriverAsync(project, activeAnalyzers, includeSuppressedDiagnostics, cancellationToken).ConfigureAwait(false); - var ignoreOption = false; - var result = await _executor.GetProjectAnalysisDataAsync(analyzerDriverOpt, project, stateSets, ignoreOption, cancellationToken).ConfigureAwait(false); + var ignoreFullAnalysisOptions = false; + var result = await _executor.GetProjectAnalysisDataAsync(analyzerDriverOpt, project, stateSets, ignoreFullAnalysisOptions, cancellationToken).ConfigureAwait(false); if (result.FromCache) { RaiseProjectDiagnosticsIfNeeded(project, stateSets, result.Result);