From 41c4937189aa85a93eb4f6ce7871021b96528260 Mon Sep 17 00:00:00 2001
From: TIHan <lol.tihan@gmail.com>
Date: Fri, 15 Mar 2019 13:20:26 -0700
Subject: [PATCH] Removed IVT fsharp, fixed build

---
 ...oft.CodeAnalysis.EditorFeatures.Wpf.csproj |  2 +-
 ...ft.CodeAnalysis.EditorFeatures.Text.csproj |  3 +-
 .../FSharp/Completion/CompletionOptions.cs    |  2 +-
 ...ervice.cs => DiagnosticAnalyzerService.cs} |  4 +--
 .../FSharp/Editor/FSharpBraceMatcher.cs       | 34 +++++++++++++++++++
 .../FSharp/Editor/IFSharpBraceMatcher.cs      | 24 +++++++++++++
 .../FSharp/PublicAPI.Unshipped.txt            |  6 ++++
 ...osoft.VisualStudio.LanguageServices.csproj |  3 +-
 ...dio.LanguageServices.Implementation.csproj |  3 +-
 9 files changed, 71 insertions(+), 10 deletions(-)
 rename src/Tools/ExternalAccess/FSharp/Diagnostics/{FSharpDiagnosticAnalyzerService.cs => DiagnosticAnalyzerService.cs} (76%)
 create mode 100644 src/Tools/ExternalAccess/FSharp/Editor/FSharpBraceMatcher.cs
 create mode 100644 src/Tools/ExternalAccess/FSharp/Editor/IFSharpBraceMatcher.cs

diff --git a/src/EditorFeatures/Core.Wpf/Microsoft.CodeAnalysis.EditorFeatures.Wpf.csproj b/src/EditorFeatures/Core.Wpf/Microsoft.CodeAnalysis.EditorFeatures.Wpf.csproj
index 0770ee7b786..d6336e3af57 100644
--- a/src/EditorFeatures/Core.Wpf/Microsoft.CodeAnalysis.EditorFeatures.Wpf.csproj
+++ b/src/EditorFeatures/Core.Wpf/Microsoft.CodeAnalysis.EditorFeatures.Wpf.csproj
@@ -47,7 +47,7 @@
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.CSharp" />
     <InternalsVisibleTo Include="Microsoft.CodeAnalysis.InteractiveEditorFeatures" />
     <InternalsVisibleTo Include="Microsoft.CodeAnalysis.Remote.ServiceHub" />
-    <InternalsVisibleTo Include="FSharp.Editor" Key="$(FSharpKey)" />
+    <InternalsVisibleTo Include="Microsoft.CodeAnalysis.ExternalAccess.FSharp" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.IntegrationTest.Utilities" />
     <InternalsVisibleTo Include="Roslyn.Services.Test.Utilities" />
     <InternalsVisibleTo Include="Microsoft.CodeAnalysis.EditorFeatures.UnitTests" />
diff --git a/src/EditorFeatures/Text/Microsoft.CodeAnalysis.EditorFeatures.Text.csproj b/src/EditorFeatures/Text/Microsoft.CodeAnalysis.EditorFeatures.Text.csproj
index 700cc896f3c..acf4d8d5424 100644
--- a/src/EditorFeatures/Text/Microsoft.CodeAnalysis.EditorFeatures.Text.csproj
+++ b/src/EditorFeatures/Text/Microsoft.CodeAnalysis.EditorFeatures.Text.csproj
@@ -39,6 +39,7 @@
     <InternalsVisibleTo Include="Microsoft.CodeAnalysis.CSharp.InteractiveEditorFeatures" />
     <InternalsVisibleTo Include="Microsoft.CodeAnalysis.InteractiveEditorFeatures" />
     <InternalsVisibleTo Include="Microsoft.CodeAnalysis.VisualBasic.InteractiveEditorFeatures" />
+    <InternalsVisibleTo Include="Microsoft.CodeAnalysis.ExternalAccess.FSharp" />
     <InternalsVisibleTo Include="Microsoft.CodeAnalysis.TypeScript.EditorFeatures" Key="$(TypeScriptKey)" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.Implementation" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.TypeScript" Key="$(TypeScriptKey)" />
@@ -52,8 +53,6 @@
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.Remote.CSharp.16.0" Key="$(RemoteLanguageServiceKey)" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.Xaml" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.VisualBasic.Repl" />
-    <InternalsVisibleTo Include="FSharp.Editor" Key="$(FSharpKey)" />
-    <InternalsVisibleTo Include="FSharp.LanguageService" Key="$(FSharpKey)" />
     <!-- BEGIN MONODEVELOP
     These MonoDevelop dependencies don't ship with Visual Studio, so can't break our
     binary insertions and are exempted from the ExternalAccess adapter assembly policies.
diff --git a/src/Tools/ExternalAccess/FSharp/Completion/CompletionOptions.cs b/src/Tools/ExternalAccess/FSharp/Completion/CompletionOptions.cs
index b5a3d33a9ec..34710362235 100644
--- a/src/Tools/ExternalAccess/FSharp/Completion/CompletionOptions.cs
+++ b/src/Tools/ExternalAccess/FSharp/Completion/CompletionOptions.cs
@@ -4,6 +4,6 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.FSharp.Completion
 {
     public static class CompletionOptions
     {
-        public static readonly PerLanguageOption<bool> BlockForCompletionItems = Microsoft.CodeAnalysis.Completion.CompletionOptions.BlockForCompletionItems
+        public static readonly PerLanguageOption<bool> BlockForCompletionItems = Microsoft.CodeAnalysis.Completion.CompletionOptions.BlockForCompletionItems;
     }
 }
diff --git a/src/Tools/ExternalAccess/FSharp/Diagnostics/FSharpDiagnosticAnalyzerService.cs b/src/Tools/ExternalAccess/FSharp/Diagnostics/DiagnosticAnalyzerService.cs
similarity index 76%
rename from src/Tools/ExternalAccess/FSharp/Diagnostics/FSharpDiagnosticAnalyzerService.cs
rename to src/Tools/ExternalAccess/FSharp/Diagnostics/DiagnosticAnalyzerService.cs
index 220c5040f58..adfb88fae0f 100644
--- a/src/Tools/ExternalAccess/FSharp/Diagnostics/FSharpDiagnosticAnalyzerService.cs
+++ b/src/Tools/ExternalAccess/FSharp/Diagnostics/DiagnosticAnalyzerService.cs
@@ -5,12 +5,12 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.FSharp.Diagnostics
 {
     [Export(typeof(IDiagnosticAnalyzerService))]
     [Shared]
-    internal sealed class FSharpDiagnosticAnalyzerService : IDiagnosticAnalyzerService
+    internal class DiagnosticAnalyzerService : IDiagnosticAnalyzerService
     {
         private readonly Microsoft.CodeAnalysis.Diagnostics.IDiagnosticAnalyzerService _delegatee;
 
         [ImportingConstructor]
-        public FSharpDiagnosticAnalyzerService(Microsoft.CodeAnalysis.Diagnostics.IDiagnosticAnalyzerService delegatee)
+        public DiagnosticAnalyzerService(Microsoft.CodeAnalysis.Diagnostics.IDiagnosticAnalyzerService delegatee)
         {
             _delegatee = delegatee;
         }
diff --git a/src/Tools/ExternalAccess/FSharp/Editor/FSharpBraceMatcher.cs b/src/Tools/ExternalAccess/FSharp/Editor/FSharpBraceMatcher.cs
new file mode 100644
index 00000000000..81b06b35088
--- /dev/null
+++ b/src/Tools/ExternalAccess/FSharp/Editor/FSharpBraceMatcher.cs
@@ -0,0 +1,34 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading;
+using System.Threading.Tasks;
+using Microsoft.CodeAnalysis.Editor;
+
+namespace Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor
+{
+    [ExportBraceMatcher(LanguageNames.FSharp)]
+    internal class FSharpBraceMatcher : IBraceMatcher
+    {
+        private readonly IFSharpBraceMatcher _braceMatcher;
+
+        public FSharpBraceMatcher(IFSharpBraceMatcher braceMatcher)
+        {
+            _braceMatcher = braceMatcher;
+        }
+
+        public async Task<Microsoft.CodeAnalysis.Editor.BraceMatchingResult?> FindBracesAsync(Document document, int position, CancellationToken cancellationToken = default)
+        {
+            var result = await _braceMatcher.FindBracesAsync(document, position, cancellationToken).ConfigureAwait(false);
+            if (result.HasValue)
+            {
+                return new Microsoft.CodeAnalysis.Editor.BraceMatchingResult(result.Value.LeftSpan, result.Value.RightSpan);
+            }
+            else
+            {
+                return null;
+            }
+        }
+    }
+}
diff --git a/src/Tools/ExternalAccess/FSharp/Editor/IFSharpBraceMatcher.cs b/src/Tools/ExternalAccess/FSharp/Editor/IFSharpBraceMatcher.cs
new file mode 100644
index 00000000000..b26bbd8d3c5
--- /dev/null
+++ b/src/Tools/ExternalAccess/FSharp/Editor/IFSharpBraceMatcher.cs
@@ -0,0 +1,24 @@
+using System.Threading;
+using System.Threading.Tasks;
+using Microsoft.CodeAnalysis.Text;
+
+namespace Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor
+{
+    public struct BraceMatchingResult
+    {
+        public TextSpan LeftSpan { get; }
+        public TextSpan RightSpan { get; }
+
+        public BraceMatchingResult(TextSpan leftSpan, TextSpan rightSpan)
+            : this()
+        {
+            this.LeftSpan = leftSpan;
+            this.RightSpan = rightSpan;
+        }
+    }
+
+    public interface IFSharpBraceMatcher
+    {
+        Task<BraceMatchingResult?> FindBracesAsync(Document document, int position, CancellationToken cancellationToken = default);
+    }
+}
diff --git a/src/Tools/ExternalAccess/FSharp/PublicAPI.Unshipped.txt b/src/Tools/ExternalAccess/FSharp/PublicAPI.Unshipped.txt
index 35ccfe2f221..3b8a77e313b 100644
--- a/src/Tools/ExternalAccess/FSharp/PublicAPI.Unshipped.txt
+++ b/src/Tools/ExternalAccess/FSharp/PublicAPI.Unshipped.txt
@@ -3,6 +3,12 @@ Microsoft.CodeAnalysis.ExternalAccess.FSharp.Completion.CompletionOptions
 Microsoft.CodeAnalysis.ExternalAccess.FSharp.Diagnostics.DiagnosticCustomTags
 Microsoft.CodeAnalysis.ExternalAccess.FSharp.Diagnostics.IDiagnosticAnalyzerService
 Microsoft.CodeAnalysis.ExternalAccess.FSharp.Diagnostics.IDiagnosticAnalyzerService.Reanalyze(Microsoft.CodeAnalysis.Workspace workspace, System.Collections.Generic.IEnumerable<Microsoft.CodeAnalysis.ProjectId> projectIds = null, System.Collections.Generic.IEnumerable<Microsoft.CodeAnalysis.DocumentId> documentIds = null, bool highPriority = false) -> void
+Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.BraceMatchingResult
+Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.BraceMatchingResult.BraceMatchingResult(Microsoft.CodeAnalysis.Text.TextSpan leftSpan, Microsoft.CodeAnalysis.Text.TextSpan rightSpan) -> void
+Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.BraceMatchingResult.LeftSpan.get -> Microsoft.CodeAnalysis.Text.TextSpan
+Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.BraceMatchingResult.RightSpan.get -> Microsoft.CodeAnalysis.Text.TextSpan
+Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.IFSharpBraceMatcher
+Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.IFSharpBraceMatcher.FindBracesAsync(Microsoft.CodeAnalysis.Document document, int position, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task<Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.BraceMatchingResult?>
 Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.Shared.Utilities.ClassificationTypeMap
 Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.Shared.Utilities.ClassificationTypeMap.ClassificationTypeMap(Microsoft.VisualStudio.Text.Classification.IClassificationTypeRegistryService registryService) -> void
 Microsoft.CodeAnalysis.ExternalAccess.FSharp.Editor.Shared.Utilities.ClassificationTypeMap.GetClassificationType(string name) -> Microsoft.VisualStudio.Text.Classification.IClassificationType
diff --git a/src/VisualStudio/Core/Def/Microsoft.VisualStudio.LanguageServices.csproj b/src/VisualStudio/Core/Def/Microsoft.VisualStudio.LanguageServices.csproj
index 9e563a52246..fd2d614851f 100644
--- a/src/VisualStudio/Core/Def/Microsoft.VisualStudio.LanguageServices.csproj
+++ b/src/VisualStudio/Core/Def/Microsoft.VisualStudio.LanguageServices.csproj
@@ -111,6 +111,7 @@
     <InternalsVisibleTo Include="RoslynTaoActions" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.ErrorList.UnitTests" />
     <InternalsVisibleTo Include="Roslyn.VisualStudio.Next.UnitTests" />
+    <InternalsVisibleTo Include="Microsoft.CodeAnalysis.ExternalAccess.FSharp" />
     <InternalsVisibleTo Include="DynamicProxyGenAssembly2" Key="$(MoqPublicKey)" />
     <InternalsVisibleTo Include="Microsoft.CodeAnalysis.TypeScript.EditorFeatures" Key="$(TypeScriptKey)" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.TypeScript" Key="$(TypeScriptKey)" />
@@ -126,8 +127,6 @@
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.Remote.CSharp.15.7" Key="$(RemoteLanguageServiceKey)" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.Remote.CSharp.15.8" Key="$(RemoteLanguageServiceKey)" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.Remote.CSharp.16.0" Key="$(RemoteLanguageServiceKey)" />
-    <InternalsVisibleTo Include="FSharp.Editor" Key="$(FSharpKey)" />
-    <InternalsVisibleTo Include="FSharp.LanguageService" Key="$(FSharpKey)" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.Razor" Key="$(RazorKey)" />
   </ItemGroup>
   <ItemGroup>
diff --git a/src/VisualStudio/Core/Impl/Microsoft.VisualStudio.LanguageServices.Implementation.csproj b/src/VisualStudio/Core/Impl/Microsoft.VisualStudio.LanguageServices.Implementation.csproj
index b59a19a1658..831e70d1c8f 100644
--- a/src/VisualStudio/Core/Impl/Microsoft.VisualStudio.LanguageServices.Implementation.csproj
+++ b/src/VisualStudio/Core/Impl/Microsoft.VisualStudio.LanguageServices.Implementation.csproj
@@ -25,6 +25,7 @@
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.CSharp.UnitTests" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.UnitTests" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.Test.Utilities2" />
+    <InternalsVisibleTo Include="Microsoft.CodeAnalysis.ExternalAccess.FSharp" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.TypeScript" Key="$(TypeScriptKey)" />
     <InternalsVisibleTo Include="Microsoft.CodeAnalysis.TypeScript.EditorFeatures" Key="$(TypeScriptKey)" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.Remote" Key="$(RemoteLanguageServiceKey)" />
@@ -35,8 +36,6 @@
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.Remote.CSharp.15.7" Key="$(RemoteLanguageServiceKey)" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.Remote.CSharp.15.8" Key="$(RemoteLanguageServiceKey)" />
     <InternalsVisibleTo Include="Microsoft.VisualStudio.LanguageServices.Remote.CSharp.16.0" Key="$(RemoteLanguageServiceKey)" />
-    <InternalsVisibleTo Include="FSharp.Editor" Key="$(FSharpKey)" />
-    <InternalsVisibleTo Include="FSharp.LanguageService" Key="$(FSharpKey)" />
   </ItemGroup>
   <ItemGroup>
     <Reference Include="Microsoft.CSharp" />
-- 
GitLab