Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
38a4af2a
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
38a4af2a
编写于
6月 28, 2019
作者:
C
Cyrus Najmabadi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Use switch expression
上级
ad12b7f5
变更
4
显示空白变更内容
内联
并排
Showing
4 changed file
with
28 addition
and
66 deletion
+28
-66
src/VisualStudio/CSharp/Impl/CodeModel/CSharpCodeModelService.cs
...ualStudio/CSharp/Impl/CodeModel/CSharpCodeModelService.cs
+7
-14
src/Workspaces/Core/Portable/CodeStyle/CodeStyleOption.cs
src/Workspaces/Core/Portable/CodeStyle/CodeStyleOption.cs
+7
-19
src/Workspaces/Core/Portable/Diagnostics/Extensions_SharedWithCodeStyle.cs
...re/Portable/Diagnostics/Extensions_SharedWithCodeStyle.cs
+7
-18
src/Workspaces/Remote/ServiceHub/Shared/RoslynJsonConverter.RoslynOnly.cs
...emote/ServiceHub/Shared/RoslynJsonConverter.RoslynOnly.cs
+7
-15
未找到文件。
src/VisualStudio/CSharp/Impl/CodeModel/CSharpCodeModelService.cs
浏览文件 @
38a4af2a
...
...
@@ -1512,21 +1512,14 @@ public override MethodKind GetAccessorKind(SyntaxNode node)
};
private
static
SyntaxKind
GetAccessorSyntaxKind
(
MethodKind
methodKind
)
=>
methodKind
switch
{
switch
(
methodKind
)
{
case
MethodKind
.
PropertyGet
:
return
SyntaxKind
.
GetAccessorDeclaration
;
case
MethodKind
.
PropertySet
:
return
SyntaxKind
.
SetAccessorDeclaration
;
case
MethodKind
.
EventAdd
:
return
SyntaxKind
.
AddAccessorDeclaration
;
case
MethodKind
.
EventRemove
:
return
SyntaxKind
.
RemoveAccessorDeclaration
;
default
:
throw
Exceptions
.
ThrowEUnexpected
();
}
}
MethodKind
.
PropertyGet
=>
SyntaxKind
.
GetAccessorDeclaration
,
MethodKind
.
PropertySet
=>
SyntaxKind
.
SetAccessorDeclaration
,
MethodKind
.
EventAdd
=>
SyntaxKind
.
AddAccessorDeclaration
,
MethodKind
.
EventRemove
=>
SyntaxKind
.
RemoveAccessorDeclaration
,
_
=>
throw
Exceptions
.
ThrowEUnexpected
(),
};
public
override
bool
TryGetAccessorNode
(
SyntaxNode
parentNode
,
MethodKind
kind
,
out
SyntaxNode
accessorNode
)
{
...
...
src/Workspaces/Core/Portable/CodeStyle/CodeStyleOption.cs
浏览文件 @
38a4af2a
...
...
@@ -121,26 +121,14 @@ public static CodeStyleOption<T> FromXElement(XElement element)
var
value
=
parser
(
valueAttribute
.
Value
);
var
severity
=
(
DiagnosticSeverity
)
Enum
.
Parse
(
typeof
(
DiagnosticSeverity
),
severityAttribute
.
Value
);
NotificationOption
notificationOption
;
switch
(
severity
)
{
case
DiagnosticSeverity
.
Hidden
:
notificationOption
=
NotificationOption
.
Silent
;
break
;
case
DiagnosticSeverity
.
Info
:
notificationOption
=
NotificationOption
.
Suggestion
;
break
;
case
DiagnosticSeverity
.
Warning
:
notificationOption
=
NotificationOption
.
Warning
;
break
;
case
DiagnosticSeverity
.
Error
:
notificationOption
=
NotificationOption
.
Error
;
break
;
default
:
throw
new
ArgumentException
(
nameof
(
element
));
}
return
new
CodeStyleOption
<
T
>(
value
,
notificationOption
);
return
new
CodeStyleOption
<
T
>(
value
,
severity
switch
{
DiagnosticSeverity
.
Hidden
=>
NotificationOption
.
Silent
,
DiagnosticSeverity
.
Info
=>
NotificationOption
.
Suggestion
,
DiagnosticSeverity
.
Warning
=>
NotificationOption
.
Warning
,
DiagnosticSeverity
.
Error
=>
NotificationOption
.
Error
,
_
=>
throw
new
ArgumentException
(
nameof
(
element
)),
});
}
private
static
Func
<
string
,
T
>
GetParser
(
string
type
)
...
...
src/Workspaces/Core/Portable/Diagnostics/Extensions_SharedWithCodeStyle.cs
浏览文件 @
38a4af2a
...
...
@@ -76,24 +76,13 @@ public static ReportDiagnostic WithDefaultSeverity(this ReportDiagnostic reportD
/// If <paramref name="diagnosticSeverity"/> is not one of the expected values.
/// </exception>
public
static
ReportDiagnostic
ToReportDiagnostic
(
this
DiagnosticSeverity
diagnosticSeverity
)
=>
diagnosticSeverity
switch
{
switch
(
diagnosticSeverity
)
{
case
DiagnosticSeverity
.
Hidden
:
return
ReportDiagnostic
.
Hidden
;
case
DiagnosticSeverity
.
Info
:
return
ReportDiagnostic
.
Info
;
case
DiagnosticSeverity
.
Warning
:
return
ReportDiagnostic
.
Warn
;
case
DiagnosticSeverity
.
Error
:
return
ReportDiagnostic
.
Error
;
default
:
throw
ExceptionUtilities
.
UnexpectedValue
(
diagnosticSeverity
);
}
}
DiagnosticSeverity
.
Hidden
=>
ReportDiagnostic
.
Hidden
,
DiagnosticSeverity
.
Info
=>
ReportDiagnostic
.
Info
,
DiagnosticSeverity
.
Warning
=>
ReportDiagnostic
.
Warn
,
DiagnosticSeverity
.
Error
=>
ReportDiagnostic
.
Error
,
_
=>
throw
ExceptionUtilities
.
UnexpectedValue
(
diagnosticSeverity
),
};
}
}
src/Workspaces/Remote/ServiceHub/Shared/RoslynJsonConverter.RoslynOnly.cs
浏览文件 @
38a4af2a
...
...
@@ -357,22 +357,14 @@ protected override AddImportFixData ReadValue(JsonReader reader, JsonSerializer
Contract
.
ThrowIfFalse
(
reader
.
Read
());
Contract
.
ThrowIfFalse
(
reader
.
TokenType
==
JsonToken
.
EndObject
);
switch
(
kind
)
{
case
AddImportFixKind
.
ProjectSymbol
:
return
AddImportFixData
.
CreateForProjectSymbol
(
textChanges
,
title
,
tags
,
priority
,
projectReferenceToAdd
);
case
AddImportFixKind
.
MetadataSymbol
:
return
AddImportFixData
.
CreateForMetadataSymbol
(
textChanges
,
title
,
tags
,
priority
,
portableExecutableReferenceProjectId
,
portableExecutableReferenceFilePathToAdd
);
case
AddImportFixKind
.
PackageSymbol
:
return
AddImportFixData
.
CreateForPackageSymbol
(
textChanges
,
packageSource
,
packageName
,
packageVersionOpt
);
case
AddImportFixKind
.
ReferenceAssemblySymbol
:
return
AddImportFixData
.
CreateForReferenceAssemblySymbol
(
textChanges
,
title
,
assemblyReferenceAssemblyName
,
assemblyReferenceFullyQualifiedTypeName
);
}
throw
ExceptionUtilities
.
Unreachable
;
return
kind
switch
{
AddImportFixKind
.
ProjectSymbol
=>
AddImportFixData
.
CreateForProjectSymbol
(
textChanges
,
title
,
tags
,
priority
,
projectReferenceToAdd
),
AddImportFixKind
.
MetadataSymbol
=>
AddImportFixData
.
CreateForMetadataSymbol
(
textChanges
,
title
,
tags
,
priority
,
portableExecutableReferenceProjectId
,
portableExecutableReferenceFilePathToAdd
),
AddImportFixKind
.
PackageSymbol
=>
AddImportFixData
.
CreateForPackageSymbol
(
textChanges
,
packageSource
,
packageName
,
packageVersionOpt
),
AddImportFixKind
.
ReferenceAssemblySymbol
=>
AddImportFixData
.
CreateForReferenceAssemblySymbol
(
textChanges
,
title
,
assemblyReferenceAssemblyName
,
assemblyReferenceFullyQualifiedTypeName
),
_
=>
throw
ExceptionUtilities
.
Unreachable
,
};
}
protected
override
void
WriteValue
(
JsonWriter
writer
,
AddImportFixData
source
,
JsonSerializer
serializer
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录