From 382f453185baaed7d8b3e6ef8c0d5a22c599375f Mon Sep 17 00:00:00 2001 From: Manish Vasani Date: Fri, 1 Nov 2019 13:55:13 -0700 Subject: [PATCH] Address feedback --- .../AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs | 3 +-- .../Def/Implementation/ProjectSystem/VisualStudioProject.cs | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Features/Core/Portable/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs b/src/Features/Core/Portable/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs index e2e1f84b73f..4cafa92f1a1 100644 --- a/src/Features/Core/Portable/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs +++ b/src/Features/Core/Portable/RemoveUnnecessaryImports/AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer.cs @@ -23,10 +23,9 @@ internal abstract class AbstractRemoveUnnecessaryImportsDiagnosticAnalyzer // The NotConfigurable custom tag ensures that user can't turn this diagnostic into a warning / error via // ruleset editor or solution explorer. Setting messageFormat to empty string ensures that we won't display // this diagnostic in the preview pane header. - // Setting category to "Compiler" ensures we always run this analyzer even when user has turned off analyzer execution for the project. private static readonly DiagnosticDescriptor s_fixableIdDescriptor = new DiagnosticDescriptor(DiagnosticFixableId, - title: "", messageFormat: "", category: DiagnosticCategory.Compiler, + title: "", messageFormat: "", category: "", defaultSeverity: DiagnosticSeverity.Hidden, isEnabledByDefault: true, customTags: WellKnownDiagnosticTags.NotConfigurable); diff --git a/src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioProject.cs b/src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioProject.cs index 744869faaa1..14f0776c052 100644 --- a/src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioProject.cs +++ b/src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioProject.cs @@ -63,7 +63,8 @@ internal sealed class VisualStudioProject // Actual property values for 'RunAnalyzers' and 'RunAnalyzersDuringLiveAnalysis' properties from the project file. // Both these properties can be used to configure running analyzers, with RunAnalyzers overriding RunAnalyzersDuringLiveAnalysis. - private bool? _runAnalyzersPropertyValue, _runAnalyzersDuringLiveAnalysisPropertyValue; + private bool? _runAnalyzersPropertyValue; + private bool? _runAnalyzersDuringLiveAnalysisPropertyValue; // Effective boolean value to determine if analyzers should be executed based on _runAnalyzersPropertyValue and _runAnalyzersDuringLiveAnalysisPropertyValue. private bool _runAnalyzers = true; -- GitLab