From 37da9a1541c749094fae2bfca20d49f42953c18b Mon Sep 17 00:00:00 2001 From: Sam Harwell Date: Fri, 9 Nov 2018 11:10:35 -0600 Subject: [PATCH] Remove the single-dispose requirement for DisposableToolTip --- src/EditorFeatures/Core.Wpf/QuickInfo/DisposableToolTip.cs | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/EditorFeatures/Core.Wpf/QuickInfo/DisposableToolTip.cs b/src/EditorFeatures/Core.Wpf/QuickInfo/DisposableToolTip.cs index 9ddf17de658..a71c9469358 100644 --- a/src/EditorFeatures/Core.Wpf/QuickInfo/DisposableToolTip.cs +++ b/src/EditorFeatures/Core.Wpf/QuickInfo/DisposableToolTip.cs @@ -13,8 +13,6 @@ internal sealed class DisposableToolTip : IDisposable public readonly ToolTip ToolTip; private PreviewWorkspace _workspaceOpt; - private bool _disposed; - public DisposableToolTip(ToolTip toolTip, PreviewWorkspace workspaceOpt) { ToolTip = toolTip; @@ -23,10 +21,7 @@ public DisposableToolTip(ToolTip toolTip, PreviewWorkspace workspaceOpt) public void Dispose() { - Debug.Assert(!_disposed); - _disposed = true; - _workspaceOpt?.Dispose(); - _workspaceOpt = null; + Interlocked.Exchange(ref _workspaceOpt, null)?.Dispose(); } } } -- GitLab