From 3269cebe79465d530c1c02f4a7dc4a7599d6e84a Mon Sep 17 00:00:00 2001 From: Heejae Chang Date: Fri, 8 Sep 2017 13:27:18 -0700 Subject: [PATCH] address PR feedbacks. --- .../codeAnalysisService64.servicehub.service.json | 2 +- .../Setup.Next/remoteHostService64.servicehub.service.json | 2 +- ...remoteSymbolSearchUpdateEngine64.servicehub.service.json | 2 +- .../Setup.Next/snapshotService64.servicehub.service.json | 2 +- .../ServiceHub/Services/CodeAnalysisService_Diagnostics.cs | 6 +----- 5 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/VisualStudio/Setup.Next/codeAnalysisService64.servicehub.service.json b/src/VisualStudio/Setup.Next/codeAnalysisService64.servicehub.service.json index 92d07291882..5901a5bf5e8 100644 --- a/src/VisualStudio/Setup.Next/codeAnalysisService64.servicehub.service.json +++ b/src/VisualStudio/Setup.Next/codeAnalysisService64.servicehub.service.json @@ -1,6 +1,6 @@ { "host": "desktopClr", - "hostId": "RoslynCodeAnalysisService64", + "hostId": "RoslynCodeAnalysisService", "hostGroupAllowed": true, "entryPoint": { "assemblyPath": "Microsoft.CodeAnalysis.Remote.ServiceHub.dll", diff --git a/src/VisualStudio/Setup.Next/remoteHostService64.servicehub.service.json b/src/VisualStudio/Setup.Next/remoteHostService64.servicehub.service.json index bf8ae0ea7a9..0b436bfef50 100644 --- a/src/VisualStudio/Setup.Next/remoteHostService64.servicehub.service.json +++ b/src/VisualStudio/Setup.Next/remoteHostService64.servicehub.service.json @@ -1,6 +1,6 @@ { "host": "desktopClr", - "hostId": "RoslynCodeAnalysisService64", + "hostId": "RoslynCodeAnalysisService", "hostGroupAllowed": true, "entryPoint": { "assemblyPath": "Microsoft.CodeAnalysis.Remote.ServiceHub.dll", diff --git a/src/VisualStudio/Setup.Next/remoteSymbolSearchUpdateEngine64.servicehub.service.json b/src/VisualStudio/Setup.Next/remoteSymbolSearchUpdateEngine64.servicehub.service.json index 67cc5e2b046..99b3dca9b43 100644 --- a/src/VisualStudio/Setup.Next/remoteSymbolSearchUpdateEngine64.servicehub.service.json +++ b/src/VisualStudio/Setup.Next/remoteSymbolSearchUpdateEngine64.servicehub.service.json @@ -1,6 +1,6 @@ { "host": "desktopClr", - "hostId": "RoslynCodeAnalysisService64", + "hostId": "RoslynCodeAnalysisService", "hostGroupAllowed": true, "entryPoint": { "assemblyPath": "Microsoft.CodeAnalysis.Remote.ServiceHub.dll", diff --git a/src/VisualStudio/Setup.Next/snapshotService64.servicehub.service.json b/src/VisualStudio/Setup.Next/snapshotService64.servicehub.service.json index a9aaeef43d7..8975e0b2cf6 100644 --- a/src/VisualStudio/Setup.Next/snapshotService64.servicehub.service.json +++ b/src/VisualStudio/Setup.Next/snapshotService64.servicehub.service.json @@ -1,6 +1,6 @@ { "host": "desktopClr", - "hostId": "RoslynCodeAnalysisService64", + "hostId": "RoslynCodeAnalysisService", "hostGroupAllowed": true, "entryPoint": { "assemblyPath": "Microsoft.CodeAnalysis.Remote.ServiceHub.dll", diff --git a/src/Workspaces/Remote/ServiceHub/Services/CodeAnalysisService_Diagnostics.cs b/src/Workspaces/Remote/ServiceHub/Services/CodeAnalysisService_Diagnostics.cs index f1ac53f0a46..b869caa5a82 100644 --- a/src/Workspaces/Remote/ServiceHub/Services/CodeAnalysisService_Diagnostics.cs +++ b/src/Workspaces/Remote/ServiceHub/Services/CodeAnalysisService_Diagnostics.cs @@ -54,10 +54,8 @@ public Task CalculateDiagnosticsAsync(DiagnosticArguments arguments, string stre }, cancellationToken); } - private async Task SerializeDiagnosticResultAsync(string streamName, DiagnosticAnalysisResultMap result, CancellationToken cancellationToken) + private async Task SerializeDiagnosticResultAsync(string streamName, DiagnosticAnalysisResultMap result, CancellationToken cancellationToken) { - var count = 0; - using (RoslynLogger.LogBlock(FunctionId.CodeAnalysisService_SerializeDiagnosticResultAsync, GetResultLogInfo, result, cancellationToken)) using (var stream = await DirectStream.GetAsync(streamName, cancellationToken).ConfigureAwait(false)) { @@ -72,8 +70,6 @@ private async Task SerializeDiagnosticResultAsync(string streamName, Diagno await stream.FlushAsync(cancellationToken).ConfigureAwait(false); } - - return count; } private static string GetResultLogInfo(DiagnosticAnalysisResultMap result) -- GitLab