Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
2da7f5b9
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
2da7f5b9
编写于
11月 04, 2016
作者:
C
CyrusNajmabadi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Simpler implementation.
上级
f515ef87
变更
1
显示空白变更内容
内联
并排
Showing
1 changed file
with
16 addition
and
37 deletion
+16
-37
src/Features/Core/Portable/UseThrowExpression/AbstractUseThrowExpressionDiagnosticAnalyzer.cs
...xpression/AbstractUseThrowExpressionDiagnosticAnalyzer.cs
+16
-37
未找到文件。
src/Features/Core/Portable/UseThrowExpression/AbstractUseThrowExpressionDiagnosticAnalyzer.cs
浏览文件 @
2da7f5b9
...
...
@@ -114,19 +114,25 @@ private void AnalyzeOperation(OperationAnalysisContext context)
}
// We found an assignment using this local/parameter. Now, just make sure there
// were no intervening writes between the check and the assignement.
var
dataFlow
=
semanticModel
.
AnalyzeDataFlow
(
ifOperation
.
Syntax
,
expressionStatement
.
Syntax
);
// were no intervening accesses between the check and the assignment.
var
statements
=
containingBlock
.
Statements
;
var
ifOperationIndex
=
statements
.
IndexOf
(
ifOperation
);
var
expressionStatementIndex
=
statements
.
IndexOf
(
expressionStatement
);
if
(
dataFlow
.
WrittenInside
.
Contains
(
localOrParameter
)
)
if
(
expressionStatementIndex
>
ifOperationIndex
+
1
)
{
return
;
}
// There are intermediary statements between the check and the assignment.
// Make sure they don't try to access the local.
var
dataFlow
=
semanticModel
.
AnalyzeDataFlow
(
statements
[
ifOperationIndex
+
1
].
Syntax
,
statements
[
expressionStatementIndex
-
1
].
Syntax
);
if
(
ContainsMemberAccess
(
containingBlock
,
ifOperation
,
expressionStatement
,
localOrParameter
))
if
(
dataFlow
.
ReadInside
.
Contains
(
localOrParameter
)
||
dataFlow
.
WrittenInside
.
Contains
(
localOrParameter
))
{
return
;
}
}
// Ok, there were no intervening writes or accesses. This check+assignment can be simplified.
...
...
@@ -162,33 +168,6 @@ private void AnalyzeOperation(OperationAnalysisContext context)
}
}
private
bool
ContainsMemberAccess
(
IBlockStatement
containingBlock
,
IIfStatement
ifOperation
,
IExpressionStatement
expressionStatement
,
ISymbol
localOrParameter
)
{
var
syntaxFacts
=
this
.
GetSyntaxFactsService
();
var
ifIndex
=
containingBlock
.
Statements
.
IndexOf
(
ifOperation
);
var
expressionStatementIndex
=
containingBlock
.
Statements
.
IndexOf
(
expressionStatement
);
for
(
var
i
=
ifIndex
+
1
;
i
<=
expressionStatementIndex
;
i
++)
{
var
currentStatement
=
containingBlock
.
Statements
[
i
];
var
statementSyntax
=
currentStatement
.
Syntax
;
foreach
(
var
token
in
statementSyntax
.
DescendantTokens
())
{
if
(
syntaxFacts
.
IsIdentifier
(
token
)
&&
syntaxFacts
.
IsExpressionOfMemberAccessExpression
(
token
.
Parent
)
&&
token
.
ValueText
==
localOrParameter
.
Name
)
{
return
true
;
}
}
}
return
false
;
}
protected
abstract
ISyntaxFactsService
GetSyntaxFactsService
();
private
bool
TryFindAssignmentExpression
(
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录