Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
lwm1986
roslyn
提交
2930a6b2
R
roslyn
项目概览
lwm1986
/
roslyn
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
roslyn
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
2930a6b2
编写于
7月 24, 2017
作者:
K
Kevin Pilch
提交者:
GitHub
7月 24, 2017
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #20882 from zaytsev-victor/Fixed18396
Fixed Make Method Asynchronous refactoring.
上级
d501422a
aaf8ce24
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
18 addition
and
16 deletion
+18
-16
src/EditorFeatures/CSharpTest/Diagnostics/MakeMethodAsynchronous/MakeMethodAsynchronousTests.cs
...ics/MakeMethodAsynchronous/MakeMethodAsynchronousTests.cs
+16
-14
src/Features/CSharp/Portable/MakeMethodAsynchronous/CSharpMakeMethodAsynchronousCodeFixProvider.cs
...ynchronous/CSharpMakeMethodAsynchronousCodeFixProvider.cs
+2
-2
未找到文件。
src/EditorFeatures/CSharpTest/Diagnostics/MakeMethodAsynchronous/MakeMethodAsynchronousTests.cs
浏览文件 @
2930a6b2
...
...
@@ -684,31 +684,33 @@ async Task<int> M3Async()
}
[
Theory
]
[
InlineData
(
0
,
"Task"
)]
[
InlineData
(
1
,
"void"
,
Skip
=
"https://github.com/dotnet/roslyn/issues/18396"
)]
[
InlineData
(
0
,
"void"
,
"Task"
)]
[
InlineData
(
1
,
"void"
,
"void"
)]
[
InlineData
(
0
,
"int"
,
"Task<int>"
)]
[
InlineData
(
0
,
"Task"
,
"Task"
)]
[
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsMakeMethodAsynchronous
)]
[
WorkItem
(
18307
,
"https://github.com/dotnet/roslyn/issues/18307"
)]
public
async
Task
AddAsyncInLocalFunctionKeepsTrivia
(
int
codeFixIndex
,
string
expectedReturn
)
public
async
Task
AddAsyncInLocalFunctionKeepsTrivia
(
int
codeFixIndex
,
string
initialReturn
,
string
expectedReturn
)
{
await
TestInRegularAndScriptAsync
(
@"using System.Threading.Tasks;
$
@"using System.Threading.Tasks;
class C
{
{
{
public
void
M1
()
{
{
{
// Leading trivia
/*1*/
void
/*2*/ M2/*3*/() /*4*/
{
/*1*/
{
initialReturn
}
/*2*/
M2
/*3*/
()
/*4*/
{
{
[|
await
M3Async
();|]
}
}
}
}
}
}
async
Task
<
int
>
M3Async
()
{
{
{
return
1
;
}
}"
,
}
}
}
}
"
,
$@"using System.Threading.Tasks;
class C
...
...
@@ -733,7 +735,7 @@ async Task<int> M3Async()
[
Theory
]
[
InlineData
(
""
,
0
,
"Task"
)]
[
InlineData
(
""
,
1
,
"void"
,
Skip
=
"https://github.com/dotnet/roslyn/issues/18396"
)]
[
InlineData
(
""
,
1
,
"void"
)]
[
InlineData
(
"public"
,
0
,
"Task"
)]
[
InlineData
(
"public"
,
1
,
"void"
)]
[
Trait
(
Traits
.
Feature
,
Traits
.
Features
.
CodeActionsMakeMethodAsynchronous
)]
...
...
src/Features/CSharp/Portable/MakeMethodAsynchronous/CSharpMakeMethodAsynchronousCodeFixProvider.cs
浏览文件 @
2930a6b2
// Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using
System
;
using
System.Collections.Immutable
;
using
System.Composition
;
using
Microsoft.CodeAnalysis.CodeFixes
;
using
Microsoft.CodeAnalysis.CSharp.Extensions
;
using
Microsoft.CodeAnalysis.CSharp.Syntax
;
using
Microsoft.CodeAnalysis.Formatting
;
using
Microsoft.CodeAnalysis.MakeMethodAsynchronous
;
using
Microsoft.CodeAnalysis.Shared.Extensions
;
...
...
@@ -73,7 +73,7 @@ protected override bool IsAsyncSupportingFunctionSyntax(SyntaxNode node)
bool
keepVoid
,
IMethodSymbol
methodSymbol
,
TypeSyntax
returnType
,
INamedTypeSymbol
taskType
,
INamedTypeSymbol
taskOfTType
,
INamedTypeSymbol
valueTaskOfTType
)
{
var
newReturnType
=
returnType
;
var
newReturnType
=
returnType
.
WithAdditionalAnnotations
(
Formatter
.
Annotation
)
;
if
(
methodSymbol
.
ReturnsVoid
)
{
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录