From 2804b61f4e84864399fb7074752d7e04c0a2720d Mon Sep 17 00:00:00 2001 From: jasonmalinowski Date: Thu, 18 Dec 2014 13:36:49 -0800 Subject: [PATCH] Correctly specify the text and description for the verbatim crefs analyzer. (changeset 1388971) --- .../Documentation/DoNotUseVerbatimCrefsAnalyzer.cs | 11 ++++++----- .../Core/RoslynDiagnosticsResources.Designer.cs | 9 +++++++++ .../Roslyn/Core/RoslynDiagnosticsResources.resx | 3 +++ 3 files changed, 18 insertions(+), 5 deletions(-) diff --git a/Src/Diagnostics/Roslyn/Core/Documentation/DoNotUseVerbatimCrefsAnalyzer.cs b/Src/Diagnostics/Roslyn/Core/Documentation/DoNotUseVerbatimCrefsAnalyzer.cs index 24d9a0cee38..b4f9f8d0990 100644 --- a/Src/Diagnostics/Roslyn/Core/Documentation/DoNotUseVerbatimCrefsAnalyzer.cs +++ b/Src/Diagnostics/Roslyn/Core/Documentation/DoNotUseVerbatimCrefsAnalyzer.cs @@ -13,12 +13,13 @@ public abstract class DoNotUseVerbatimCrefsAnalyzer : DiagnosticAnalyzer { internal static DiagnosticDescriptor Rule = new DiagnosticDescriptor( RoslynDiagnosticIds.DoNotUseVerbatimCrefsRuleId, - RoslynDiagnosticsResources.UseProperCrefTagsDescription, - RoslynDiagnosticsResources.UseProperCrefTagsMessage, - "Documentation", - DiagnosticSeverity.Warning, + title: RoslynDiagnosticsResources.UseProperCrefTagsTitle, + messageFormat: RoslynDiagnosticsResources.UseProperCrefTagsMessage, + category: "Documentation", + defaultSeverity: DiagnosticSeverity.Warning, isEnabledByDefault: true, - customTags: WellKnownDiagnosticTags.Telemetry); + customTags: WellKnownDiagnosticTags.Telemetry, + description: RoslynDiagnosticsResources.UseProperCrefTagsDescription); public override ImmutableArray SupportedDiagnostics { diff --git a/Src/Diagnostics/Roslyn/Core/RoslynDiagnosticsResources.Designer.cs b/Src/Diagnostics/Roslyn/Core/RoslynDiagnosticsResources.Designer.cs index 3e925d729c0..37e41f13015 100644 --- a/Src/Diagnostics/Roslyn/Core/RoslynDiagnosticsResources.Designer.cs +++ b/Src/Diagnostics/Roslyn/Core/RoslynDiagnosticsResources.Designer.cs @@ -294,6 +294,15 @@ internal class RoslynDiagnosticsResources { } } + /// + /// Looks up a localized string similar to Avoid using cref tags with a prefix. + /// + internal static string UseProperCrefTagsTitle { + get { + return ResourceManager.GetString("UseProperCrefTagsTitle", resourceCulture); + } + } + /// /// Looks up a localized string similar to Use SpecializedCollections.SingletonEnumerable<T>(). /// diff --git a/Src/Diagnostics/Roslyn/Core/RoslynDiagnosticsResources.resx b/Src/Diagnostics/Roslyn/Core/RoslynDiagnosticsResources.resx index 1b214b4e17c..4321cabec99 100644 --- a/Src/Diagnostics/Roslyn/Core/RoslynDiagnosticsResources.resx +++ b/Src/Diagnostics/Roslyn/Core/RoslynDiagnosticsResources.resx @@ -207,4 +207,7 @@ This collection is directly indexable. Going through LINQ here causes unnecessary allocations and CPU work. + + Avoid using cref tags with a prefix + \ No newline at end of file -- GitLab