From 220e76502d82a46f180c09da222a3c8bd16fa739 Mon Sep 17 00:00:00 2001
From: Basoundr_ms <basoundr@microsoft.com>
Date: Wed, 17 Dec 2014 10:37:42 -0800
Subject: [PATCH] Bugfix 1094427. Fix flaky Testcase.

Call WithDocumentText when fed with the same text sometimes doesn't return the same instance of the Document because TextSource, a WeakReference, sometimes loses the reference and the perf optimization to return the same instance of the Document is not possbile. (changeset 1387876)
---
 .../CodeCleanup/Providers/FormatCodeCleanupProvider.cs    | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Src/Workspaces/Core/Portable/CodeCleanup/Providers/FormatCodeCleanupProvider.cs b/Src/Workspaces/Core/Portable/CodeCleanup/Providers/FormatCodeCleanupProvider.cs
index 6d245178b68..eec1bd19ecd 100644
--- a/Src/Workspaces/Core/Portable/CodeCleanup/Providers/FormatCodeCleanupProvider.cs
+++ b/Src/Workspaces/Core/Portable/CodeCleanup/Providers/FormatCodeCleanupProvider.cs
@@ -22,7 +22,13 @@ public async Task<Document> CleanupAsync(Document document, IEnumerable<TextSpan
             if (document.TryGetText(out oldText))
             {
                 var root = await document.GetSyntaxRootAsync(cancellationToken).ConfigureAwait(false);
-                var newText = oldText.WithChanges(Formatter.GetFormattedTextChanges(root, spans, document.Project.Solution.Workspace, cancellationToken: cancellationToken));
+                var textChanges = Formatter.GetFormattedTextChanges(root, spans, document.Project.Solution.Workspace, cancellationToken: cancellationToken);
+                if (textChanges.Count == 0)
+                {
+                    return document;
+                }
+
+                var newText = oldText.WithChanges(textChanges);
                 return document.WithText(newText);
             }
 
-- 
GitLab