diff --git a/src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_IBinaryOperatorExpression.cs b/src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_IBinaryOperatorExpression.cs index dafeda5eb8912d88359fbd397b2b9eb02409aae3..8a3e120b593ab816e3f3c6cc2b26ce068f81325d 100644 --- a/src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_IBinaryOperatorExpression.cs +++ b/src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_IBinaryOperatorExpression.cs @@ -7937,7 +7937,7 @@ void M(int arg) Operand: ILiteralOperation (OperationKind.Literal, Type: System.Int32, Constant: 0) (Syntax: '0') RightOperand: - IFromEndIndexOperation (OperationKind.FromEndIndex, Type: System.Index) (Syntax: '^1') + IFromEndIndexOperation (OperationKind.None, Type: System.Index) (Syntax: '^1') Operand: ILiteralOperation (OperationKind.Literal, Type: System.Int32, Constant: 1) (Syntax: '1') "; @@ -8079,7 +8079,7 @@ void M(int? start, int? end) Operand: IParameterReferenceOperation: start (OperationKind.ParameterReference, Type: System.Int32?) (Syntax: 'start') RightOperand: - IFromEndIndexOperation (IsLifted) (OperationKind.FromEndIndex, Type: System.Index?) (Syntax: '^end') + IFromEndIndexOperation (IsLifted) (OperationKind.None, Type: System.Index?) (Syntax: '^end') Operand: IParameterReferenceOperation: end (OperationKind.ParameterReference, Type: System.Int32?) (Syntax: 'end') "; diff --git a/src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_IFromEndIndexOperation_IRangeOperation.cs b/src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_IFromEndIndexOperation_IRangeOperation.cs index bf02685e21dfead152d85303e2e451ac6f98eefa..c4e16d2743c6da615cb13fbf9081777a43e74ab7 100644 --- a/src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_IFromEndIndexOperation_IRangeOperation.cs +++ b/src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_IFromEndIndexOperation_IRangeOperation.cs @@ -34,7 +34,7 @@ void M(int arg) IVariableDeclaratorOperation (Symbol: System.Index x) (OperationKind.VariableDeclarator, Type: null) (Syntax: 'x = ^arg') Initializer: IVariableInitializerOperation (OperationKind.VariableInitializer, Type: null) (Syntax: '= ^arg') - IFromEndIndexOperation (OperationKind.FromEndIndex, Type: System.Index) (Syntax: '^arg') + IFromEndIndexOperation (OperationKind.None, Type: System.Index) (Syntax: '^arg') Operand: IParameterReferenceOperation: arg (OperationKind.ParameterReference, Type: System.Int32) (Syntax: 'arg') Initializer: @@ -60,7 +60,7 @@ void M(int arg) Left: ILocalReferenceOperation: x (IsDeclaration: True) (OperationKind.LocalReference, Type: System.Index, IsImplicit) (Syntax: 'x = ^arg') Right: - IFromEndIndexOperation (OperationKind.FromEndIndex, Type: System.Index) (Syntax: '^arg') + IFromEndIndexOperation (OperationKind.None, Type: System.Index) (Syntax: '^arg') Operand: IParameterReferenceOperation: arg (OperationKind.ParameterReference, Type: System.Int32) (Syntax: 'arg') diff --git a/src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_IUnaryOperatorExpression.cs b/src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_IUnaryOperatorExpression.cs index a4e779c35a3ed2432dc24ccddeaeff6bda307f66..76efa2a88304b67584affe5e65cc5432e10d2b7f 100644 --- a/src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_IUnaryOperatorExpression.cs +++ b/src/Compilers/CSharp/Test/IOperation/IOperation/IOperationTests_IUnaryOperatorExpression.cs @@ -3629,7 +3629,7 @@ void M(int arg) }").VerifyDiagnostics(); string expectedOperationTree = @" -IFromEndIndexOperation (OperationKind.FromEndIndex, Type: System.Index) (Syntax: '^arg') +IFromEndIndexOperation (OperationKind.None, Type: System.Index) (Syntax: '^arg') Operand: IParameterReferenceOperation: arg (OperationKind.ParameterReference, Type: System.Int32) (Syntax: 'arg') "; @@ -3652,7 +3652,7 @@ void M(int? arg) }").VerifyDiagnostics(); string expectedOperationTree = @" -IFromEndIndexOperation (IsLifted) (OperationKind.FromEndIndex, Type: System.Index?) (Syntax: '^arg') +IFromEndIndexOperation (IsLifted) (OperationKind.None, Type: System.Index?) (Syntax: '^arg') Operand: IParameterReferenceOperation: arg (OperationKind.ParameterReference, Type: System.Int32?) (Syntax: 'arg') "; @@ -3675,7 +3675,7 @@ void M(byte arg) }").VerifyDiagnostics(); string expectedOperationTree = @" -IFromEndIndexOperation (OperationKind.FromEndIndex, Type: System.Index) (Syntax: '^arg') +IFromEndIndexOperation (OperationKind.None, Type: System.Index) (Syntax: '^arg') Operand: IConversionOperation (TryCast: False, Unchecked) (OperationKind.Conversion, Type: System.Int32, IsImplicit) (Syntax: 'arg') Conversion: CommonConversion (Exists: True, IsIdentity: False, IsNumeric: True, IsReference: False, IsUserDefined: False) (MethodSymbol: null) diff --git a/src/Compilers/Core/Portable/Operations/ControlFlowGraphBuilder.cs b/src/Compilers/Core/Portable/Operations/ControlFlowGraphBuilder.cs index 30ca52b09e5a6b56c342384489705267967b982e..4267cef0a963714a6f40274fd333468451d4d3fe 100644 --- a/src/Compilers/Core/Portable/Operations/ControlFlowGraphBuilder.cs +++ b/src/Compilers/Core/Portable/Operations/ControlFlowGraphBuilder.cs @@ -6567,7 +6567,7 @@ public override IOperation VisitDelegateCreation(IDelegateCreationOperation oper operation.Syntax, operation.Type, operation.ConstantValue, IsImplicit(operation)); } - public override IOperation VisitFromEndIndexOperation(IFromEndIndexOperation operation, int? argument) + internal override IOperation VisitFromEndIndexOperation(IFromEndIndexOperation operation, int? argument) { return new FromEndIndexOperation(operation.IsLifted, semanticModel: null, operation.Syntax, operation.Type, Visit(operation.Operand), operation.Symbol, isImplicit: IsImplicit(operation)); } diff --git a/src/Compilers/Core/Portable/Operations/IIndexOperation.cs b/src/Compilers/Core/Portable/Operations/IIndexOperation.cs index 4b6d32bb77e475c77ced887006dd2f71c0dfc42e..c6dd0b8c42515e9c1e9c05be3c1945a06f51cd6c 100644 --- a/src/Compilers/Core/Portable/Operations/IIndexOperation.cs +++ b/src/Compilers/Core/Portable/Operations/IIndexOperation.cs @@ -12,7 +12,7 @@ namespace Microsoft.CodeAnalysis.Operations /// /// This interface is reserved for implementation by its associated APIs. We reserve the right to change it in the future. /// - public interface IFromEndIndexOperation : IOperation + internal interface IFromEndIndexOperation : IOperation { /// /// The operand. diff --git a/src/Compilers/Core/Portable/Operations/OperationCloner.cs b/src/Compilers/Core/Portable/Operations/OperationCloner.cs index 5a8374af986e76dde04f49af557f592e5e636d4e..0f98044ed2b5eb81cd57c7795615105f0761ce2d 100644 --- a/src/Compilers/Core/Portable/Operations/OperationCloner.cs +++ b/src/Compilers/Core/Portable/Operations/OperationCloner.cs @@ -625,7 +625,7 @@ public override IOperation VisitStaticLocalInitializationSemaphore(IStaticLocalI throw ExceptionUtilities.Unreachable; } - public override IOperation VisitFromEndIndexOperation(IFromEndIndexOperation operation, object argument) + internal override IOperation VisitFromEndIndexOperation(IFromEndIndexOperation operation, object argument) { return new FromEndIndexOperation(operation.IsLifted, ((Operation)operation).OwningSemanticModel, operation.Syntax, operation.Type, Visit(operation.Operand), operation.Symbol, operation.IsImplicit); } diff --git a/src/Compilers/Core/Portable/Operations/OperationKind.cs b/src/Compilers/Core/Portable/Operations/OperationKind.cs index f7dbd3839904f2ad8eb58a1eef44d8ed6d7a904e..49985ee703719f70092535beebec36955170b0cd 100644 --- a/src/Compilers/Core/Portable/Operations/OperationKind.cs +++ b/src/Compilers/Core/Portable/Operations/OperationKind.cs @@ -227,8 +227,8 @@ public enum OperationKind /// Indicates an . Range = 0x63, - /// Indicates an . - FromEndIndex = 0x64, + // Unused, FromEndIndex will be a unary operator: https://github.com/dotnet/roslyn/pull/32918 + //FromEndIndex = 0x64, /// Indicates an . ReDim = 0x65, /// Indicates an . diff --git a/src/Compilers/Core/Portable/Operations/OperationNodes.cs b/src/Compilers/Core/Portable/Operations/OperationNodes.cs index e3c659211f8cabd62bc6c6c7e263db3498d4933d..0df809fca8432817a3fb7dac24a1221d05282666 100644 --- a/src/Compilers/Core/Portable/Operations/OperationNodes.cs +++ b/src/Compilers/Core/Portable/Operations/OperationNodes.cs @@ -9401,7 +9401,7 @@ public override IObjectOrCollectionInitializerOperation Initializer internal abstract class BaseFromEndIndexOperation : Operation, IFromEndIndexOperation { protected BaseFromEndIndexOperation(bool isLifted, SemanticModel semanticModel, SyntaxNode syntax, ITypeSymbol type, IMethodSymbol symbol, bool isImplicit) : - base(OperationKind.FromEndIndex, semanticModel, syntax, type, constantValue: default, isImplicit: isImplicit) + base(OperationKind.None, semanticModel, syntax, type, constantValue: default, isImplicit: isImplicit) { IsLifted = isLifted; Symbol = symbol; diff --git a/src/Compilers/Core/Portable/Operations/OperationVisitor.cs b/src/Compilers/Core/Portable/Operations/OperationVisitor.cs index e3f992c22d5d5d317666eb4fa71ab615efef547d..f82ee037e08221cde99c02e5f1b7762ec2da411e 100644 --- a/src/Compilers/Core/Portable/Operations/OperationVisitor.cs +++ b/src/Compilers/Core/Portable/Operations/OperationVisitor.cs @@ -585,7 +585,7 @@ public virtual void VisitStaticLocalInitializationSemaphore(IStaticLocalInitiali DefaultVisit(operation); } - public virtual void VisitFromEndIndexOperation(IFromEndIndexOperation operation) + internal virtual void VisitFromEndIndexOperation(IFromEndIndexOperation operation) { DefaultVisit(operation); } @@ -1193,7 +1193,7 @@ public virtual TResult VisitStaticLocalInitializationSemaphore(IStaticLocalIniti return DefaultVisit(operation, argument); } - public virtual TResult VisitFromEndIndexOperation(IFromEndIndexOperation operation, TArgument argument) + internal virtual TResult VisitFromEndIndexOperation(IFromEndIndexOperation operation, TArgument argument) { return DefaultVisit(operation, argument); } diff --git a/src/Compilers/Core/Portable/PublicAPI.Unshipped.txt b/src/Compilers/Core/Portable/PublicAPI.Unshipped.txt index fb166541efc941046112e060e5d15f690e7d8fcd..0cdb57ec5274eb0970f947dcec91d6ee66e45bb6 100644 --- a/src/Compilers/Core/Portable/PublicAPI.Unshipped.txt +++ b/src/Compilers/Core/Portable/PublicAPI.Unshipped.txt @@ -5,7 +5,6 @@ Microsoft.CodeAnalysis.ITypeSymbol.IsUnmanagedType.get -> bool Microsoft.CodeAnalysis.OperationKind.Binary = 32 -> Microsoft.CodeAnalysis.OperationKind Microsoft.CodeAnalysis.OperationKind.ConstructorBody = 89 -> Microsoft.CodeAnalysis.OperationKind Microsoft.CodeAnalysis.OperationKind.DiscardPattern = 104 -> Microsoft.CodeAnalysis.OperationKind -Microsoft.CodeAnalysis.OperationKind.FromEndIndex = 100 -> Microsoft.CodeAnalysis.OperationKind Microsoft.CodeAnalysis.OperationKind.MethodBody = 88 -> Microsoft.CodeAnalysis.OperationKind Microsoft.CodeAnalysis.OperationKind.Range = 99 -> Microsoft.CodeAnalysis.OperationKind Microsoft.CodeAnalysis.OperationKind.RecursivePattern = 103 -> Microsoft.CodeAnalysis.OperationKind @@ -168,10 +167,6 @@ Microsoft.CodeAnalysis.Operations.ICoalesceOperation.ValueConversion.get -> Micr Microsoft.CodeAnalysis.Operations.IEventAssignmentOperation.EventReference.get -> Microsoft.CodeAnalysis.IOperation Microsoft.CodeAnalysis.Operations.IForLoopOperation.ConditionLocals.get -> System.Collections.Immutable.ImmutableArray Microsoft.CodeAnalysis.Operations.IForToLoopOperation.IsChecked.get -> bool -Microsoft.CodeAnalysis.Operations.IFromEndIndexOperation -Microsoft.CodeAnalysis.Operations.IFromEndIndexOperation.IsLifted.get -> bool -Microsoft.CodeAnalysis.Operations.IFromEndIndexOperation.Operand.get -> Microsoft.CodeAnalysis.IOperation -Microsoft.CodeAnalysis.Operations.IFromEndIndexOperation.Symbol.get -> Microsoft.CodeAnalysis.IMethodSymbol Microsoft.CodeAnalysis.Operations.IInstanceReferenceOperation.ReferenceKind.get -> Microsoft.CodeAnalysis.Operations.InstanceReferenceKind Microsoft.CodeAnalysis.Operations.ILoopOperation.ContinueLabel.get -> Microsoft.CodeAnalysis.ILabelSymbol Microsoft.CodeAnalysis.Operations.ILoopOperation.ExitLabel.get -> Microsoft.CodeAnalysis.ILabelSymbol @@ -213,7 +208,6 @@ virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.VisitDiscardPattern(M virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.VisitFlowAnonymousFunction(Microsoft.CodeAnalysis.FlowAnalysis.IFlowAnonymousFunctionOperation operation) -> void virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.VisitFlowCapture(Microsoft.CodeAnalysis.FlowAnalysis.IFlowCaptureOperation operation) -> void virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.VisitFlowCaptureReference(Microsoft.CodeAnalysis.FlowAnalysis.IFlowCaptureReferenceOperation operation) -> void -virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.VisitFromEndIndexOperation(Microsoft.CodeAnalysis.Operations.IFromEndIndexOperation operation) -> void virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.VisitIsNull(Microsoft.CodeAnalysis.FlowAnalysis.IIsNullOperation operation) -> void virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.VisitRangeOperation(Microsoft.CodeAnalysis.Operations.IRangeOperation operation) -> void virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.VisitReDim(Microsoft.CodeAnalysis.Operations.IReDimOperation operation) -> void @@ -228,7 +222,6 @@ virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.V virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.VisitFlowAnonymousFunction(Microsoft.CodeAnalysis.FlowAnalysis.IFlowAnonymousFunctionOperation operation, TArgument argument) -> TResult virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.VisitFlowCapture(Microsoft.CodeAnalysis.FlowAnalysis.IFlowCaptureOperation operation, TArgument argument) -> TResult virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.VisitFlowCaptureReference(Microsoft.CodeAnalysis.FlowAnalysis.IFlowCaptureReferenceOperation operation, TArgument argument) -> TResult -virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.VisitFromEndIndexOperation(Microsoft.CodeAnalysis.Operations.IFromEndIndexOperation operation, TArgument argument) -> TResult virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.VisitIsNull(Microsoft.CodeAnalysis.FlowAnalysis.IIsNullOperation operation, TArgument argument) -> TResult virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.VisitRangeOperation(Microsoft.CodeAnalysis.Operations.IRangeOperation operation, TArgument argument) -> TResult virtual Microsoft.CodeAnalysis.Operations.OperationVisitor.VisitReDim(Microsoft.CodeAnalysis.Operations.IReDimOperation operation, TArgument argument) -> TResult diff --git a/src/Test/Utilities/Portable/Compilation/ControlFlowGraphVerifier.cs b/src/Test/Utilities/Portable/Compilation/ControlFlowGraphVerifier.cs index 880b31ecc1a7bd88ace819ea398b0832fbec97e9..9c27c687b91fc82c7cca4f947e328fc8a4a0a67d 100644 --- a/src/Test/Utilities/Portable/Compilation/ControlFlowGraphVerifier.cs +++ b/src/Test/Utilities/Portable/Compilation/ControlFlowGraphVerifier.cs @@ -1800,7 +1800,6 @@ private static bool CanBeInControlFlowGraph(IOperation n) case OperationKind.Discard: case OperationKind.ReDim: case OperationKind.ReDimClause: - case OperationKind.FromEndIndex: case OperationKind.Range: case OperationKind.RecursivePattern: case OperationKind.DiscardPattern: diff --git a/src/Test/Utilities/Portable/Compilation/OperationTreeVerifier.cs b/src/Test/Utilities/Portable/Compilation/OperationTreeVerifier.cs index c6d42196b6cd1b7ab0fa71f47d443edd695089ba..7f3953dd2c407525ce53d05ca5d08e304a1abe70 100644 --- a/src/Test/Utilities/Portable/Compilation/OperationTreeVerifier.cs +++ b/src/Test/Utilities/Portable/Compilation/OperationTreeVerifier.cs @@ -1878,7 +1878,7 @@ public override void VisitStaticLocalInitializationSemaphore(IStaticLocalInitial LogCommonPropertiesAndNewLine(operation); } - public override void VisitFromEndIndexOperation(IFromEndIndexOperation operation) + internal override void VisitFromEndIndexOperation(IFromEndIndexOperation operation) { LogString(nameof(IFromEndIndexOperation)); diff --git a/src/Test/Utilities/Portable/Compilation/TestOperationVisitor.cs b/src/Test/Utilities/Portable/Compilation/TestOperationVisitor.cs index 29767a450c1be856446f97aa6156a3bb3699f39d..0f9aa18d5e015c58088751cf757e8b8f8f843a60 100644 --- a/src/Test/Utilities/Portable/Compilation/TestOperationVisitor.cs +++ b/src/Test/Utilities/Portable/Compilation/TestOperationVisitor.cs @@ -1421,9 +1421,9 @@ public override void VisitStaticLocalInitializationSemaphore(IStaticLocalInitial Assert.True(operation.Local.IsStatic); } - public override void VisitFromEndIndexOperation(IFromEndIndexOperation operation) + internal override void VisitFromEndIndexOperation(IFromEndIndexOperation operation) { - Assert.Equal(OperationKind.FromEndIndex, operation.Kind); + Assert.Equal(OperationKind.None, operation.Kind); Assert.Same(operation.Operand, operation.Children.Single()); }