From 13e76021a3b5f0048da3c93205598f35c7848e0d Mon Sep 17 00:00:00 2001 From: Eriawan Kusumawardhono Date: Tue, 12 Apr 2016 22:36:09 +0700 Subject: [PATCH] add comment based on comment on PR #10304 by Jason Malinowski --- src/Compilers/Core/Portable/Compilation/ParseOptions.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Compilers/Core/Portable/Compilation/ParseOptions.cs b/src/Compilers/Core/Portable/Compilation/ParseOptions.cs index dd0721755d9..bbc0e636ac1 100644 --- a/src/Compilers/Core/Portable/Compilation/ParseOptions.cs +++ b/src/Compilers/Core/Portable/Compilation/ParseOptions.cs @@ -38,6 +38,9 @@ public ParseOptions WithKind(SourceCodeKind kind) return CommonWithKind(kind); } + // It was supposed to be a protected implementation detail. + // The "pattern" we have for these is the public With* method is the only public callable one, + // and that forwards to the protected Common* like all the other methods in the class (see PR #10304 comments by Jason Malinowski) [EditorBrowsable(EditorBrowsableState.Never)] public abstract ParseOptions CommonWithKind(SourceCodeKind kind); -- GitLab