From 0af082f87aec0a39b56a124279ff37508c0e4172 Mon Sep 17 00:00:00 2001 From: CyrusNajmabadi Date: Sat, 6 May 2017 14:58:32 -0700 Subject: [PATCH] Simplify. --- .../Core/Portable/Serialization/ObjectWriter.cs | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/Compilers/Core/Portable/Serialization/ObjectWriter.cs b/src/Compilers/Core/Portable/Serialization/ObjectWriter.cs index f3bbdb87fad..9850d9c4f1b 100644 --- a/src/Compilers/Core/Portable/Serialization/ObjectWriter.cs +++ b/src/Compilers/Core/Portable/Serialization/ObjectWriter.cs @@ -710,15 +710,10 @@ private void WriteObject(object instance, IObjectWritable instanceAsWritableOpt) } else { - IObjectWritable writable; - if (instanceAsWritableOpt != null) + if (instanceAsWritableOpt == null) { - writable = instanceAsWritableOpt; - } - else - { - writable = instance as IObjectWritable; - if (writable == null) + instanceAsWritableOpt = instance as IObjectWritable; + if (instanceAsWritableOpt == null) { throw NoSerializationWriterException($"{instance.GetType()} must implement {nameof(IObjectWritable)}"); } @@ -733,7 +728,7 @@ private void WriteObject(object instance, IObjectWritable instanceAsWritableOpt) // don't blow the stack. 'LongRunning' ensures that we get a dedicated thread // to do this work. That way we don't end up blocking the threadpool. var task = Task.Factory.StartNew( - () => WriteObjectWorker(instance, writable), + () => WriteObjectWorker(instance, instanceAsWritableOpt), _cancellationToken, TaskCreationOptions.LongRunning, TaskScheduler.Default); @@ -741,7 +736,7 @@ private void WriteObject(object instance, IObjectWritable instanceAsWritableOpt) } else { - WriteObjectWorker(instance, writable); + WriteObjectWorker(instance, instanceAsWritableOpt); } _recursionDepth--; -- GitLab