From 09b95abf1af95025cfa09a803a55e01378118acc Mon Sep 17 00:00:00 2001 From: Cyrus Najmabadi Date: Fri, 20 Nov 2015 11:50:29 -0800 Subject: [PATCH] Remove blocking calls from tests. --- .../CSharpTest/ExtractInterface/ExtractInterfaceTests.cs | 2 +- .../Test/ExtractInterface/ExtractInterfaceTestState.cs | 4 ++-- .../Test/RenameTracking/RenameTrackingTestState.cs | 6 +----- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/EditorFeatures/CSharpTest/ExtractInterface/ExtractInterfaceTests.cs b/src/EditorFeatures/CSharpTest/ExtractInterface/ExtractInterfaceTests.cs index 0c420122497..e8e3ef8c7c5 100644 --- a/src/EditorFeatures/CSharpTest/ExtractInterface/ExtractInterfaceTests.cs +++ b/src/EditorFeatures/CSharpTest/ExtractInterface/ExtractInterfaceTests.cs @@ -1010,7 +1010,7 @@ class Program $$: ISomeInterface { using (var testState = await ExtractInterfaceTestState.CreateAsync(markup, LanguageNames.CSharp, compilationOptions: null)) { - var result = testState.GetTypeAnalysisResult(typeDiscoveryRule); + var result = await testState.GetTypeAnalysisResultAsync(typeDiscoveryRule); Assert.Equal(expectedExtractable, result.CanExtractInterface); } } diff --git a/src/EditorFeatures/Test/ExtractInterface/ExtractInterfaceTestState.cs b/src/EditorFeatures/Test/ExtractInterface/ExtractInterfaceTestState.cs index 435acec5a09..873d1a7f465 100644 --- a/src/EditorFeatures/Test/ExtractInterface/ExtractInterfaceTestState.cs +++ b/src/EditorFeatures/Test/ExtractInterface/ExtractInterfaceTestState.cs @@ -67,13 +67,13 @@ public TestExtractInterfaceOptionsService TestExtractInterfaceOptionsService } } - public ExtractInterfaceTypeAnalysisResult GetTypeAnalysisResult(TypeDiscoveryRule typeDiscoveryRule) + public Task GetTypeAnalysisResultAsync(TypeDiscoveryRule typeDiscoveryRule) { return ExtractInterfaceService.AnalyzeTypeAtPositionAsync( ExtractFromDocument, _testDocument.CursorPosition.Value, typeDiscoveryRule, - CancellationToken.None).WaitAndGetResult(CancellationToken.None); + CancellationToken.None); } public ExtractInterfaceResult ExtractViaCommand() diff --git a/src/EditorFeatures/Test/RenameTracking/RenameTrackingTestState.cs b/src/EditorFeatures/Test/RenameTracking/RenameTrackingTestState.cs index 1bd8eabaa5d..12694685bf8 100644 --- a/src/EditorFeatures/Test/RenameTracking/RenameTrackingTestState.cs +++ b/src/EditorFeatures/Test/RenameTracking/RenameTrackingTestState.cs @@ -195,11 +195,7 @@ public async Task AssertTag(string expectedFromName, string expectedToName, bool if (invokeAction) { - var operations = actions[0] - .GetOperationsAsync(CancellationToken.None) - .WaitAndGetResult(CancellationToken.None) - .ToArray(); - + var operations = (await actions[0].GetOperationsAsync(CancellationToken.None)).ToArray(); Assert.Equal(1, operations.Length); operations[0].Apply(this.Workspace, CancellationToken.None); -- GitLab