From 036e5f5380a855883fac63e944e4d7ad5ffec3eb Mon Sep 17 00:00:00 2001 From: Ravi Chande Date: Tue, 16 May 2017 12:58:26 -0700 Subject: [PATCH] Move assertion into GetDocument() method --- .../IntelliSense/Completion/Controller_TypeChar.cs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/EditorFeatures/Core/Implementation/IntelliSense/Completion/Controller_TypeChar.cs b/src/EditorFeatures/Core/Implementation/IntelliSense/Completion/Controller_TypeChar.cs index 542c6c7a008..20a606d3284 100644 --- a/src/EditorFeatures/Core/Implementation/IntelliSense/Completion/Controller_TypeChar.cs +++ b/src/EditorFeatures/Core/Implementation/IntelliSense/Completion/Controller_TypeChar.cs @@ -264,12 +264,14 @@ private static bool IsPotentialFilterCharacter(TypeCharCommandArgs args) private Document GetDocument() { - return this.SubjectBuffer.CurrentSnapshot.GetOpenDocumentInCurrentContextWithChanges(); + // Crash if we don't find a document, we're already in a bad state. + var document = this.SubjectBuffer.CurrentSnapshot.GetOpenDocumentInCurrentContextWithChanges(); + Contract.ThrowIfNull(document, nameof(document)); + return document; } private CompletionHelper GetCompletionHelper() { - // Crash if we don't find a document, we're already in a bad state. var document = GetDocument(); return CompletionHelper.GetHelper(document); } -- GitLab