From fdacc4ee6a3341b2c44ddd85a41f2a04d0d417ad Mon Sep 17 00:00:00 2001 From: Phil Hughes Date: Thu, 4 May 2017 08:54:42 +0100 Subject: [PATCH] Moved to a view spec --- app/views/projects/tags/index.html.haml | 1 + spec/features/projects/tags/sort_spec.rb | 15 -------------- .../projects/tags/index.html.haml_spec.rb | 20 +++++++++++++++++++ 3 files changed, 21 insertions(+), 15 deletions(-) delete mode 100644 spec/features/projects/tags/sort_spec.rb create mode 100644 spec/views/projects/tags/index.html.haml_spec.rb diff --git a/app/views/projects/tags/index.html.haml b/app/views/projects/tags/index.html.haml index c14bbf4f05f..56656ea3d86 100644 --- a/app/views/projects/tags/index.html.haml +++ b/app/views/projects/tags/index.html.haml @@ -1,4 +1,5 @@ - @no_container = true +- @sort ||= sort_value_recently_updated - page_title "Tags" = render "projects/commits/head" diff --git a/spec/features/projects/tags/sort_spec.rb b/spec/features/projects/tags/sort_spec.rb deleted file mode 100644 index 835cd1507fb..00000000000 --- a/spec/features/projects/tags/sort_spec.rb +++ /dev/null @@ -1,15 +0,0 @@ -require 'spec_helper' - -feature 'Tags sort dropdown', :feature do - let(:project) { create(:project) } - - before do - login_as(:admin) - - visit namespace_project_tags_path(project.namespace, project) - end - - it 'defaults sort dropdown to last updated' do - expect(page).to have_button('Last updated') - end -end diff --git a/spec/views/projects/tags/index.html.haml_spec.rb b/spec/views/projects/tags/index.html.haml_spec.rb new file mode 100644 index 00000000000..33122365e9a --- /dev/null +++ b/spec/views/projects/tags/index.html.haml_spec.rb @@ -0,0 +1,20 @@ +require 'spec_helper' + +describe 'projects/tags/index', :view do + let(:project) { create(:project) } + + before do + assign(:project, project) + assign(:repository, project.repository) + assign(:tags, []) + + allow(view).to receive(:current_ref).and_return('master') + allow(view).to receive(:can?).and_return(false) + end + + it 'defaults sort dropdown toggle to last updated' do + render + + expect(rendered).to have_button('Last updated') + end +end -- GitLab