From f7abde937dda342ee78618f26ee8f86f46e9072d Mon Sep 17 00:00:00 2001 From: Tiago Botelho Date: Tue, 26 Jun 2018 18:18:33 +0100 Subject: [PATCH] Move kubeclient and namespace variables to the private interface --- app/models/internal_id.rb | 2 +- lib/gitlab/kubernetes/helm/api.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/models/internal_id.rb b/app/models/internal_id.rb index 6a3e27625e9..f50f28deffe 100644 --- a/app/models/internal_id.rb +++ b/app/models/internal_id.rb @@ -14,7 +14,7 @@ class InternalId < ActiveRecord::Base belongs_to :project belongs_to :namespace - enum usage: { issues: 0, merge_requests: 1, deployments: 2, milestones: 3, epics: 4, ci_pipelines: 5, prometheus_alerts: 6 } + enum usage: { issues: 0, merge_requests: 1, deployments: 2, milestones: 3, epics: 4, ci_pipelines: 5 } validates :usage, presence: true diff --git a/lib/gitlab/kubernetes/helm/api.rb b/lib/gitlab/kubernetes/helm/api.rb index 54332d0cc4e..c4de9a398cc 100644 --- a/lib/gitlab/kubernetes/helm/api.rb +++ b/lib/gitlab/kubernetes/helm/api.rb @@ -2,8 +2,6 @@ module Gitlab module Kubernetes module Helm class Api - attr_reader :kubeclient, :namespace - def initialize(kubeclient) @kubeclient = kubeclient @namespace = Gitlab::Kubernetes::Namespace.new(Gitlab::Kubernetes::Helm::NAMESPACE, kubeclient) @@ -36,6 +34,8 @@ module Gitlab private + attr_reader :kubeclient, :namespace + def create_config_map(command) command.config_map_resource.tap do |config_map_resource| kubeclient.create_config_map(config_map_resource) -- GitLab