Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
f379e1b3
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
f379e1b3
编写于
4月 05, 2018
作者:
M
Matija Čupić
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Rename success to erased empty state spec
上级
00b45348
变更
4
显示空白变更内容
内联
并排
Showing
4 changed file
with
31 addition
and
22 deletion
+31
-22
lib/gitlab/ci/status/build/erased.rb
lib/gitlab/ci/status/build/erased.rb
+2
-2
lib/gitlab/ci/status/build/factory.rb
lib/gitlab/ci/status/build/factory.rb
+1
-1
spec/lib/gitlab/ci/status/build/erased_spec.rb
spec/lib/gitlab/ci/status/build/erased_spec.rb
+5
-7
spec/lib/gitlab/ci/status/build/factory_spec.rb
spec/lib/gitlab/ci/status/build/factory_spec.rb
+23
-12
未找到文件。
lib/gitlab/ci/status/build/
success
.rb
→
lib/gitlab/ci/status/build/
erased
.rb
浏览文件 @
f379e1b3
...
...
@@ -2,7 +2,7 @@ module Gitlab
module
Ci
module
Status
module
Build
class
Success
<
Status
::
Extended
class
Erased
<
Status
::
Extended
def
illustration
{
image:
'illustrations/skipped-job_empty.svg'
,
...
...
@@ -12,7 +12,7 @@ module Gitlab
end
def
self
.
matches?
(
build
,
user
)
!
build
.
has_trace?
&&
build
.
success
?
build
.
erased
?
end
end
end
...
...
lib/gitlab/ci/status/build/factory.rb
浏览文件 @
f379e1b3
...
...
@@ -9,7 +9,7 @@ module Gitlab
Status
::
Build
::
Created
,
Status
::
Build
::
Pending
,
Status
::
Build
::
Skipped
,
Status
::
Build
::
Success
],
Status
::
Build
::
Erased
],
[
Status
::
Build
::
Cancelable
,
Status
::
Build
::
Retryable
],
[
Status
::
Build
::
FailedAllowed
,
...
...
spec/lib/gitlab/ci/status/build/
success
_spec.rb
→
spec/lib/gitlab/ci/status/build/
erased
_spec.rb
浏览文件 @
f379e1b3
require
'spec_helper'
describe
Gitlab
::
Ci
::
Status
::
Build
::
Success
do
describe
Gitlab
::
Ci
::
Status
::
Build
::
Erased
do
let
(
:user
)
{
create
(
:user
)
}
subject
do
...
...
@@ -14,18 +14,16 @@ describe Gitlab::Ci::Status::Build::Success do
describe
'.matches?'
do
subject
{
described_class
.
matches?
(
build
,
user
)
}
context
'when build
succeeded but does not have trace
'
do
let
(
:build
)
{
create
(
:ci_build
,
:success
)
}
context
'when build
is erased
'
do
let
(
:build
)
{
create
(
:ci_build
,
:success
,
:erased
)
}
it
'is a correct match'
do
build
.
erase
expect
(
subject
).
to
be
true
end
end
context
'when build
succeed but has trace
'
do
let
!
(
:build
)
{
create
(
:ci_build
,
:success
,
:trace_artifact
)
}
context
'when build
is not erased
'
do
let
(
:build
)
{
create
(
:ci_build
,
:success
,
:trace_artifact
)
}
it
'does not match'
do
expect
(
subject
).
to
be
false
...
...
spec/lib/gitlab/ci/status/build/factory_spec.rb
浏览文件 @
f379e1b3
...
...
@@ -36,21 +36,32 @@ describe Gitlab::Ci::Status::Build::Factory do
expect
(
status
).
to
have_details
expect
(
status
).
to
have_action
end
end
context
'when job log gets erased'
do
before
do
build
.
erase
context
'when build is erased'
do
let
(
:build
)
{
create
(
:ci_build
,
:success
,
:erased
)
}
it
'matches correct core status'
do
expect
(
factory
.
core_status
).
to
be_a
Gitlab
::
Ci
::
Status
::
Success
end
it
'matches correct extended statuses'
do
expect
(
factory
.
extended_statuses
)
.
to
eq
[
Gitlab
::
Ci
::
Status
::
Build
::
Success
,
.
to
eq
[
Gitlab
::
Ci
::
Status
::
Build
::
Erased
,
Gitlab
::
Ci
::
Status
::
Build
::
Retryable
]
end
it
'fabricates a retryable build status'
do
expect
(
status
).
to
be_a
Gitlab
::
Ci
::
Status
::
Build
::
Retryable
end
it
'fabricates status with correct details'
do
expect
(
status
.
text
).
to
eq
'passed'
expect
(
status
.
icon
).
to
eq
'status_success'
expect
(
status
.
favicon
).
to
eq
'favicon_status_success'
expect
(
status
.
label
).
to
eq
'passed'
expect
(
status
).
to
have_details
expect
(
status
).
to
have_action
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录