Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
f09b7f56
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
f09b7f56
编写于
6月 02, 2017
作者:
N
Nick Thomas
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Support hard deletion in Admin::UsersController#destroy
上级
158581a4
变更
3
显示空白变更内容
内联
并排
Showing
3 changed file
with
16 addition
and
4 deletion
+16
-4
app/controllers/admin/users_controller.rb
app/controllers/admin/users_controller.rb
+1
-1
doc/user/profile/account/delete_account.md
doc/user/profile/account/delete_account.md
+2
-1
spec/controllers/admin/users_controller_spec.rb
spec/controllers/admin/users_controller_spec.rb
+13
-2
未找到文件。
app/controllers/admin/users_controller.rb
浏览文件 @
f09b7f56
...
@@ -138,7 +138,7 @@ class Admin::UsersController < Admin::ApplicationController
...
@@ -138,7 +138,7 @@ class Admin::UsersController < Admin::ApplicationController
end
end
def
destroy
def
destroy
DeleteUserWorker
.
perform_async
(
current_user
.
id
,
user
.
id
)
user
.
delete_async
(
deleted_by:
current_user
,
params:
params
.
permit
(
:hard_delete
)
)
respond_to
do
|
format
|
respond_to
do
|
format
|
format
.
html
{
redirect_to
admin_users_path
,
notice:
"The user is being deleted."
}
format
.
html
{
redirect_to
admin_users_path
,
notice:
"The user is being deleted."
}
...
...
doc/user/profile/account/delete_account.md
浏览文件 @
f09b7f56
...
@@ -25,7 +25,8 @@ Instead of being deleted, these records will be moved to a system-wide
...
@@ -25,7 +25,8 @@ Instead of being deleted, these records will be moved to a system-wide
When a user is deleted from an abuse report or spam log, these associated
When a user is deleted from an abuse report or spam log, these associated
records are not ghosted and will be removed, along with any groups the user
records are not ghosted and will be removed, along with any groups the user
is a sole owner of. Administrators can also request this behaviour when
is a sole owner of. Administrators can also request this behaviour when
deleting users from the
[
API
](
../../../api/users.md#user-deletion
)
deleting users from the
[
API
](
../../../api/users.md#user-deletion
)
or the
admin area.
[
ce-7393
]:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7393
[
ce-7393
]:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7393
[
ce-10273
]:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10273
[
ce-10273
]:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10273
...
...
spec/controllers/admin/users_controller_spec.rb
浏览文件 @
f09b7f56
...
@@ -10,15 +10,26 @@ describe Admin::UsersController do
...
@@ -10,15 +10,26 @@ describe Admin::UsersController do
describe
'DELETE #user with projects'
do
describe
'DELETE #user with projects'
do
let
(
:project
)
{
create
(
:empty_project
,
namespace:
user
.
namespace
)
}
let
(
:project
)
{
create
(
:empty_project
,
namespace:
user
.
namespace
)
}
let!
(
:issue
)
{
create
(
:issue
,
author:
user
)
}
before
do
before
do
project
.
team
<<
[
user
,
:developer
]
project
.
team
<<
[
user
,
:developer
]
end
end
it
'deletes user'
do
it
'deletes user
and ghosts their contributions
'
do
delete
:destroy
,
id:
user
.
username
,
format: :json
delete
:destroy
,
id:
user
.
username
,
format: :json
expect
(
response
).
to
have_http_status
(
200
)
expect
(
User
.
exists?
(
user
.
id
)).
to
be_falsy
expect
(
issue
.
reload
.
author
).
to
be_ghost
end
it
'deletes the user and their contributions when hard delete is specified'
do
delete
:destroy
,
id:
user
.
username
,
hard_delete:
true
,
format: :json
expect
(
response
).
to
have_http_status
(
200
)
expect
(
response
).
to
have_http_status
(
200
)
expect
{
User
.
find
(
user
.
id
)
}.
to
raise_exception
(
ActiveRecord
::
RecordNotFound
)
expect
(
User
.
exists?
(
user
.
id
)).
to
be_falsy
expect
(
Issue
.
exists?
(
issue
.
id
)).
to
be_falsy
end
end
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录