From d95bffc6dad3e6d999fb4d5c8c66d7fea05c73b7 Mon Sep 17 00:00:00 2001 From: Toon Claes Date: Mon, 3 Apr 2017 11:55:15 +0200 Subject: [PATCH] Rename GitlabMarkdownHelper -> MarkupHelper It does more than solely GitLab Markdown, so rename to MarkupHelper. --- app/helpers/{gitlab_markdown_helper.rb => markup_helper.rb} | 2 +- app/mailers/base_mailer.rb | 2 +- spec/features/copy_as_gfm_spec.rb | 2 +- spec/features/markdown_spec.rb | 2 +- .../{gitlab_markdown_helper_spec.rb => markup_helper_spec.rb} | 2 +- spec/services/system_note_service_spec.rb | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) rename app/helpers/{gitlab_markdown_helper.rb => markup_helper.rb} (99%) rename spec/helpers/{gitlab_markdown_helper_spec.rb => markup_helper_spec.rb} (99%) diff --git a/app/helpers/gitlab_markdown_helper.rb b/app/helpers/markup_helper.rb similarity index 99% rename from app/helpers/gitlab_markdown_helper.rb rename to app/helpers/markup_helper.rb index 106feb87398..a10714e81ae 100644 --- a/app/helpers/gitlab_markdown_helper.rb +++ b/app/helpers/markup_helper.rb @@ -1,6 +1,6 @@ require 'nokogiri' -module GitlabMarkdownHelper +module MarkupHelper # Use this in places where you would normally use link_to(gfm(...), ...). # # It solves a problem occurring with nested links (i.e. diff --git a/app/mailers/base_mailer.rb b/app/mailers/base_mailer.rb index a9b6b33eb5c..d2980db218a 100644 --- a/app/mailers/base_mailer.rb +++ b/app/mailers/base_mailer.rb @@ -1,6 +1,6 @@ class BaseMailer < ActionMailer::Base helper ApplicationHelper - helper GitlabMarkdownHelper + helper MarkupHelper attr_accessor :current_user helper_method :current_user, :can? diff --git a/spec/features/copy_as_gfm_spec.rb b/spec/features/copy_as_gfm_spec.rb index 64a6c70061b..344e31e5ef5 100644 --- a/spec/features/copy_as_gfm_spec.rb +++ b/spec/features/copy_as_gfm_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' describe 'Copy as GFM', feature: true, js: true do - include GitlabMarkdownHelper + include MarkupHelper include RepoHelpers include ActionView::Helpers::JavaScriptHelper diff --git a/spec/features/markdown_spec.rb b/spec/features/markdown_spec.rb index 894df13a2dc..ba930de937d 100644 --- a/spec/features/markdown_spec.rb +++ b/spec/features/markdown_spec.rb @@ -26,7 +26,7 @@ require 'erb' describe 'GitLab Markdown', feature: true do include Capybara::Node::Matchers - include GitlabMarkdownHelper + include MarkupHelper include MarkdownMatchers # Sometimes it can be useful to see the parsed output of the Markdown document diff --git a/spec/helpers/gitlab_markdown_helper_spec.rb b/spec/helpers/markup_helper_spec.rb similarity index 99% rename from spec/helpers/gitlab_markdown_helper_spec.rb rename to spec/helpers/markup_helper_spec.rb index b8fd54c66e4..c8da995581e 100644 --- a/spec/helpers/gitlab_markdown_helper_spec.rb +++ b/spec/helpers/markup_helper_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe GitlabMarkdownHelper do +describe MarkupHelper do include ApplicationHelper let!(:project) { create(:project, :repository) } diff --git a/spec/services/system_note_service_spec.rb b/spec/services/system_note_service_spec.rb index 42d63a9f9ba..75d7caf2508 100644 --- a/spec/services/system_note_service_spec.rb +++ b/spec/services/system_note_service_spec.rb @@ -595,7 +595,7 @@ describe SystemNoteService, services: true do end shared_examples 'cross project mentionable' do - include GitlabMarkdownHelper + include MarkupHelper it 'contains cross reference to new noteable' do expect(subject.note).to include cross_project_reference(new_project, new_noteable) -- GitLab