Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
d47fca53
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
未验证
提交
d47fca53
编写于
11月 16, 2016
作者:
R
Rémy Coutable
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Allow commit note to be visible if repo is visible
Signed-off-by:
N
Rémy Coutable
<
remy@rymai.me
>
上级
1263708d
变更
4
显示空白变更内容
内联
并排
Showing
4 changed file
with
36 addition
and
5 deletion
+36
-5
app/helpers/events_helper.rb
app/helpers/events_helper.rb
+2
-2
app/models/event.rb
app/models/event.rb
+3
-3
changelogs/unreleased/23824-activity-page-does-not-show-commits-comments.yml
...ed/23824-activity-page-does-not-show-commits-comments.yml
+4
-0
spec/models/event_spec.rb
spec/models/event_spec.rb
+27
-0
未找到文件。
app/helpers/events_helper.rb
浏览文件 @
d47fca53
...
...
@@ -86,7 +86,7 @@ module EventsHelper
elsif
event
.
merge_request?
namespace_project_merge_request_url
(
event
.
project
.
namespace
,
event
.
project
,
event
.
merge_request
)
elsif
event
.
note?
&&
event
.
commit_note?
elsif
event
.
commit_note?
namespace_project_commit_url
(
event
.
project
.
namespace
,
event
.
project
,
event
.
note_target
)
elsif
event
.
note?
...
...
@@ -127,7 +127,7 @@ module EventsHelper
end
def
event_note_target_path
(
event
)
if
event
.
note?
&&
event
.
commit_note?
if
event
.
commit_note?
namespace_project_commit_path
(
event
.
project
.
namespace
,
event
.
project
,
event
.
note_target
,
...
...
app/models/event.rb
浏览文件 @
d47fca53
...
...
@@ -62,7 +62,7 @@ class Event < ActiveRecord::Base
end
def
visible_to_user?
(
user
=
nil
)
if
push?
if
push?
||
commit_note?
Ability
.
allowed?
(
user
,
:download_code
,
project
)
elsif
membership_changed?
true
...
...
@@ -283,7 +283,7 @@ class Event < ActiveRecord::Base
end
def
commit_note?
target
.
for_commit?
note?
&&
target
&&
target
.
for_commit?
end
def
issue_note?
...
...
@@ -295,7 +295,7 @@ class Event < ActiveRecord::Base
end
def
project_snippet_note?
target
.
for_snippet?
note?
&&
target
&&
target
.
for_snippet?
end
def
note_target
...
...
changelogs/unreleased/23824-activity-page-does-not-show-commits-comments.yml
0 → 100644
浏览文件 @
d47fca53
---
title
:
Allow commit note to be visible if repo is visible
merge_request
:
author
:
spec/models/event_spec.rb
浏览文件 @
d47fca53
...
...
@@ -94,6 +94,7 @@ describe Event, models: true do
let
(
:admin
)
{
create
(
:admin
)
}
let
(
:issue
)
{
create
(
:issue
,
project:
project
,
author:
author
,
assignee:
assignee
)
}
let
(
:confidential_issue
)
{
create
(
:issue
,
:confidential
,
project:
project
,
author:
author
,
assignee:
assignee
)
}
let
(
:note_on_commit
)
{
create
(
:note_on_commit
,
project:
project
)
}
let
(
:note_on_issue
)
{
create
(
:note_on_issue
,
noteable:
issue
,
project:
project
)
}
let
(
:note_on_confidential_issue
)
{
create
(
:note_on_issue
,
noteable:
confidential_issue
,
project:
project
)
}
let
(
:event
)
{
Event
.
new
(
project:
project
,
target:
target
,
author_id:
author
.
id
)
}
...
...
@@ -103,6 +104,32 @@ describe Event, models: true do
project
.
team
<<
[
guest
,
:guest
]
end
context
'commit note event'
do
let
(
:target
)
{
note_on_commit
}
it
do
aggregate_failures
do
expect
(
event
.
visible_to_user?
(
non_member
)).
to
eq
true
expect
(
event
.
visible_to_user?
(
member
)).
to
eq
true
expect
(
event
.
visible_to_user?
(
guest
)).
to
eq
true
expect
(
event
.
visible_to_user?
(
admin
)).
to
eq
true
end
end
context
'private project'
do
let
(
:project
)
{
create
(
:empty_project
,
:private
)
}
it
do
aggregate_failures
do
expect
(
event
.
visible_to_user?
(
non_member
)).
to
eq
false
expect
(
event
.
visible_to_user?
(
member
)).
to
eq
true
expect
(
event
.
visible_to_user?
(
guest
)).
to
eq
false
expect
(
event
.
visible_to_user?
(
admin
)).
to
eq
true
end
end
end
end
context
'issue event'
do
context
'for non confidential issues'
do
let
(
:target
)
{
issue
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录