diff --git a/doc/ci/docker/using_docker_images.md b/doc/ci/docker/using_docker_images.md index 489791141edb39955ab1f24d34da15e80c16b6aa..e58fe5e4604c7d27f8477605505171c2329a4d24 100644 --- a/doc/ci/docker/using_docker_images.md +++ b/doc/ci/docker/using_docker_images.md @@ -576,8 +576,8 @@ There are two ways to determine the value of `DOCKER_AUTH_CONFIG`: will use the available system keystore to store the result of `docker login`. In that case, it's impossible to read `~/.docker/config.json`, so you will need to prepare the required base64-encoded version of - `${username}:${password}` manually. Open a terminal and execute the - following command: + `${username}:${password}` and create the Docker configuration JSON manually. + Open a terminal and execute the following command: ```bash echo -n "my_username:my_password" | base64 @@ -585,6 +585,18 @@ There are two ways to determine the value of `DOCKER_AUTH_CONFIG`: # Example output to copy bXlfdXNlcm5hbWU6bXlfcGFzc3dvcmQ= ``` + + Create the Docker JSON configuration content as follows: + + ```json + { + "auths": { + "registry.example.com:5000": { + "auth": "(Base64 content from above)" + } + } + } + ``` #### Configuring a job diff --git a/doc/development/testing_guide/end_to_end/resources.md b/doc/development/testing_guide/end_to_end/resources.md index 1e32db4f63355fb2c6d4cf4a8519a119a0c9e246..b8a093c54c6e26b83922f93531c3d35fb181fe69 100644 --- a/doc/development/testing_guide/end_to_end/resources.md +++ b/doc/development/testing_guide/end_to_end/resources.md @@ -44,6 +44,9 @@ create the resource via the public GitLab API: - `#api_post_path`: The `POST` path to create a new resource. - `#api_post_body`: The `POST` body (as a Ruby hash) to create a new resource. +> Be aware that many API resources are [paginated](../../../api/README.md#pagination). +> If you don't find the results you expect, check if there is more that one page of results. + Let's take the `Shirt` resource class, and add these three API methods: ```ruby diff --git a/spec/features/groups/settings/group_badges_spec.rb b/spec/features/groups/settings/group_badges_spec.rb index 9328fd9dcba960ff588cb8cf6ca1e9c68ca42e69..72e74df368b90f6438d9baa3832dda89b3c8ea2a 100644 --- a/spec/features/groups/settings/group_badges_spec.rb +++ b/spec/features/groups/settings/group_badges_spec.rb @@ -7,8 +7,9 @@ describe 'Group Badges' do let(:user) { create(:user) } let(:group) { create(:group) } - let(:badge_link_url) { 'https://gitlab.com/gitlab-org/gitlab/commits/master'} - let(:badge_image_url) { 'https://gitlab.com/gitlab-org/gitlab/badges/master/build.svg'} + let(:project) { create(:project, namespace: group) } + let(:badge_link_url) { "http://#{page.server.host}:#{page.server.port}/#{project.full_path}/commits/master" } + let(:badge_image_url) { "http://#{page.server.host}:#{page.server.port}/#{project.full_path}/badges/master/pipeline.svg" } let!(:badge_1) { create(:group_badge, group: group) } let!(:badge_2) { create(:group_badge, group: group) } diff --git a/spec/features/projects/settings/project_badges_spec.rb b/spec/features/projects/settings/project_badges_spec.rb index 03d2f1cf0448d4b0e357cd0eb54b82f8efe520cf..c419bb1868c836064dd061ce94fc1e5143cb8c93 100644 --- a/spec/features/projects/settings/project_badges_spec.rb +++ b/spec/features/projects/settings/project_badges_spec.rb @@ -8,8 +8,8 @@ describe 'Project Badges' do let(:user) { create(:user) } let(:group) { create(:group) } let(:project) { create(:project, namespace: group) } - let(:badge_link_url) { 'https://gitlab.com/gitlab-org/gitlab/commits/master'} - let(:badge_image_url) { 'https://gitlab.com/gitlab-org/gitlab/badges/master/build.svg'} + let(:badge_link_url) { "http://#{page.server.host}:#{page.server.port}/#{project.full_path}/commits/master" } + let(:badge_image_url) { "http://#{page.server.host}:#{page.server.port}/#{project.full_path}/badges/master/pipeline.svg" } let!(:project_badge) { create(:project_badge, project: project) } let!(:group_badge) { create(:group_badge, group: group) }