Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
cad8bb18
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
cad8bb18
编写于
6月 25, 2019
作者:
D
Douglas Barbosa Alexandre
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Parse the cached value when the it is false
上级
87b468c2
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
35 addition
and
2 deletion
+35
-2
lib/gitlab/json_cache.rb
lib/gitlab/json_cache.rb
+1
-1
spec/lib/gitlab/json_cache_spec.rb
spec/lib/gitlab/json_cache_spec.rb
+34
-1
未找到文件。
lib/gitlab/json_cache.rb
浏览文件 @
cad8bb18
...
...
@@ -34,7 +34,7 @@ module Gitlab
def
read
(
key
,
klass
=
nil
)
value
=
backend
.
read
(
cache_key
(
key
))
value
=
parse_value
(
value
,
klass
)
if
value
value
=
parse_value
(
value
,
klass
)
unless
value
.
nil?
value
end
...
...
spec/lib/gitlab/json_cache_spec.rb
浏览文件 @
cad8bb18
...
...
@@ -129,19 +129,52 @@ describe Gitlab::JsonCache do
.
with
(
expanded_key
)
.
and_return
(
nil
)
expect
(
ActiveSupport
::
JSON
).
not_to
receive
(
:decode
)
expect
(
cache
.
read
(
key
)).
to
be_nil
end
context
'when the cached value is
a boolean
'
do
context
'when the cached value is
true
'
do
it
'parses the cached value'
do
allow
(
backend
).
to
receive
(
:read
)
.
with
(
expanded_key
)
.
and_return
(
true
)
expect
(
ActiveSupport
::
JSON
).
to
receive
(
:decode
).
with
(
"true"
).
and_call_original
expect
(
cache
.
read
(
key
,
BroadcastMessage
)).
to
eq
(
true
)
end
end
context
'when the cached value is false'
do
it
'parses the cached value'
do
allow
(
backend
).
to
receive
(
:read
)
.
with
(
expanded_key
)
.
and_return
(
false
)
expect
(
ActiveSupport
::
JSON
).
to
receive
(
:decode
).
with
(
"false"
).
and_call_original
expect
(
cache
.
read
(
key
,
BroadcastMessage
)).
to
eq
(
false
)
end
end
context
'when the cached value is a JSON true value'
do
it
'parses the cached value'
do
allow
(
backend
).
to
receive
(
:read
)
.
with
(
expanded_key
)
.
and_return
(
"true"
)
expect
(
cache
.
read
(
key
,
BroadcastMessage
)).
to
eq
(
true
)
end
end
context
'when the cached value is a JSON false value'
do
it
'parses the cached value'
do
allow
(
backend
).
to
receive
(
:read
)
.
with
(
expanded_key
)
.
and_return
(
"false"
)
expect
(
cache
.
read
(
key
,
BroadcastMessage
)).
to
eq
(
false
)
end
end
context
'when the cached value is a hash'
do
it
'parses the cached value'
do
allow
(
backend
).
to
receive
(
:read
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录