Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
李少辉-开发者
gitlab-foss
提交
c379973b
G
gitlab-foss
项目概览
李少辉-开发者
/
gitlab-foss
通知
15
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
G
gitlab-foss
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
c379973b
编写于
1月 16, 2019
作者:
S
Semyon Pupkov
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
chore(rubocop): fix Style/TrivialAccessors issues
上级
a2b26577
变更
5
显示空白变更内容
内联
并排
Showing
5 changed file
with
11 addition
and
30 deletion
+11
-30
.rubocop_todo.yml
.rubocop_todo.yml
+0
-11
app/models/external_issue.rb
app/models/external_issue.rb
+3
-5
app/serializers/base_serializer.rb
app/serializers/base_serializer.rb
+5
-5
lib/gitlab/auth/ldap/person.rb
lib/gitlab/auth/ldap/person.rb
+1
-3
lib/system_check/base_check.rb
lib/system_check/base_check.rb
+2
-6
未找到文件。
.rubocop_todo.yml
浏览文件 @
c379973b
...
@@ -686,17 +686,6 @@ Style/TrailingUnderscoreVariable:
...
@@ -686,17 +686,6 @@ Style/TrailingUnderscoreVariable:
-
'
spec/lib/gitlab/etag_caching/middleware_spec.rb'
-
'
spec/lib/gitlab/etag_caching/middleware_spec.rb'
-
'
spec/services/quick_actions/interpret_service_spec.rb'
-
'
spec/services/quick_actions/interpret_service_spec.rb'
# Offense count: 5
# Cop supports --auto-correct.
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
Style/TrivialAccessors
:
Exclude
:
-
'
app/models/external_issue.rb'
-
'
app/serializers/base_serializer.rb'
-
'
lib/gitlab/auth/ldap/person.rb'
-
'
lib/system_check/base_check.rb'
# Offense count: 4
# Offense count: 4
# Cop supports --auto-correct.
# Cop supports --auto-correct.
Style/UnlessElse
:
Style/UnlessElse
:
...
...
app/models/external_issue.rb
浏览文件 @
c379973b
...
@@ -3,6 +3,8 @@
...
@@ -3,6 +3,8 @@
class
ExternalIssue
class
ExternalIssue
include
Referable
include
Referable
attr_reader
:project
def
initialize
(
issue_identifier
,
project
)
def
initialize
(
issue_identifier
,
project
)
@issue_identifier
,
@project
=
issue_identifier
,
project
@issue_identifier
,
@project
=
issue_identifier
,
project
end
end
...
@@ -32,12 +34,8 @@ class ExternalIssue
...
@@ -32,12 +34,8 @@ class ExternalIssue
[
self
.
class
,
to_s
].
hash
[
self
.
class
,
to_s
].
hash
end
end
def
project
@project
end
def
project_id
def
project_id
@
project
.
id
project
.
id
end
end
def
to_reference
(
_from
=
nil
,
full:
nil
)
def
to_reference
(
_from
=
nil
,
full:
nil
)
...
...
app/serializers/base_serializer.rb
浏览文件 @
c379973b
...
@@ -16,11 +16,11 @@ class BaseSerializer
...
@@ -16,11 +16,11 @@ class BaseSerializer
.
as_json
.
as_json
end
end
def
self
.
entity
(
entity_class
)
class
<<
self
attr_reader
:entity_class
def
entity
(
entity_class
)
@entity_class
||=
entity_class
@entity_class
||=
entity_class
end
end
def
self
.
entity_class
@entity_class
end
end
end
end
lib/gitlab/auth/ldap/person.rb
浏览文件 @
c379973b
...
@@ -98,9 +98,7 @@ module Gitlab
...
@@ -98,9 +98,7 @@ module Gitlab
private
private
def
entry
attr_reader
:entry
@entry
end
def
config
def
config
@config
||=
Gitlab
::
Auth
::
LDAP
::
Config
.
new
(
provider
)
@config
||=
Gitlab
::
Auth
::
LDAP
::
Config
.
new
(
provider
)
...
...
lib/system_check/base_check.rb
浏览文件 @
c379973b
...
@@ -70,18 +70,14 @@ module SystemCheck
...
@@ -70,18 +70,14 @@ module SystemCheck
# multiple reasons why a check can fail
# multiple reasons why a check can fail
#
#
# @param [String] reason to be displayed
# @param [String] reason to be displayed
def
skip_reason
=
(
reason
)
attr_writer
:skip_reason
@skip_reason
=
reason
end
# Skip reason defined during runtime
# Skip reason defined during runtime
#
#
# This value have precedence over the one defined in the subclass
# This value have precedence over the one defined in the subclass
#
#
# @return [String] the reason
# @return [String] the reason
def
skip_reason
attr_reader
:skip_reason
@skip_reason
end
# Does the check support automatically repair routine?
# Does the check support automatically repair routine?
#
#
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录