diff --git a/CHANGELOG b/CHANGELOG index c9527e6627ed90ed27db88804e49d22deda25b4c..7e9a447a8f6f229ff009b028b4cb02477bea77e7 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,6 +1,7 @@ Please view this file on the master branch, on stable branches it's out of date. v 8.7.0 (unreleased) + - Don't attempt to look up an avatar in repo if repo directory does not exist (Stan hu) - Preserve time notes/comments have been updated at when moving issue - Make HTTP(s) label consistent on clone bar (Stan Hu) - Fix avatar stretching by providing a cropping feature diff --git a/app/models/repository.rb b/app/models/repository.rb index 908d765fb47d3437899275c01942392b00badb3d..c07e807204357328e103158e0cd2e21ba7c9305b 100644 --- a/app/models/repository.rb +++ b/app/models/repository.rb @@ -889,6 +889,8 @@ class Repository end def avatar + return nil unless exists? + @avatar ||= cache.fetch(:avatar) do AVATAR_FILES.find do |file| blob_at_branch('master', file) diff --git a/spec/models/project_spec.rb b/spec/models/project_spec.rb index 20f06f4b7e1412cc8d643ca23b566e249dc621d2..55f1c665b869ee8ba2c35f0efd318f182d153483 100644 --- a/spec/models/project_spec.rb +++ b/spec/models/project_spec.rb @@ -422,6 +422,12 @@ describe Project, models: true do it { should eq "http://localhost#{avatar_path}" } end + + context 'when git repo is empty' do + let(:project) { create(:empty_project) } + + it { should eq nil } + end end describe :ci_commit do diff --git a/spec/models/repository_spec.rb b/spec/models/repository_spec.rb index 417f11acca4f45168920f6501cd8ce06a685324f..f10d671104c0fa5dff8960263cf0d60c1f9a2c0c 100644 --- a/spec/models/repository_spec.rb +++ b/spec/models/repository_spec.rb @@ -744,6 +744,12 @@ describe Repository, models: true do end describe '#avatar' do + it 'returns nil if repo does not exist' do + expect(repository).to receive(:exists?).and_return(false) + + expect(repository.avatar).to eq(nil) + end + it 'returns the first avatar file found in the repository' do expect(repository).to receive(:blob_at_branch). with('master', 'logo.png').